[wp-trac] [WordPress Trac] #2382: Edit and Delete buttons do not work within the Manage's search results page

[WordPress Trac]

#2382: Edit and Delete buttons do not work within the Manage's search results page
-------------------------------------------------+-------------------------
 Reporter:  wellsdjohn                           |       Owner:  westi
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:
Component:  Administration                       |     Version:  2.0
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  search result edit delete bg|has-    |     Focuses:
  patch bg|commit                                |
-------------------------------------------------+-------------------------

Comment (by maker33user):

 Thanks for raising this and for the patch, @westi.

 I tested the changes locally (applying 2382.diff) and confirm that the
 Edit and Delete buttons now work correctly in the search results under
 Manage Posts/Pages. Using $post->ID instead of the undefined $id does
 resolve the broken links.

 A couple of notes / suggestions:

 It might be good to add a small unit or integration test to ensure future
 changes don’t reintroduce this regression.

 Could you please double check if there are other “action=edit” /
 “action=delete” links in adjacent admin screens or list tables that might
 also be using $id incorrectly?

 If this fix is acceptable to the maintainers, it seems safe to back-port
 to earlier 2.x releases (if still maintained) to avoid regressions for
 sites stuck on older versions.

 Overall, the patch is clean, minimal, and addresses precisely the bug
 description. Thanks!

 Let me know if you’d like me to help review or test further.
 https://openpulse.blog https://nextbuzzfeed.blog https://thinksphere.shop
 https://turn-photo-into-line-drawing.blog https://trendblazer.cloud
 https://titanperspective.site https://pixelorbit.site
 https://neuraldock.site https://byteecliptic.site https://aicrate.site
 https://eduveritas.site https://vaulttrail.site https://studypinnacle.site
 https://factsverve.site https://secretseoservices.com
 https://infoglimpse.online https://echonova.cloud https://urbanvanta.blog
 https://coreinsight.blog https://dailyscrolls.blog
 https://inspirescoop.blog https://globalvista.blog
 https://brightnestle.blog https://primehatch.blog https://talkcrate.blog
 https://revealwithai.blog https://buzzrealm.blog

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/2382#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform