[wp-trac] [WordPress Trac] #64080: WP_Upgrader doesn't release lock on create_lock

[WordPress Trac]

#64080: WP_Upgrader doesn't release lock on create_lock
-----------------------------+-----------------------------
 Reporter:  skithund         |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  4.5
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 By default `WP_Upgrader::create_lock( 'foo' );` should release existing
 lock after one hour, if the lock is still active.

 This doesn't happen at least on current release of MariaDB and PHP 8.4.

 `wpdb` documentation says that `query` method "returns an integer value
 indicating the number of rows affected/selected", so WP_Upgrader should
 check for `0` return value, which MariaDB is returning if no rows are
 affected, since the lock exists. And possibly check `false` for backwards
 compatibility/database error?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64080>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform