[wp-trac] [WordPress Trac] #63568: WP_Font_Face: Font names that contain single quotes are not wrapped in double quotes

[WordPress Trac]

#63568: WP_Font_Face: Font names that contain single quotes are not wrapped in
double quotes
-------------------------------------------------+-------------------------
 Reporter:  wildworks                            |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  6.9
Component:  Editor                               |     Version:  6.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-test-info has-         |     Focuses:  ui
  screenshots has-unit-tests needs-testing dev-  |
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by wildworks):

 I apologize for the late reply. I don't have much bandwidth available, but
 I'll try my best to review the PR9951 this week.

 I'd also like to send a message to @dmsnell about this matter. That's
 because he has a deep understanding of these kinds of problems.

 To summarize this ticket, the goal is to properly escape the characters
 included in the font family name using the new
 [https://github.com/WordPress/wordpress-develop/pull/9951/files#diff-
 164304ab7c0c39b76f3b0801e1c2180f289ca0a49acd8a1d7497ea9db2bd34e9R394
 normalize_css_font_family() function] and enclose them in double quotes.


 Actual:

 {{{
 <style class='wp-fonts-local'>
 @font-face{
   font-family: O'Reilly Sans;
 }
 </style>
 }}}

 Expected:

 {{{
 <style class='wp-fonts-local'>
 @font-face{
   font-family: "O'Reilly Sans";
 }
 </style>
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63568#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform