[wp-trac] [WordPress Trac] #44923: Filter .children class on nested comments list

[WordPress Trac]

#44923: Filter .children class on nested comments list
------------------------------------+------------------------------
 Reporter:  greenshady              |       Owner:  (none)
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Comments                |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  css
------------------------------------+------------------------------

Comment (by kadamwhite):

 Thank you for the patch. At WC Kansai contributor day we've discussed
 this, and aren't sure the best person to endorse inclusion of a new
 filter. tagging @davidbaumwald for opinions as the listed Comments
 maintainer. (Any change would be for 7.0 or later, at this point in the
 6.9 cycle)

 @Shizumi Thank you for your patch. My feedback is that including
 `class=""` in the filter makes it harder to escape; if you had the output
 code look like this,

 {{{#!php
 <ol class="<?php echo esc_attr( $class_names ); ?>">
 }}}

 and then had the filter only apply to the string of class names, it would
 be simpler.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44923#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform