[wp-trac] [WordPress Trac] #53323: Place Hello Dolly in containing folder

[WordPress Trac]

#53323: Place Hello Dolly in containing folder
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  afragen
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Upgrade/Install                      |     Version:  5.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests has-test-info         |     Focuses:
  changes-requested has-patch                    |
-------------------------------------------------+-------------------------

Comment (by SirLouen):

 I decided to step debug using my
 [https://core.trac.wordpress.org/ticket/53323#comment:52 previous upgrade
 technique], because I've been unable to run Xdebug with WP-Cli 💀

 Finally, I found the problem of why
 [https://core.trac.wordpress.org/ticket/53323#comment:60 my solution]
 despite the code was right (I tested the code independently), wasn't
 applying during the core upgrade.

 It appears that placing this code in that file proposed will only apply
 when updating via the Update button in `/wp-admin/update-core.php` but not
 via `wp-cli core update` because it happens that CLI is taking another
 route for upgrading (and maybe automated upgrades also take another route,
 who knows 🤷‍♂️)

 I'm not an expert in Core Upgrades area but from what I've been reviewing
 a possible solution that is working for me is adding the code in `src/wp-
 admin/includes/upgrade.php`
 ([https://core.trac.wordpress.org/attachment/ticket/53323/53323-upgrade-
 activation.diff attached patch here])

 And with this finally accomplished, I would suggest that this patch is
 ready to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53323#comment:67>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform