[wp-trac] [WordPress Trac] #53323: Place Hello Dolly in containing folder

[WordPress Trac]

#53323: Place Hello Dolly in containing folder
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  afragen
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Upgrade/Install                      |     Version:  5.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests has-test-info         |     Focuses:
  changes-requested has-patch                    |
-------------------------------------------------+-------------------------

Comment (by SirLouen):

 Replying to [comment:61 afragen]:
 > @SirLouen great sleuthing. I didn’t see the array to add the directory.
 I’ll update the PR.
 >
 > My suggestion is to create another PR to keep Hello Dolly active. Just
 my opinion but if deactivated I doubt the site owner will notice. After
 all, it’s only present to show the “hope and enthusiasm of a generation”.

 This is something that was commented by @peterwilsoncc
 [https://core.trac.wordpress.org/ticket/53323?replyto=61#comment:44 back
 in the day]. It has so many active installs (still 700,000+ nowadays)

 More info about my research: I've tested and its not working with the code
 I provided. This seems that is going to be tricky as hell. Let's see how
 can I stepdebug a core update run with wp-cli…

 Maybe we could open another PR for this, but both should go in at the same
 time; otherwise the second will be completely useless since it's so
 specific to this topic. I agree that is nothing massive to keep it up
 after update (and it feels its going to be a hassle, maybe @peterwilsoncc
 could give some ideas on how to make this happen
 [https://core.trac.wordpress.org/ticket/53323?replyto=61#comment:60 based
 on my last comment])

 **Also very important** don't forget to add the rules in `.gitignore` for
 this patch, to avoid deletion of hello for the repository (it's like the
 default plugin and should be tracked).

 [[Image(https://i.imgur.com/CQrj9rq.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53323#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform