[wp-trac] [WordPress Trac] #30575: Twenty Fourteen: Submenu items on dropdown menus nearly impossible to select on some Android mobile tablets

[WordPress Trac]

#30575: Twenty Fourteen: Submenu items on dropdown menus nearly impossible to
select on some Android mobile tablets
---------------------------+-----------------------------
 Reporter:  zoonini        |       Owner:  (none)
     Type:  defect (bug)   |      Status:  assigned
 Priority:  normal         |   Milestone:  Future Release
Component:  Bundled Theme  |     Version:  4.0.1
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:  javascript
---------------------------+-----------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing => needs-patch


Comment:

 == New Patch Recap

 For anyone willing to take this report in 2025 here some updated
 information to restart fast and furious:

 1. Presently, the best patch
 [https://core.trac.wordpress.org/attachment/ticket/30575/new_functions.patch
 is this one], but is not applying. [https://github.com/WordPress
 /wordpress-develop/pull/8820 I have refreshed it in this new PR], so if
 you are willing to continue, you can have some basic working code applying
 easily.

 2. In 2025 I recommend for the next patch, to open a GitHub PR, don't send
 a patch file, because WordPress Playground has a functionality to add a PR
 and considering that this will mostly be tested over a tablet, its always
 great to have this option straight out of the box.

 === Testing Instructions

 - With the latest patch mentioned in hand
 [https://core.trac.wordpress.org/ticket/30575#comment:13 davidakennedy, in
 this comment], there are some issues pending to be solved.

 Mainly these 4 items have to be sorted:

 > 1. One issue is that if you click/touch an item with a sub-menu and it
 opens, you cannot close it. 2. Clicking on the body and/or outside the
 sub-menu won't close it and it hangs open so that's something we should
 refine. Twenty Sixteen does this. You can click outside of the sub-menu
 and it closes.
 > 2. If you first load a page below the specified breakpoint for the
 mobile menu toggle, then resize the menu to a screen size above that
 breakpoint, the accessible focus styles (when tabbing through menus to
 display sub-menus) do not work. So it looks like the .focus class isn't
 applied.
 > 3. The breakpoint in the CSS for the mobile menu toggle is 783px. But in
 the JavaScript, it's 781, so we should make that consistent.
 > 4. It would be good to add a check at the beginning of the function to
 make sure the menu exist before going forward. It's possible child themes
 could not have a menu, and/or disable the fallback for custom menus.

 PS: I'm removing all workflow tags, including `has-patch` to get attention
 more easily (generally is easier to ignore `changes-requested` for old
 reports, as they tend to be directed to the OG patch creator, so in this
 case, its better to start from scratch with a little lead from what I
 comment in this recap).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/30575#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform