[wp-trac] [WordPress Trac] #49787: Twenty Nineteen: Highlight text color isn't reflected in the editor

[WordPress Trac]

#49787: Twenty Nineteen: Highlight text color isn't reflected in the editor
-----------------------------+-----------------------------
 Reporter:  karmatosed       |       Owner:  poena
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  Future Release
Component:  Bundled Theme    |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:  css
-----------------------------+-----------------------------
Changes (by SirLouen):

 * keywords:  needs-testing has-patch => has-patch close


Comment:

 == Combined Bug Reproduction And Patch Test Report
 === Description
 🟠 This report can't fully validate that the issue can be reproduced, but
 can validate that the patch fully solves the problem reported.

 === Environment
 - WordPress: 6.9-alpha-60093-src
 - PHP: 8.2.28
 - Server: nginx/1.27.5
 - Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 136.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Nineteen 3.1
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0
   * WordPress Importer 0.8.4

 === Bug Reproduction Steps
 1. [https://core.trac.wordpress.org/ticket/49787#comment:21 Using the
 basic instructions provided by poena] to reproduce this issue.
 2. The only difference is that, when clicking More Options, there is a new
 option called "Highlight"
 3. 🐞 If I highlight with blue or gray, I can't seem to see a difference,
 these are the main colours.
 4. ❌ If I highlight with a clear different colour like a custom colour or
 a white colour, the difference is there.
 Screencast attached to showcase these two scenarios.

 === Actual Results with patch
 1.  ✅ Issue is completely resolved with the patch
 Screencast attached to showcase resolution

 === Additional Notes
 - Judging by the @poena latest reproduction steps, it appears that some
 update has come from upstream with the Highlight menu, but still doesn't
 fully solve the problem (and also judging by the GB40279 report it seems
 there could be some causation upstream).
 - As pointed out by @smit08
 [https://core.trac.wordpress.org/ticket/49787#comment:9 this only happens
 with main colours].
 - From a code review, white is the only colour, that doesn't seem to need
 additional CSS rules, only the 3 primary colours (the two blues and the
 grey) seem to be affected.

 Maybe this needs to further be checked upstream, setting a `close`
 candidate for `reported-upstream`, if a new ticket happens to pop in GB
 repo regarding this topic.

 === Supplemental Artifacts
 🟠 Without patch sample screencast: https://streamable.com/7nwkvw
 ✅ With patch screencast: https://streamable.com/p7slfc

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49787#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform