[wp-trac] [WordPress Trac] #31127: Can't add a new user to two sites before they've accepted their account

[WordPress Trac]

#31127: Can't add a new user to two sites before they've accepted their account
----------------------------------------------+------------------------
 Reporter:  ericlewis                         |       Owner:  (none)
     Type:  defect (bug)                      |      Status:  assigned
 Priority:  normal                            |   Milestone:
Component:  Users                             |     Version:  3.0
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch needs-unit-tests close  |     Focuses:  multisite
----------------------------------------------+------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-unit-tests needs-testing => has-patch needs-
     unit-tests close


Comment:

 == Bug Reproduction Report
 === Description
 🟠 This report can't fully validate that the issue is, actually, an issue
 as-is.

 Patch tested: https://github.com/WordPress/wordpress-
 develop/pull/8816.diff

 === Environment
 - WordPress: 6.9-alpha-60093-src
 - PHP: 8.2.28
 - Server: nginx/1.27.5
 - Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 136.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Twenty-One 2.5
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0

 === Bug Reproduction
 1. Move into Multisite
 2. Create a second site
 3. Create a user in the first site in Add User > Add User
 4. Go to the second site and create a user again with Add User with the
 exact same credentials as the first site
 5. 🐞 Error: `That username is currently reserved but may be available in
 a couple of days.`
 6. Get back to the first site
 7. Try to add again the same user with the same credentials
 8. 🐞 Error: `That username is currently reserved but may be available in
 a couple of days.`

 === Patch Results
 - 🟠 The patch only solves one part of this problem

 === Further discussion
 While I was working on the refresh of the original patch, I noticed the
 following:

 1. Once you add a user in a multiuser site without skipping the
 confirmation email, it gets into this temporary table for confirmation.
 This affects all sites, including the site itself when you added the user.

 2. With the patch, after creating the user on the first site, we can go to
 a second site and create again the same user, sending the verification
 email once more. This, to some extent, solves part of this problem

 3. But the problem I believe that is bigger: The main problem here is that
 there is no way in the interface, AFAIK, to resend the already non-
 confirmed user's email again. With the patch, it "simulates" this
 behavior, if we recreate the user from a second site.

 4. The solution can be two-folded
 A. Replicating the idea in this patch, with the main site also, so once
 filling again the same credentials in Add User, it will send once more
 another refresher verification email
 B. Having access to the list of non-confirmed users in the User's
 interface, with the possibility of resending the verification email.

 === Conclusion

 I think that this is very correlated with #16001 as
 [https://core.trac.wordpress.org/ticket/31127#comment:1 SergeyBiryukov
 commented back in the day]. In fact, I believe that it's so correlated
 looked from the right angle, that could be a duplicate candidate.

 But maybe there is another standpoint I'm not considering. For now, I mark
 this as a `close` candidate because I would set this as `duplicate` given
 my observations.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/31127#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform