[wp-trac] [WordPress Trac] #61117: Guard condition in `delete_temp_backup()` shouldn't return early

[WordPress Trac]

#61117: Guard condition in `delete_temp_backup()` shouldn't return early
---------------------------------------+-----------------------------
 Reporter:  johnbillion                |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  low                        |   Milestone:  Future Release
Component:  Upgrade/Install            |     Version:  6.3
 Severity:  normal                     |  Resolution:
 Keywords:  needs-test-info has-patch  |     Focuses:
---------------------------------------+-----------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing => needs-test-info has-patch


Comment:

 @johnbillion can you provide with the steps to set up my environment to
 reproduce this?

 I always struggle to test and debug upgraded-related topics.
 But looking for coincidences in the code, I can only see two calls:

 1. [https://github.com/WordPress/wordpress-
 develop/blob/a50a4efd7526c3f81d38e6bf5d648b43702304f6/src/wp-
 admin/includes/class-wp-automatic-updater.php#L568-L576 In the automatic
 upgrader], the array is pretty much already defined, and doesn't make
 sense to iterate it given that it only has one element

 2. [https://github.com/WordPress/wordpress-
 develop/blob/a50a4efd7526c3f81d38e6bf5d648b43702304f6/src/wp-
 admin/includes/class-wp-upgrader.php#L935 As a hook call in the same file]
 with no parameters, so in this case it will get the property
 `temp_restores` which happens to be a part of `$options['hook_extra']`
 which seems to be also a single unit.

 So I cannot see where and how it can iterate through multiple backups;
 hence I cannot reproduce the intent of this report. I know it's a little
 old report (1 year), but can you remember how did you identify this
 potential issue back in the day? For helping test and peer review this
 kind of requests, [https://make.wordpress.org/test/2025/05/15/building-
 the-testing-use-case/ a Testing Use Case is gold]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61117#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform