[wp-trac] [WordPress Trac] #37484: Make form in request_filesystem_credentials() in line with WP admin form styling / HTML structure / security

[WordPress Trac]

#37484: Make form in request_filesystem_credentials() in line with WP admin form
styling / HTML structure / security
-----------------------------------------+---------------------------------
 Reporter:  dashaluna                    |       Owner:  (none)
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  Future Release
Component:  Upgrade/Install              |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch has-screenshots  |     Focuses:  ui, administration
-----------------------------------------+---------------------------------

Comment (by jorbin):

 From #36973 (note, the first link is now a 404)

 As reported by @melchoyce in https://github.com/obenland/shiny-
 updates/issues/100, the filesystem credentials dialog needs some love to
 improve accessibility and the overall design.

 Here's how it could look like: https://cloudup.com/cnvj5NqMefR

 Her notes:

 Update modal style to bring more in-line with other wp-admin modals — like
 including an "x" for closing (even though there's also a cancel button)
 Make "Proceed" primary
 Also consider changing "proceed" to something more descriptive — maybe
 connect? Proceed might be okay, it's just such a weird-sounding word.
 Maybe switch the "proceed" in both the description and the button to
 "continue."
 "This password will not be..." could stand to be decreased in size just a
 little and made a lighter grey, to match descriptions on the settings
 pages. At the very least, the line-height should decrease.
 "Authentication Keys" is at the same level of hierarchy as the field
 labels. It should probably be bigger, since it's a header above the
 labels.
 Additionally: the modal is really tall for mockup purposes, but would
 ideally be whatever height we normally max modals out at. Any content not
 visible because of height would be scrollable in the modal, like we do in
 others.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37484#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform