[wp-trac] [WordPress Trac] #36710: Symlinked directories should not be deleted recursively

[WordPress Trac]

#36710: Symlinked directories should not be deleted recursively
-------------------------------------------------+-------------------------
 Reporter:  andy                                 |       Owner:  (none)
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Filesystem API                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-test-info dev-         |     Focuses:
  feedback needs-dev-note                        |  administration
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing has-test-info => has-patch has-test-
     info dev-feedback needs-dev-note
 * type:  defect (bug) => feature request
 * severity:  major => normal


Comment:

 == Reproduction Report and Patch Testing
 === Description
 ❓ This report validates that the issue can be reproduced, but can attest
 if the behavior reported is the real expected.

 === Environment
 - WordPress: 6.9-alpha-60093-src
 - PHP: 8.2.28
 - Server: nginx/1.27.5
 - Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 136.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Twenty 2.9
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0

 === Reproduction of the Issue
 1.
 [https://core.trac.wordpress.org/ticket/36710?replyto=description&reply=%E2%86%B3+Reply#comment:27
 I've used these instructions]
 2. For this test, I've used a very simple plugin, with just a folder and a
 single file.
 3. I've reproduced with these instructions and my result is:
 - ✅ Symlink is not deleted
 - ✅ Files within the plugin folder are deleted
 - ✅ Plugin folder is not deleted.

 Note for testers: For reproduction under docker container conditions, I
 had to access the docker container straight because symbolic links to
 directories in the volume are considered plain files within the docker
 container

 === Results with the Patch
 - ❓Symlink is deleted
 - ❓Files within the plugin are not deleted
 - ❓Plugin folder is not deleted.

 === Additional Notes

 - I don't really know what to expect with this patch (apart from what OP
 thinks is the right thing) because when playing with things like that have
 not even been documented, this cannot be considered a bug, but an
 enhancement or a feature request.
 - But whatever decision is taken, this behavior should be rightly
 documented.
 - More problems arise from this particular patch: What about many other
 filesystems like FTPExt, FtpSockets and SSH2? I believe there should be a
 unified behavior among all 4 supported filesystems.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36710#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform