[wp-trac] [WordPress Trac] #50683: Parse content for shortcodes instead of using regex

[WordPress Trac]

#50683: Parse content for shortcodes instead of using regex
-------------------------------------------------+-------------------------
 Reporter:  cfinke                               |       Owner:
                                                 |  johnbillion
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Shortcodes                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  test-info                                      |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:
     has-patch has-unit-tests early needs-testing early-like-actually-early
     needs-test-info
     => has-patch has-unit-tests needs-test-info


Comment:

 Replying to [comment:36 johnbillion]:
 > I updated the tests so the speed test runs 20 times during each run
 (https://github.com/WordPress/wordpress-develop/actions/runs/1108267266).
 Loads of variance between the 20 test runs on all PHP versions.

 Given that the performance impact is significant and that there has not
 been any relevant improvement to sort this, there is no real testing
 target at the moment.

 Adding up, I'm not totally convinced that doing multiple PHPUnit runs to
 test performance, is the best available option.

 Personally, I'm curious
 [https://core.trac.wordpress.org/ticket/50683?replyto=36#comment:7 on how
 this was executed]. Looked pretty solid testing, but code for such was
 never provided.

 I'm doing a little clean-up on keywords because, at last, this ticket has
 fully lost all momentum.

 Replying to [comment:43 dmsnell]:
 > These are behavioral changes, but I think there's compelling reason to
 consider them apart from this particular issue. They would fit nicely with
 this issue.

 All great, but still, we are missing here pretty much everything (a
 performant patch, and a use-case to replicate a test performance
 consistently)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50683#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform