[wp-trac] [WordPress Trac] #53816: Overview: Refactor the widgets read/write logic

[WordPress Trac]

#53816: Overview: Refactor the widgets read/write logic
-------------------------------------------------+-------------------------
 Reporter:  zieladam                             |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Widgets                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-docs  |     Focuses:
  needs-dev-note needs-test-info                 |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:
     has-patch has-unit-tests needs-docs needs-testing needs-dev-note
     needs-test-info
     => has-patch has-unit-tests needs-docs needs-dev-note needs-test-info


Comment:

 I'm trying to understand this PR for testing purposes.

 Following the [https://core.trac.wordpress.org/ticket/53816#comment:27
 testing instructions from hellofromTonya], unfortunately I can't get to a
 testing conclusion: Things work just before and after... so I can't really
 understand what is the point of this patch:

 1. If it's not a broken functionality in the present, and its not going to
 break in the future (deprecations,...), are we talking about code
 refactor?
 2. Or it's a performance improvement?
 2. Or maybe the testing instructions are insufficient, and there is
 actually a scenario where things break?

 If it's the former (which judging by the code, it doesn't look so), then
 it enters [https://make.wordpress.org/core/handbook/contribute/code-
 refactoring/ this category], so no much progress should be done further
 (or a simple ad-hoc testing use-case should be built to visualize the
 effect of the improvement).

 If it's the second, I wonder if we should add the `performance` focus, and
 add some performance testing…

 But if it's the latter, then I would be expecting some testing
 instructions that actually showcase what's broken. I am not sure if
 @zieladam is back around to review this and give more insight.

 PS: As expected, Unit Tests are passing both before and after applying the
 patch, so they don't say anything to me neither.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53816#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform