[wp-trac] [WordPress Trac] #63436: PHPCS for Class FTP files

[WordPress Trac]

#63436: PHPCS for Class FTP files
------------------------------------+-------------------------------
 Reporter:  SirLouen                |       Owner:  (none)
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  General                 |     Version:
 Severity:  trivial                 |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  coding-standards
------------------------------------+-------------------------------
Changes (by SirLouen):

 * keywords:  2nd-opinion has-patch => has-patch dev-feedback


Comment:

 The two main topics commented in the last `<dev-chat>`
 1. @westonruter suggested adding PHPCS checks simply to new lines in PRs
 (to avoid the late increase of PHPCS number of tickets).
 2. @joemcgill and @desrosj proposed doing a full audit of current external
 libs and see which are still maintained upstream before taking further
 steps in this regard.

 We could use this topic for further discussion about this (considering
 that PemFTP is one of those abandoned libraries that will not receive
 upstream support anymore).

 Since `class-ftp` is and will be maintained by WordPress developers for
 now and the future, it makes sense to open the PHPCS dam because PHPCS, as
 @desrosj pointed out in the meeting, brings more clarity to the code (and
 the main reason of the approval of [59846])

 But we must assume that this will be on hold until some action taken (like
 acting on the proposed audit)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63436#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform