[wp-trac] [WordPress Trac] #63416: WPCS in PemFTP library

[WordPress Trac]

#63416: WPCS in PemFTP library
--------------------------------+-------------------------------
 Reporter:  tristup             |       Owner:  (none)
     Type:  enhancement         |      Status:  new
 Priority:  lowest              |   Milestone:  Awaiting Review
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  2nd-opinion         |     Focuses:  coding-standards
--------------------------------+-------------------------------

Comment (by SirLouen):

 Replying to [comment:7 sabernhardt]:
 > I do not recommend removing the exclusion (#63436).
 >
 > PR 8799's [https://github.com/WordPress/wordpress-
 develop/actions/runs/14981659551/job/42087006412?pr=8799 GitHub Action for
 coding standards] lists 4,383 errors, and many of them relate to
 **naming**:
 > - 3 Constants must be uppercase
 > - 5 Class name must begin with a capital letter (plus "Class name is not
 valid" errors for `ftp_base`, `ftp_pure` and `ftp_sockets`)
 > - 7 Member variable is not in valid snake_case format
 > - 41 Object property is not in valid snake_case format

 This can be fixed easily.

 But in that case, does it make sense, to keep the PHPCS update in `class-
 ftp`? After all, it’s editing the core code without the original library
 support.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63416#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform