[wp-trac] [WordPress Trac] #63416: WPCS in PemFTP library

[WordPress Trac]

#63416: WPCS in PemFTP library
-------------------------------------+-------------------------------
 Reporter:  tristup                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  lowest                   |   Milestone:  Awaiting Review
Component:  External Libraries       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |     Focuses:  coding-standards
-------------------------------------+-------------------------------
Changes (by sabernhardt):

 * keywords:  needs-refresh => needs-patch 2nd-opinion
 * type:  defect (bug) => enhancement


Comment:

 If one of the old PemFTP files follows coding standards in its entirety, I
 would think all three files should. Then the code sniffer might not need
 to [https://github.com/WordPress/wordpress-
 develop/blob/71b2dd282aeb9d33d169f7b2dbab0b896a9d1068/phpcs.xml.dist#L49
 ignore them].

 - The ticket description mentions `class-ftp-sockets.php`.
 - The patch proposes changes for `class-ftp-pure.php`, and it fails to
 apply to my installation (likely due to incompatible formatting).
 - [59846] revised some lines in `class-ftp.php`, establishing a precedent,
 but that was incomplete.

 Documentation changes could be worth more than meeting coding standards.
 Several functions are not documented, and some of the comments are in
 French (including a few //abbreviated// French words).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63416#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform