[wp-trac] [WordPress Trac] #63379: Fix for deprecated rtrim passing null to parameter

[WordPress Trac]

#63379: Fix for deprecated rtrim passing null to parameter
-------------------------------------------------+-------------------------
 Reporter:  shanemac10                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Formatting                           |     Version:  6.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info dev-feedback        |     Focuses:  php-
  changes-requested                              |  compatibility
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch has-testing-info dev-feedback => has-testing-info
     dev-feedback changes-requested


Comment:

 Generally this kind of plugins that are related to SEO lean towards
 manipulation of URL which could easily end in this error/deprecation
 notices.

 As I commented in [https://core.trac.wordpress.org/ticket/63379#comment:8
 my test report], I truly believe that this should be handled with any of
 the 3 method proposed.

 Personally I prefer static typing but I doubt this will be implemented
 this way because AFAIK WP rarely do this in any of the funtions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63379#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform