[wp-trac] [WordPress Trac] #62718: Automatic updater of WordPress always fails if FS_METHOD is ftpext since 6.6 with PHP 8.0+

[WordPress Trac]

#62718: Automatic updater of WordPress always fails if FS_METHOD is ftpext since
6.6 with PHP 8.0+
-------------------------------------------------+-------------------------
 Reporter:  hideishi                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.9
Component:  Upgrade/Install                      |     Version:  6.6
 Severity:  major                                |  Resolution:
 Keywords:  needs-unit-tests has-testing-info    |     Focuses:
  dev-feedback has-patch                         |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:10 SirLouen]:
 > judging by the patch commited that was failing tests [59981]
 >
 > I think that the only issue was a missing bracket by the end, in line
 1021
 >
 > Before adding that bracket 4 tests failed, after adding, they are all
 passing.

 Good catch, thanks! I think it might be not the bracket (they appear to be
 balanced in that commit), but the fact that I removed the `if ( !
 $wp_filesystem ) { ... }` conditional which should have been kept to avoid
 unnecessarily recreating `$wp_filesystem` on each call.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62718#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform