[wp-trac] [WordPress Trac] #63187: Wrong Inconsistent Permissions Check in Filesystems

[WordPress Trac]

#63187: Wrong Inconsistent Permissions Check in Filesystems
----------------------------+-------------------------------------------
 Reporter:  SirLouen        |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Filesystem API  |    Version:  trunk
 Severity:  blocker         |   Keywords:  dev-feedback has-testing-info
  Focuses:                  |
----------------------------+-------------------------------------------
 This line is checking with only two parameters: `$source` and
 `$destination`:

 https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/update-core.php#L1083


 But if it happens to reach this function (copy):

 Filesystem Direct: https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/class-wp-filesystem-direct.php#L305
 Filesystem FTPEXT: https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/class-wp-filesystem-ftpext.php#L346
 FTP Socket: https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/class-wp-filesystem-ftpsockets.php#L357

 It will **always** return false, hence an error.

 Simple solution, added in the following patch (sending true to the
 function)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63187>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform