[wp-trac] [WordPress Trac] #63136: Build/Test Tools: Add Unit Tests for `wp_fast_hash()`

[WordPress Trac]

#63136: Build/Test Tools: Add Unit Tests for `wp_fast_hash()`
--------------------------------------+--------------------------
 Reporter:  debarghyabanerjee         |       Owner:  johnbillion
     Type:  task (blessed)            |      Status:  reviewing
 Priority:  normal                    |   Milestone:  6.8
Component:  Security                  |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  tests
--------------------------------------+--------------------------

Comment (by devsahadat):

 Thank you for the patch proposal. After reviewing the wp_fast_hash()
 function and the added tests, I agree with @johnbillion’s concerns. The
 function is simple, always returns a non-empty value, and relies on
 Sodium, which is already well-tested. Adding tests for these basic
 behaviors doesn’t add significant value and could increase maintenance
 overhead in the future. I recommend reconsidering the addition of these
 specific unit tests unless further logic is added to the function.

 Looking forward to your feedback.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63136#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform