[wp-trac] [WordPress Trac] #62718: Automatic updater of WordPress always fails if FS_METHOD is ftpext since 6.6 with PHP 8.0+

[WordPress Trac]

#62718: Automatic updater of WordPress always fails if FS_METHOD is ftpext since
6.6 with PHP 8.0+
-------------------------------------------------+-------------------------
 Reporter:  hideishi                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.9
Component:  Upgrade/Install                      |     Version:  6.6
 Severity:  major                                |  Resolution:
 Keywords:  needs-unit-tests has-testing-info    |     Focuses:
  changes-requested reporter-feedback            |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing needs-unit-tests has-testing-info =>
     needs-unit-tests has-testing-info changes-requested reporter-feedback


Comment:

 == Combined Patch and Bug Reproduction Report
 === Description
 This report can't validate whether the issue can be replicated.

 Patch tested: https://github.com/WordPress/wordpress-
 develop/pull/8579.diff

 === Environment
 - WordPress: 6.8-beta3-60042-src
 - PHP: 8.2.28
 - Server: nginx/1.27.4
 - Database: mysqli (Server: 8.4.4 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 134.0.0.0
 - OS: Windows 10/11
 - Theme: My Twenty Twenty Child Theme 1.0
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0

 === Bug Reproduction
 1. First, we need to set up a FTP environment. Not an easy task, one of
 the most convoluted and worst documented topics in WP by far, personally I
 would choose this patch https://github.com/WordPress/wordpress-
 develop/pull/8589 that is the most straightforward way I've found to test
 this properly
 2. We need to set in `wp-config.php`
 {{{
 define( 'FS_METHOD', 'ftpext' );
 define( 'FTP_HOST', 'ftp' );
 define( 'FTP_SSL', false );
 }}}
 We are not setting any other credentials according to the report

 Now we have a fully ftpext FTP working in ftp host

 3. Now we execute a plugin update. I simply reduce the version of Hello
 Dolly.

 4. System triggers for credentials: https://i.imgur.com/O1XfgH1.png
 I can't see any errors in log

 5. I put the credentials and finish the update

 6. 🐞 Bug occurs. Several Warnings, update doesn't happen

 {{{
 Warning: ftp_rmdir(): Remove directory operation failed. in /var/www/src
 /wp-admin/includes/class-wp-filesystem-ftpext.php on line 404
 Warning: ftp_rmdir(): Remove directory operation failed. in /var/www/src
 /wp-admin/includes/class-wp-filesystem-ftpext.php on line 415
 }}}

 === Expected Results

 - The update happens without any troubles since we are inputting the
 credentials manually.

 === Results after the patch

 - ❌ Same errors as before the patch.

 === Additional Notes
 1. One of the main hindrances I've found trying to debug this is testing
 towards a core update that has resulted in one even bigger bug that is
 completely blowing my mind: #63173
 2. So I have to test this only with plugins like Hello Dolly.
 3. Maybe I'm issing one step in the process. I ask reporter @hideishi to
 review this process.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62718#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform