[wp-trac] [WordPress Trac] #63173: FS_Method with ftpext and Core Updates

[WordPress Trac]

#63173: FS_Method with ftpext and Core Updates
----------------------------+-----------------------------
 Reporter:  SirLouen        |      Owner:  (none)
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Filesystem API  |    Version:  trunk
 Severity:  major           |   Keywords:
  Focuses:                  |
----------------------------+-----------------------------
 This is one of the strangest bugs I've found so far.

 There is a weird behaving section in the code:
 https://github.com/WordPress/wordpress-
 develop/blob/b943118a5b1967591fa1d15ee1ee87f93b7c0147/src/wp-
 admin/includes/update-core.php#L1057-L1073

 When using `FS_METHOD` `ftpext`, it behaves in the following way:
 - During a core update, it checks for files in the update package:
 1. It checks for readme.html and it finds it
 2. It checks for version.php and it doesn't find it.
 But both do exist.

 So it ends in this error: `The update could not be unpacked`

 Given how generic everything is, this doesn't make sense. FTP Methods for
 `FS_METHOD` have been my nemesis for a decade.

 I've pushed my current FTP setup in case anyone wants to test this issue
 on top of this:
 https://github.com/WordPress/wordpress-develop/pull/8589

 Once set-up, for `wp-config.php` we need:
 {{{
 define( 'FS_METHOD', 'ftpext' );
 define( 'FTP_USER', 'admin' );
 define( 'FTP_PASS', 'password' );
 define( 'FTP_HOST', 'ftp' );
 define( 'FTP_SSL', false );
 }}}

 I'm going to add some screenshots to show the behaviour with more detail

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63173>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform