[wp-trac] [WordPress Trac] #62985: Fix layout support classes to be generated with a stable ID

[WordPress Trac]

#62985: Fix layout support classes to be generated with a stable ID
--------------------------+------------------------
 Reporter:  darerodz      |       Owner:  joemcgill
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  6.8
Component:  Editor        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch has-unit-tests needs-testing has-testing-info =>
     needs-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Reopening this as the `wp_unique_id_from_values()` function includes an
 odd `_doing_it_wrong()` call.

 * There's an unused `sprintf` in the message as there is no placeholder
 * The `empty( $data )` seems a little weird with the function signature
 `wp_unique_id_from_values( array $data, string $prefix = '' ): string`, as
 PHP will fatal if nothing/an incorrect type is passed, and getting a
 signature for an empty array while weird, seems like it could potentially
 be useful.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62985#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform