[wp-trac] [WordPress Trac] #63086: Customizer: notice errror regarding WP_Theme::is_block_theme

[WordPress Trac]

#63086: Customizer: notice errror regarding WP_Theme::is_block_theme
-------------------------------------------------+-------------------------
 Reporter:  wildworks                            |       Owner:  joemcgill
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.8
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-patch dev-      |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-testing-info needs-patch => has-testing-info has-patch
     dev-feedback
 * version:   => trunk


Comment:

 == Test Report
 === Description
 This report validates that the indicated patch works as expected.
 Massive error on my side: I prejudged, mistakenly overestimating the
 correctness of current implementation without doing thorough testing.

 Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress
 /wordpress-develop/pull/8508.diff

 === Environment
 - WordPress: 6.8-beta2-59971-src
 - PHP: 8.2.28
 - Server: nginx/1.27.4
 - Database: mysqli (Server: 8.4.4 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 134.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Twenty-Four 1.3/Twenty Eleven 4.8
 - MU Plugins:
   * SimpleBlock Theme Detection 1.0.0
 - Plugins:
   * Test Reports 1.2.0

 === Testing Steps
 1. I have created an [https://github.com/SirLouen/simple-block-theme-
 detection/archive/refs/tags/1.0.0.zip adhoc plugin] that checks the result
 of `wp_is_block_theme()` function in each step
 2. Install this plugin as a mu-plugin
 3. Add the shortcode `[block_theme_detection]`
 4. Most tests are useless, just for visual purposes.

 === Actual Results
 1.  ✅ Issue resolved with patch 8508

 === Additional Notes
 As expected, the PR 8526 alternative implementation
 [https://i.imgur.com/0996Obs.png fails ❌]

 As many have pointed out, the check and notice should be removed because
 it's completely pointless

 === Supplemental Artifacts

 My test plugin repo: https://github.com/SirLouen/simple-block-theme-
 detection/

 Results with a block theme:

 [[Image(https://i.imgur.com/HabBomI.png)]]

 Results with a non-block theme:

 [[Image(https://i.imgur.com/bjX9Qat.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63086#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform