[wp-trac] [WordPress Trac] #63086: Customizer: notice errror regarding WP_Theme::is_block_theme

[WordPress Trac]

#63086: Customizer: notice errror regarding WP_Theme::is_block_theme
------------------------------------------+------------------------
 Reporter:  wildworks                     |       Owner:  joemcgill
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  normal                        |   Milestone:  6.8
Component:  Customize                     |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  has-testing-info needs-patch  |     Focuses:
------------------------------------------+------------------------
Changes (by SirLouen):

 * keywords:  has-testing-info has-unit-tests needs-patch needs-testing =>
     has-testing-info needs-patch


Comment:

 Replying to [comment:24 afragen]:
 > I'm actually not certain if your suggestion to move the warning to
 wp_is_block_theme() is the solution. I use this call in plugins as well
 and I don't know if it will trigger this warning.

 @afragen are any of these plugins public to test this out?

 Replying to [comment:23 joemcgill]:
 >The intent of that placement still seems correct to me since I'm unsure
 why a plugin would want to call `wp_is_block_theme()` prior to the themes
 actually being set up.

 Maybe we should follow some words that one wise guy once told me in the
 past:

 > I'm not in support of throwing a `_doing_it_wrong` warning in this case,
 as the software cannot know the intent the developer had in doing things
 this way and throwing a warning would be presumptive, at best.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63086#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform