[wp-trac] [WordPress Trac] #63110: Site Editor: Update old URLs to new path-based URLs

[WordPress Trac]

#63110: Site Editor: Update old URLs to new path-based URLs
--------------------------------------+------------------------------
 Reporter:  wildworks                 |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Editor                    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------

Comment (by sainathpoojary):

 Hey @wildworks,

 I have updated the URL for [https://github.com/WordPress/wordpress-
 develop/blob/ed2f2ecd3fa043eca3a064a95fcb4830b5c0765c/src/wp-
 admin/includes/dashboard.php#L2118 dashboard] in the PR. However, the
 other two instances are related to `register_post_type`, where the URL is
 used for `_edit_link`, which is for internal use so I’m unsure how I can
 reproduce this to test it.

 I converted the URL as per the [https://github.com/WordPress/wordpress-
 develop/blob/dd42ceb1bd5d227008c37fcc79ea483505b1090a/src/wp-admin/site-
 editor.php#L32 `_wp_get_site_editor_redirection_url] function, but I'm not
 sure if it's correct. Could you please have a look?

 From:

 {{{
         $navigation_post_edit_link = 'site-editor.php?' . build_query(
                 array(
                         'postId'   => '%s',
                         'postType' => 'wp_navigation',
                         'canvas'   => 'edit',
                 )
         );
 }}}


 {{{
         $template_edit_link = 'site-editor.php?' . build_query(
                 array(
                         'postType' => '%s',
                         'postId'   => '%s',
                         'canvas'   => 'edit',
                 )
         );
 }}}



 To:

 {{{
         $navigation_post_edit_link = 'site-editor.php?' . build_query(
                 array(
                         'p' => '/wp_navigation/%s',
                         'canvas' => 'edit',
                 )
         );
 }}}


 {{{
         $template_edit_link = 'site-editor.php?' . build_query(
                 array(
                         'p' => '/wp_template/%s',
                         'canvas'   => 'edit',
                 )
         );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63110#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform