[wp-trac] [WordPress Trac] #63086: Customizer: notice errror regarding WP_Theme::is_block_theme

[WordPress Trac]

#63086: Customizer: notice errror regarding WP_Theme::is_block_theme
----------------------------------------+------------------------
 Reporter:  wildworks                   |       Owner:  joemcgill
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  6.8
Component:  Customize                   |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-testing-info has-patch  |     Focuses:
----------------------------------------+------------------------

Comment (by gigitux):

 > If not, then we could choose to keep the fix for that ticket in place
 while removing the _doing_it_wrong().

 If the intention is to keep the following logic:

 {{{#!php
 if ( ! did_action( 'setup_theme' ) ) {
     return false;
 }
 }}}

 it is a breaking change and could break several plugins.

 As noted in [63062], it may be worth investigating why `wp_is_block_theme`
 returns an incorrect value before the `after_setup_theme` action and
 addressing that issue directly.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63086#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform