[wp-trac] [WordPress Trac] #60969: Validation of custom links in admin menu not accessible

[WordPress Trac]

#60969: Validation of custom links in admin menu not accessible
-------------------------------------+-------------------------------------
 Reporter:  joedolson                |       Owner:  rcreators
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  6.8
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility,
  commit needs-dev-note              |  javascript
-------------------------------------+-------------------------------------
Changes (by joedolson):

 * keywords:  has-patch needs-testing => has-patch needs-testing commit
     needs-dev-note


Comment:

 I've incorporated the same URL Regex used in the customizer to validate
 the content in the custom link field. With this, there is a change in how
 nav menus behave: previously, the customizer was stricter than the admin
 nav menu interface; they are now the same. There may be values that users
 have added in the admin that will no longer be allowed. They were never
 valid link structures, but that doesn't mean they don't exist.

 Adding #needs-dev-note because of that change. Probably can just be part
 of a group note. Marking for commit; especially with this change, I think
 it's better to get this in earlier. We can always strip out the validation
 in the admin nav menus if necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60969#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform