[wp-trac] [WordPress Trac] #48689: PHP warnings after updating to WP 5.3: ftp_nlist() and ftp_pwd() expect missing parameters

[WordPress Trac]

#48689: PHP warnings after updating to WP 5.3: ftp_nlist() and ftp_pwd() expect
missing parameters
-------------------------------------------------+-------------------------
 Reporter:  Hinjiriyo                            |       Owner:  costdev
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Filesystem API                       |     Version:  5.3
 Severity:  minor                                |  Resolution:
 Keywords:  php80 needs-unit-tests has-patch     |     Focuses:  php-
  changes-requested                              |  compatibility
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * keywords:
     php80 needs-unit-tests has-patch 2nd-opinion changes-requested dev-
     feedback
     => php80 needs-unit-tests has-patch changes-requested


Comment:

 > Silently bailing out without an early error can make debugging harder
 while potentially leaving users and developers wondering why their action
 failed.

 This is my main concern with the suggested patch on this ticket. If there
 is a default scenario where these methods can be called prior to a valid
 resource link being created, then that should be investigated and fixed
 rather than silently returning false from the affected methods.

 This isn't a fun feature to debug, but papering over the issue will just
 make the problem harder to debug.
 [https://core.trac.wordpress.org/ticket/48689#comment:18 Adam's comment
 here] provides info about when this filesystem handler gets called.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48689#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform