[wp-trac] [WordPress Trac] #63013: Twenty Nineteen: Use `sass` instead of `node-sass`

[WordPress Trac]

#63013: Twenty Nineteen: Use `sass` instead of `node-sass`
-------------------------------+------------------------------
 Reporter:  debarghyabanerjee  |       Owner:  (none)
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Bundled Theme      |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  has-patch          |     Focuses:  javascript, css
-------------------------------+------------------------------
Changes (by sabernhardt):

 * component:  Themes => Bundled Theme


Comment:

 > Do you suggest any specific linting rules that should be added in the
 `stylelint-config`?

 Unfortunately, I do not know linting rules well. Some of the rules for
 Twenty Twenty-One could also fit Twenty Nineteen.

 Of course, my reason for mentioning `stylelint-config` is to avoid so many
 changes in the compiled output. A few of the differences should be good,
 but others surprised me.

 - The `sass` output **ignores** five of the selectors when it creates font
 overrides for each non-latin language: `.not-found .page-title`,
 `.error-404 .page-title`, `input[type="button"]`, `input[type="reset"]`,
 and `input[type="submit"]`. That was difficult to notice because the
 compiler rearranges the lists of language selectors.
 - The `#005177` blue becomes `rgb(0, 80.5, 119)`, slightly reducing its
 green value.
 - Many empty lines between rulesets are removed, but not all of them
 consistently.
 - Some comma-separated selectors share a line, where `node-sass` had given
 each its own line.

 I should also point out that Dart Sass gives dozens of deprecation
 warnings when running the build, so switching to it would require
 additional changes soon.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63013#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform