[wp-trac] [WordPress Trac] #63268: PHPStan code quality improvements for 6.9

[WordPress Trac]

#63268: PHPStan code quality improvements for 6.9
----------------------------+-------------------------------
 Reporter:  justlevine      |       Owner:  SergeyBiryukov
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  6.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by logicrays):

 I have reviewed the code updates and they follow the improvements
 suggested by PHPStan. Unused variables, incorrect type handling, and
 potential null references have been properly addressed. The changes
 improve static analysis compatibility without affecting functionality.
 Type safety and code clarity have been enhanced. Everything aligns well
 with WordPress coding standards. Good to go from my side.


 {{{
 function get_post_data( $post_id ) {
     $post = get_post( $post_id );
     return $post->post_title; // ⚠ Possible null reference
 }



 {{{
 function get_post_data( int $post_id ): string {
     $post = get_post( $post_id );

     if ( ! $post instanceof WP_Post ) {
         return ''; // Safe fallback if post is null or not found
     }

     return (string) $post->post_title;
 }

 }}}

 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63268#comment:73>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform