[wp-trac] [WordPress Trac] #53355: wp-signup.php with `new` in the query string results in a "site does not exist" message even if the site does exist

[WordPress Trac]

#53355: wp-signup.php with `new` in the query string results in a "site does not
exist" message even if the site does exist
-------------------------------------------------+-------------------------
 Reporter:  henry.wright                         |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Networks and Sites                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:  multisite
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing has-unit-tests => has-patch has-unit-
     tests dev-feedback


Comment:

 == Combined Bug Reproduction and Patch Test Report
 === Description
 ✅ This report validates whether the indicated patch works as expected.

 Patch tested: https://github.com/WordPress/wordpress-
 develop/pull/2655.diff

 === Environment
 - WordPress: 6.9-alpha-60093-src
 - PHP: 8.2.28
 - Server: nginx/1.27.5
 - Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 137.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Twenty 2.9
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0

 === Testing Instructions
 - Following instructions from OP
 1. Set up a Multisite
 2. Create a new blog, call it for example, "sport"
 3. Go to Settings > Network Settings and set for example "User accounts
 may be registered"
 4. Go to `wp-signup.php?new=sport`
 5. 🐞 The error appears: `The site you were looking for,
 http://localhost:8889/sport/, does not exist.`

 === Expected Results
 - Nothing should appear as the blog was already created

 === Actual Results
 1. ✅ Issue resolved with patch.
 2. ✅ Unit Tests are adequate, not passing pre-patch and passing post-
 patch as expected

 === Additional Notes
 - I have not reviewed this code. The code was not applying but I found
 that making it apply was affordable, so I have integrated it just for
 testing purposes. From a bird's-eye view, it looks adequate, probably
 ready to hook up into the next release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53355#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform