[wp-trac] [WordPress Trac] #62057: Addressing Autosave Memory Issues

[WordPress Trac]

#62057: Addressing Autosave Memory Issues
-------------------------------------------------+-------------------------
 Reporter:  whyisjake                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-reviewed reporter-     |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by tallulahhh):

 @adamsilverstein This looks very promising at first glance!

 I've just returned from sabbatical so I haven't yet had a chance to test
 https://github.com/WordPress/wordpress-develop/pull/7555 yet, but the
 method looks sound and I'll get into it soon.

 I would still encourage the removal of the preload, for these reasons:
 - loading the editor and a gigantic autosave response (even if it's only
 one autosave) makes it easier to hit PHP mem limit for that init and OOM,
 whereas avoiding the preload splits that mem usage over 2 inits instead
 and gives more php mem overhead for the big editor init
 - easier to debug from the editor when you can see the autosave
 request/response activity in devtools

 Customers with heroically large posts (and editor plugins etc eating php
 mem) can get a lot of relief from showstopping editor OOMs this way,
 regardless of the "too many autosaves in response" situation.

 It is technically 2 issues - 'too many autosaves in response' and
 'autosave preload carries oom risk for huge posts' - but I'm aware that
 removal of the preload here would require a companion PR for Gutenberg to
 make the requests do per-page=1, so while I encourage losing the preload,
 I'll defer to y'all as to how this should be handled.

 I'll give the PR a test (in the conditions in which I first found and
 isolated the issue) soon. Eager to mitigate this excessive autosave
 payload waste ecosystem-wide! 👍

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62057#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform