[wp-trac] [WordPress Trac] #51522: Customizing : Site Icon CSS Change

[WordPress Trac]

#51522: Customizing : Site Icon CSS Change
-----------------------------------+-------------------------
 Reporter:  ravipatel              |       Owner:  (none)
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:
Component:  Customize              |     Version:
 Severity:  normal                 |  Resolution:  worksforme
 Keywords:  has-patch 2nd-opinion  |     Focuses:  css
-----------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-patch needs-refresh 2nd-opinion => has-patch 2nd-opinion
 * status:  new => closed
 * resolution:   => worksforme
 * milestone:  Awaiting Review =>


Comment:

 I tried this again, and the styles have changed.

 - The App icon preview is inside `grid` display, with dark text against a
 light background, so the image does not need `display: inline-block` or a
 text color anymore for its alternative text.
 - The Browser icon preview does not make the `alt` text very readable in
 either light or dark mode. The image theoretically could have a text color
 like `var(--site-icon-address-bar-text)`, but that still would be
 difficult to read when "Browser" overlaps the Site Title.

 I think being able to read the text in the App icon image effectively
 indicates that you need to 'Remove' or 'Change image' when the image does
 not exist at the same URL.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51522#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform