[wp-trac] [WordPress Trac] #36242: wpdb set_sql_mode add param

[WordPress Trac]

#36242: wpdb set_sql_mode add param
--------------------------+--------------------------
 Reporter:  spacedmonkey  |       Owner:  pbearne
     Type:  enhancement   |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Database      |     Version:  3.9
 Severity:  normal        |  Resolution:  wontfix
 Keywords:  has-patch     |     Focuses:  performance
--------------------------+--------------------------
Changes (by flixos90):

 * status:  assigned => closed
 * resolution:   => wontfix
 * milestone:  6.8 =>


Comment:

 Since it is possible to extend `wpdb` in a drop-in, changing the method
 signature of the public `set_sql_mode()` method would be a breaking change
 for any drop-in that already extends this method. Some very popular
 plugins appear to do that, see
 https://wpdirectory.net/search/01JHNCFYTVV0JJA4BA56ZRJMTC.

 Based on this, I think this should be closed. If there is a very good
 justification to introduce this breaking change here, we can reconsider,
 but the argument of more developer convenience is not sufficient to do
 that I think.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36242#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform