[wp-trac] [WordPress Trac] #62633: Is writable check for fonts folder is misleading/wrong

[WordPress Trac]

#62633: Is writable check for fonts folder is misleading/wrong
-------------------------------------------------+-------------------------
 Reporter:  zodiac1978                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Site Health                          |     Version:  6.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots has-       |     Focuses:
  testing-info                                   |
-------------------------------------------------+-------------------------

Comment (by zodiac1978):

 Hey @sainathpoojary, thanks for the PR!

 Just one thing: `$is_fonts_dir_exist` sounds a little bit wrong for me. I
 am not a native speaker, but `$is_writable_fonts_dir` sounds like an
 English sentence and `$is_fonts_dir_exist` does not.

 Maybe just `$fonts_dir_exists` following the common naming convention?

 @SergeyBiryukov There was one check failing, but I don't think this is in
 relation to the patch. Is this a known issue?
 https://github.com/WordPress/wordpress-
 develop/pull/7933/commits/7f297db89e32fe5e12cca88468c1d549d5855722

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62633#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform