[wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter

[WordPress Trac]

#62900: PNG original image not affected by conversion filter
-------------------------------------------------+-------------------------
 Reporter:  pixlpirate                           |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Media                                |     Version:  6.7.1
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-patch needs-unit-   |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 I did review the ticket where this was introduced, trying to avoid
 creating a full sized image that was larger than the uploaded image. I
 suspect the original bug was not really addressed by the fix, and may have
 been the bit depth issue we recently fixed where 8 bit PNG uploads were
 output as 24 bit making them much larger (#36477).

 Please review the ticket, maybe I missed something there.

 > I think we should either remove the PNG limitation so that it works the
 same way for all formats

 I would be in favor of removing it, let me give it a try.

 I avoided doing this previously to minimize the changes/risk, however I
 question whether the original fix was correct anyway.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62900#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform