[wp-trac] [WordPress Trac] #62879: get_custom_logo does not apply the aria-current attribute in all cases

WordPress Trac noreply at wordpress.org
Sun Feb 2 20:55:02 UTC 2025


#62879: get_custom_logo does not apply the aria-current attribute in all cases
---------------------------+----------------------------
 Reporter:  bschneidewind  |       Owner:  audrasjb
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  6.8
Component:  General        |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  accessibility
---------------------------+----------------------------

Comment (by siliconforks):

 Replying to [comment:5 bschneidewind]:
 > Ex: if it's a paginated page... from an accessibility point it
 shouldn't, but the argument may differ in other aspects.

 Yes, the pagination is another edge case, but the behavior of
 `is_front_page()` has always been to ignore pagination, so I'm not
 suggesting changing that here.  I'm just proposing that `is_front_page()`
 handle the case where WordPress is configured without a page set for the
 homepage (assuming it is decided that this is actually a supported
 configuration).

 > Additional theme updates will be needed for bundled themes prior to
 TwentyTwentyTwo because of how things were built on each theme. Even if
 the is_front_page() was updated to account for the edge case, a theme
 update would be needed on those bundled themes that do not have support
 for aria-current on the site title links.

 My point is that if `is_front_page()` is fixed, the theme update will be
 much simpler and require less duplicated code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62879#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list