From noreply at wordpress.org Sat Feb 1 05:32:36 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 05:32:36 -0000 Subject: [wp-trac] [WordPress Trac] #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" In-Reply-To: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> References: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> Message-ID: <070.383ead10853a140fc9cadf9192df197d@wordpress.org> #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" -------------------------------+------------------------------- Reporter: jvrajput420 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: css, performance -------------------------------+------------------------------- Changes (by sabernhardt): * keywords: => reporter-feedback Comment: Could you share the stylesheet `` in the context of some other styles and scripts around it, especially the one immediately following `wp-includes/blocks/navigation/style.min.css`? Also note whether it is in the page's `` or the ``. I was not able to get the `wp-block-navigation` CSS without a Navigation block on that page. And I needed to use the `should_load_separate_core_block_assets` hook (in a plugin) to load block assets separately (because Twenty Twenty-One does not opt in to dividing styles for each block). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 06:21:54 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 06:21:54 -0000 Subject: [wp-trac] [WordPress Trac] #62892: Twenty Twelve: Add aria-expanded to menu button (mobile) Message-ID: <057.0ccb450cd573d2db2631645ccafb1b73@wordpress.org> #62892: Twenty Twelve: Add aria-expanded to menu button (mobile) ---------------------------+----------------------------- Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Themes | Version: Severity: normal | Keywords: Focuses: accessibility | ---------------------------+----------------------------- The aria-expanded and aria-controls attributes are missing on the mobile nav for the Twenty Twelve theme: https://wp-themes.com/twentytwelve/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 06:24:11 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 06:24:11 -0000 Subject: [wp-trac] [WordPress Trac] #62893: The "pin" header feature in the site editor is not working Message-ID: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> #62893: The "pin" header feature in the site editor is not working --------------------------+----------------------------- Reporter: phanduynam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.7.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Here is a picture of that part for easy description. [[Image(https://drive.google.com/file/d/1WDh8UkM15Rit_TrvbkPDcvxVWflWQPrH/view?usp=drive_link)]] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 06:26:06 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 06:26:06 -0000 Subject: [wp-trac] [WordPress Trac] #62893: The "pin" header feature in the site editor is not working In-Reply-To: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> References: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> Message-ID: <069.fe11e7e57e003f2642e1a60d142d8d2a@wordpress.org> #62893: The "pin" header feature in the site editor is not working --------------------------+------------------------------ Reporter: phanduynam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.7.1 Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by phanduynam): * severity: normal => major -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 12:30:12 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 12:30:12 -0000 Subject: [wp-trac] [WordPress Trac] #62891: Javascript error: More detail dropdown after plugin update in update-core.php broken In-Reply-To: <051.3ff07001ebfe7bb7699b15f7e4633a22@wordpress.org> References: <051.3ff07001ebfe7bb7699b15f7e4633a22@wordpress.org> Message-ID: <066.9bf04c640cfa1107aa2757f72371528d@wordpress.org> #62891: Javascript error: More detail dropdown after plugin update in update- core.php broken -------------------------------------------------+------------------------- Reporter: afragen | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.8 Component: Upgrade/Install | Version: trunk Severity: major | Resolution: fixed Keywords: needs-patch has-screenshots | Focuses: ui, reporter-feedback | javascript -------------------------------------------------+------------------------- Changes (by afragen): * status: new => closed * resolution: => fixed Comment: I can confirm this is fixed in 6.8-alpha-59748 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 15:57:09 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 15:57:09 -0000 Subject: [wp-trac] [WordPress Trac] #62892: Twenty Twelve: Add aria-expanded to menu button (mobile) In-Reply-To: <057.0ccb450cd573d2db2631645ccafb1b73@wordpress.org> References: <057.0ccb450cd573d2db2631645ccafb1b73@wordpress.org> Message-ID: <072.08979f770d709087dd05bf1209b52a55@wordpress.org> #62892: Twenty Twelve: Add aria-expanded to menu button (mobile) ---------------------------+------------------------------ Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+------------------------------ Changes (by sabernhardt): * component: Themes => Bundled Theme -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 16:58:24 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 16:58:24 -0000 Subject: [wp-trac] [WordPress Trac] #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" In-Reply-To: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> References: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> Message-ID: <070.b83619c008dc4325961d618acdca2fd3@wordpress.org> #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" -------------------------------+------------------------------- Reporter: jvrajput420 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: css, performance -------------------------------+------------------------------- Comment (by jvrajput420): @sabernhardt Thank you for your response and for looking into this issue! == Extra Stylesheets Being Loaded == === On Astra Theme === - The `wp-block-library-css` stylesheet is loading: {{{ }}} - This file loads even though Astra does not use Gutenberg block styling. === On Twenty Twenty-Five Theme (After Activating Classic Editor) === - The `wp-block-navigation-css` stylesheet is loading: {{{ }}} - This happens despite the Classic Editor plugin being activated, which disables the block editor. == Findings == - I manually removed these styles from multiple projects and noticed **no negative impact** on layout or functionality. - After removing these styles, **site speed improved**, indicating that they were unnecessary in these cases. - The stylesheets are loading in the `` of the page. Let me know if further testing is required. Thanks again for your time! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 17:26:58 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 17:26:58 -0000 Subject: [wp-trac] [WordPress Trac] #59824: PHP Warning raised in pluggable.php when passing NULL instead of a string In-Reply-To: <051.f48a1f8bc18df58b1d38dd4969a7a477@wordpress.org> References: <051.f48a1f8bc18df58b1d38dd4969a7a477@wordpress.org> Message-ID: <066.5cb3428609169a56e2b09c13a9a4db43@wordpress.org> #59824: PHP Warning raised in pluggable.php when passing NULL instead of a string -------------------------------------+------------------------------------- Reporter: budiony | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: 6.3.3 Severity: normal | Resolution: Keywords: has-patch reporter- | Focuses: administration, feedback | privacy -------------------------------------+------------------------------------- Changes (by johnbillion): * keywords: has-patch => has-patch reporter-feedback Comment: @budiony Thanks for the report and sorry nobody got back to you sooner. There is no code path in WordPress core that allows a `null` value to be passed to `check_password()`. Every call to `wp_check_password()` is preceded with either a guard condition for an empty password or with a string manipulation function that casts a null value to a string. Do you have a plugin installed on your site that calls `check_password()` or otherwise deals with authentication or passwords on your site? I suspect that such a plugin (or theme) is the actual root cause of the warning you're seeing on your site. @debarghyabanerjee Please be more careful with your PRs. Attempting to fix a problem without first being able to reproduce it is not helpful and not a good use of your time or that of people who review the PR. An AI- generated PR summary is fine as long as you verify that everything that is says is accurate, which this is not. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 17:29:24 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 17:29:24 -0000 Subject: [wp-trac] [WordPress Trac] #62892: Twenty Twelve: Add aria-expanded to menu button (mobile) In-Reply-To: <057.0ccb450cd573d2db2631645ccafb1b73@wordpress.org> References: <057.0ccb450cd573d2db2631645ccafb1b73@wordpress.org> Message-ID: <072.d0dbaebbd28b2194db8905418dcc0c6c@wordpress.org> #62892: Twenty Twelve: Add aria-expanded to menu button (mobile) ---------------------------+---------------------------- Reporter: bschneidewind | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * milestone: Awaiting Review => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 18:03:15 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 18:03:15 -0000 Subject: [wp-trac] [WordPress Trac] #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" In-Reply-To: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> References: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> Message-ID: <070.53a54bdc11df1ed1b8124e0db30dac1e@wordpress.org> #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" --------------------------+------------------------------- Reporter: jvrajput420 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: close | Focuses: css, performance --------------------------+------------------------------- Changes (by sabernhardt): * keywords: reporter-feedback => close Comment: I would expect that behavior with Astra (which uses Gutenberg by default) and Twenty Twenty-Five (which requires blocks). The Classic Editor plugin does not completely disable the block editor; it //enables// the previous editor for posts. "Classic" PHP-based themes still have blocks for widgets (unless Classic Widgets is also activated), and block themes need block assets for anything outside the post content. The Classic Editor plugin even allows choosing between editors, either for individual posts or by post type. If you want to disable blocks and remove all block-related assets in a classic theme, a plugin such as [https://wordpress.org/plugins/disable- gutenberg/ Disable Gutenberg] would be more thorough. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 18:11:58 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 18:11:58 -0000 Subject: [wp-trac] [WordPress Trac] #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" In-Reply-To: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> References: <055.f467cf2152cf2850a11690d23d728a4d@wordpress.org> Message-ID: <070.dc682cc990dd04de125c147859b3beab@wordpress.org> #62882: "Navigation Block CSS (style.min.css) Loads Even When Gutenberg is Disabled" --------------------------+------------------------------- Reporter: jvrajput420 | Owner: (none) Type: defect (bug) | Status: assigned Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: normal | Resolution: Keywords: close | Focuses: css, performance --------------------------+------------------------------- Comment (by jvrajput420): @sabernhardt Thank you for your response and for the clarification! I understand that Astra and Twenty Twenty-Five rely on Gutenberg by default and that the Classic Editor plugin does not fully disable the block editor. However, in my case, even after switching to Classic Editor and ensuring that no block-related features (such as block widgets) were in use, the `wp-block-navigation-css` file was still loading unnecessarily. Additionally, I manually removed these styles in multiple projects without noticing any layout or functionality issues, and it led to improved page speed. I appreciate the recommendation to use the Disable Gutenberg plugin for a more complete removal of block-related assets. However, most developers may not be aware of this issue, and many might not check for unnecessary CSS files being loaded. Since this affects performance, **it would be better to address this in WordPress Core** rather than relying on external plugins to remove unnecessary styles. Would it be possible to add a condition in Core to prevent these styles from loading when the block editor is not actively used? Looking forward to further insights. Thanks again! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 20:15:25 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 20:15:25 -0000 Subject: [wp-trac] [WordPress Trac] #62221: GitHub Actions updates and improvements for 6.8 In-Reply-To: <051.7247463816243831cea8f34daf191853@wordpress.org> References: <051.7247463816243831cea8f34daf191853@wordpress.org> Message-ID: <066.4bf5181ebcfb1c83611280244bb0b5d3@wordpress.org> #62221: GitHub Actions updates and improvements for 6.8 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by johnbillion): In [changeset:"59749" 59749]: {{{ #!CommitTicketReference repository="" revision="59749" Build/Test Tools: Parallelise the performance tests. This change introduces a job matrix for the "current", "before", and "base" performance tests to replace the current behaviour of running them sequentially in a single job. This speeds up the overall performance testing workflow and also reduces the chance of any given test interfering with another, for example by making a change to data in the database that affects a subsequent test. Props johnbillion, swissspidy, dmsnell, joemcgill. See #62221 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 20:50:30 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 20:50:30 -0000 Subject: [wp-trac] [WordPress Trac] #62279: Coding Standards fixes for WP 6.8 In-Reply-To: <051.b0c0f5c89d6ca345286ca5fb9960d462@wordpress.org> References: <051.b0c0f5c89d6ca345286ca5fb9960d462@wordpress.org> Message-ID: <066.82513601aab8ecd5104baed3a4fd26c4@wordpress.org> #62279: Coding Standards fixes for WP 6.8 ----------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"59750" 59750]: {{{ #!CommitTicketReference repository="" revision="59750" Coding Standards: Use strict comparison in some legacy media functions. Follow-up to [7062], [8653], [12188]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sat Feb 1 21:46:36 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sat, 01 Feb 2025 21:46:36 -0000 Subject: [wp-trac] [WordPress Trac] #59824: PHP Warning raised in pluggable.php when passing NULL instead of a string In-Reply-To: <051.f48a1f8bc18df58b1d38dd4969a7a477@wordpress.org> References: <051.f48a1f8bc18df58b1d38dd4969a7a477@wordpress.org> Message-ID: <066.ac7757091035a7182c125f354e72d619@wordpress.org> #59824: PHP Warning raised in pluggable.php when passing NULL instead of a string -------------------------------------+------------------------------------- Reporter: budiony | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Security | Version: 6.3.3 Severity: normal | Resolution: Keywords: has-patch reporter- | Focuses: administration, feedback | privacy -------------------------------------+------------------------------------- Comment (by debarghyabanerjee): Hi! @johnbillion, sorry, my bad, I didn't check how Core was using this function, I verified the issue by calling the wp_check_password() function by passing null, and I was getting the Error, that's why I raised a PR for it. Additionally, I wrote the PR description myself, and just used AI to fix it grammatically. I will be more careful from the next PR. Thanks for mentioning. Really appreciate your valuable feedback, and sorry for the mistake. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 00:31:21 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 00:31:21 -0000 Subject: [wp-trac] [WordPress Trac] #62894: Media Library functionality in the block editor causes CSP 'unsafe-eval' error Message-ID: <062.1ef47bb08f532244d1d62dd7e3772397@wordpress.org> #62894: Media Library functionality in the block editor causes CSP 'unsafe-eval' error ----------------------------------------+----------------------------- Reporter: michelleblanchette | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.7.1 Severity: normal | Keywords: Focuses: javascript, administration | ----------------------------------------+----------------------------- Trying to change a page post's featured image or attempting to "Open Media Library" action on `wp:image` blocks in the block editor causes the following error: {{{ [react-dom.min.js?ver=18.3.1:10] Uncaught EvalError: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src https: 'self' 'unsafe-inline'". at new Function () at Function.template (underscore.min.js?ver=1.13.7:2:15243) at n.template (wp-util.min.js?ver=6.7.1:2:328) at n.render (wp-backbone.min.js?ver=6.7.1:2:2895) at n.attach (media-views.min.js?ver=6.7.1:2:86078) at n.open (media-views.min.js?ver=6.7.1:2:86461) at i.2836._.each.s. [as open] (media- views.min.js?ver=6.7.1:2:83610) at d.openModal (media-utils.min.js?ver=e10cc6bfcff4fe474479:2:5562) at n. (components.min.js?ver=130172abbae720694b1f:19:24767) at Object.Xa (react-dom.min.js?ver=18.3.1:10:105719) template @ underscore.min.js?ver=1.13.7:2 (anonymous) @ wp-util.min.js?ver=6.7.1:2 render @ wp-backbone.min.js?ver=6.7.1:2 attach @ media-views.min.js?ver=6.7.1:2 open @ media-views.min.js?ver=6.7.1:2 i.2836._.each.s. @ media-views.min.js?ver=6.7.1:2 openModal @ media-utils.min.js?ver=e10cc6bfcff4fe474479:2 n. @ components.min.js?ver=130172abbae720694b1f:19 Xa @ react-dom.min.js?ver=18.3.1:10 B @ react-dom.min.js?ver=18.3.1:10 W @ react-dom.min.js?ver=18.3.1:10 qe @ react-dom.min.js?ver=18.3.1:10 Ke @ react-dom.min.js?ver=18.3.1:10 (anonymous) @ react-dom.min.js?ver=18.3.1:10 dl @ react-dom.min.js?ver=18.3.1:10 V @ react-dom.min.js?ver=18.3.1:10 Je @ react-dom.min.js?ver=18.3.1:10 pe @ react-dom.min.js?ver=18.3.1:10 fe @ react-dom.min.js?ver=18.3.1:10 }}} **Context/Notes:** * UnderscoreJS does not seem willing to resolve this CSP vulnerability per https://github.com/jashkenas/underscore/issues/2995 * Gutenberg does not seem responsible per https://github.com/WordPress/gutenberg/issues/47619#issuecomment-2545695011 * CSP unsafe-inline has been discussed in depth on https://core.trac.wordpress.org/ticket/39941 and https://core.trac.wordpress.org/ticket/51407 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 02:18:09 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 02:18:09 -0000 Subject: [wp-trac] [WordPress Trac] #62895: Twenty Twenty: site logo link missing aria-current and rel=home Message-ID: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> #62895: Twenty Twenty: site logo link missing aria-current and rel=home ---------------------------+----------------------------- Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Keywords: Focuses: accessibility | ---------------------------+----------------------------- In Twenty Twenty, the aria-current and rel="home" attributes are missing on the site logo. Can be seen at: https://wp-themes.com/twentytwenty/ -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 05:36:10 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 05:36:10 -0000 Subject: [wp-trac] [WordPress Trac] #62895: Twenty Twenty: site logo link missing aria-current and rel=home In-Reply-To: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> References: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> Message-ID: <072.592294da85c41ee8adb2c63ead68a079@wordpress.org> #62895: Twenty Twenty: site logo link missing aria-current and rel=home ---------------------------+------------------------------ Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+------------------------------ Comment (by hiabhaykulkarni): **Test Report:** **Patch Tested:** https://github.com/WordPress/wordpress-develop/pull/8237 I have tested the above PR, and the header logo includes the rel="home" and aria-current="page" attributes. **Environment:** **OS:** macOS 15.2 (24C101) **Browser:** Microsoft Edge Version 132.0.2957.127 (Official build) (arm64) **Screenshot:** https://share.cleanshot.com/yyspBNJP95d7p2J5vHwS -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 05:50:19 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 05:50:19 -0000 Subject: [wp-trac] [WordPress Trac] #62893: The "pin" header feature in the site editor is not working In-Reply-To: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> References: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> Message-ID: <069.2dcaac8142184763ae62b63ab8c35275@wordpress.org> #62893: The "pin" header feature in the site editor is not working --------------------------+------------------------------ Reporter: phanduynam | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.7.1 Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by hiabhaykulkarni): **Test Report:** **Issue Reproduced:** I have tested the above issue, and the position of the Group in the header is set to Sticky. However, it is not sticky on the front end. **Environment:** **WordPress Version:** 6.7.1 **Theme Name:** Twenty Twenty-Four (twentytwentyfour) **Theme Version:** 1.3 **OS:** macOS 15.2 (24C101) **Browser:** Microsoft Edge Version 132.0.2957.127 (Official build) (arm64) **Screen Recording:** https://share.cleanshot.com/vyVxVZg6YY4dxg9WkDTw -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 06:16:56 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 06:16:56 -0000 Subject: [wp-trac] [WordPress Trac] #59562: edit_form_after_title Hook Not Functional in Block Editor on New Post Page. In-Reply-To: <058.6f2799f3dae727ff4132a4774e2f888f@wordpress.org> References: <058.6f2799f3dae727ff4132a4774e2f888f@wordpress.org> Message-ID: <073.ea2fd94f816f5e0ffd77563028d99811@wordpress.org> #59562: edit_form_after_title Hook Not Functional in Block Editor on New Post Page. ----------------------------+------------------------------ Reporter: danishwebaashi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.3.2 Severity: normal | Resolution: Keywords: | Focuses: ----------------------------+------------------------------ Changes (by danishwebaashi): * component: Administration => Editor -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 06:18:10 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 06:18:10 -0000 Subject: [wp-trac] [WordPress Trac] #59562: edit_form_after_title Hook Not Functional in Block Editor on New Post Page. In-Reply-To: <058.6f2799f3dae727ff4132a4774e2f888f@wordpress.org> References: <058.6f2799f3dae727ff4132a4774e2f888f@wordpress.org> Message-ID: <073.fb1496524cb28dd4527886113960e7ba@wordpress.org> #59562: edit_form_after_title Hook Not Functional in Block Editor on New Post Page. ----------------------------+------------------------------ Reporter: danishwebaashi | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.3.2 Severity: normal | Resolution: Keywords: needs-testing | Focuses: ----------------------------+------------------------------ Changes (by danishwebaashi): * keywords: => needs-testing -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 08:06:58 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 08:06:58 -0000 Subject: [wp-trac] [WordPress Trac] #62895: Twenty Twenty: site logo link missing aria-current and rel=home In-Reply-To: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> References: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> Message-ID: <072.ada8e7da79a7af3c2f927a772c46b95c@wordpress.org> #62895: Twenty Twenty: site logo link missing aria-current and rel=home -----------------------------------------+------------------------------ Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch changes-requested | Focuses: accessibility -----------------------------------------+------------------------------ Changes (by sabernhardt): * keywords: has-patch => has-patch changes-requested Comment: I think you mean the site //title// (text) link; the site logo gets its link from `get_custom_logo()`. The PR replaces the `title` argument with two new arguments. The `title` argument should remain usable, but you could add `rel="home"` to the default: {{{ 'title' => '%2$s', }}} Then you could add the `aria-current` attribute 1. if it matches the conditions in `get_custom_logo()` (see #62879 for any updates) and 2. if the `title` argument matches the default value. {{{ $contents = sprintf( $args['title'], esc_url( get_home_url( null, '/' ) ), esc_html( $site_title ) ); if ( ( is_front_page() || is_home() && ( (int) get_option( 'page_for_posts' ) !== get_queried_object_id() ) ) && ! is_paged() && $args['title'] === $defaults['title'] ) { $contents = str_replace( ' rel=', ' aria- current="page" rel=', $contents ); } $classname = $args['title_class']; }}} I purposely did not use the `condition` argument because it can be customized, and even its default value does not include `! is_paged()`. The `condition` determines whether the wrapping element is a heading, but `aria-current` would be more exclusive. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 11:16:13 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 11:16:13 -0000 Subject: [wp-trac] [WordPress Trac] #62279: Coding Standards fixes for WP 6.8 In-Reply-To: <051.b0c0f5c89d6ca345286ca5fb9960d462@wordpress.org> References: <051.b0c0f5c89d6ca345286ca5fb9960d462@wordpress.org> Message-ID: <066.2ed9c76c21630b2713243a8b55c3b946@wordpress.org> #62279: Coding Standards fixes for WP 6.8 ----------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"59751" 59751]: {{{ #!CommitTicketReference repository="" revision="59751" Coding Standards: Use strict comparison in `get_media_item()`. Follow-up to [12081], [12351]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 14:58:59 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 14:58:59 -0000 Subject: [wp-trac] [WordPress Trac] #62895: Twenty Twenty: site title link missing aria-current and rel=home attributes (was: Twenty Twenty: site logo link missing aria-current and rel=home) In-Reply-To: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> References: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> Message-ID: <072.46cc41d7be04e947815b78bd55cfc7fd@wordpress.org> #62895: Twenty Twenty: site title link missing aria-current and rel=home attributes ---------------------------+------------------------------ Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+------------------------------ Changes (by bschneidewind): * keywords: has-patch changes-requested => has-patch Comment: Thank you @sabernhardt ~ just took care of those updates! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 16:36:13 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 16:36:13 -0000 Subject: [wp-trac] [WordPress Trac] #62879: get_custom_logo does not apply the aria-current attribute in all cases In-Reply-To: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> References: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> Message-ID: <072.74666b639240f003f36d834e5996ab31@wordpress.org> #62879: get_custom_logo does not apply the aria-current attribute in all cases ---------------------------+---------------------------- Reporter: bschneidewind | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Comment (by siliconforks): Replying to [ticket:62879 bschneidewind]: > When reading settings have a posts page set but not a page set for the homepage Some questions: 1. Is that actually considered a valid, supported configuration (to have a posts page set but not a page set for the homepage)? That doesn't really seem like it would be useful combination of settings to me. I see that the WordPress admin section does in fact allow you to configure things that way, which is a bit odd and might be a bug? 2. Assuming that this ''is'' a configuration that should be supported by WordPress, doesn't that imply that `is_front_page()` and `WP_Query::is_front_page()` are broken in that configuration? It appears that they will never return `true` in that configuration, which doesn't really make sense (obviously the site still has a front page). 3. The current proposed changes to support this configuration involve adding some rather complex conditional logic. It is currently proposed that this logic be copied into multiple different places in the code? * https://github.com/WordPress/wordpress-develop/pull/8206 - this fixes `get_custom_logo()` * https://github.com/WordPress/wordpress-develop/pull/8237 - this fixes the `twentytwenty` theme (#62895) 4. Copying this complex code into multiple places doesn't seem very [https://en.wikipedia.org/wiki/Don%27t_repeat_yourself DRY]. Is this going to need to get copied into other places too? What about all the other themes besides `twentytwenty`? Fixing `is_front_page()` could perhaps eliminate the need for this. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 18:41:12 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 18:41:12 -0000 Subject: [wp-trac] [WordPress Trac] #62879: get_custom_logo does not apply the aria-current attribute in all cases In-Reply-To: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> References: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> Message-ID: <072.7ea0de68c9a62eefc06ebbb073242512@wordpress.org> #62879: get_custom_logo does not apply the aria-current attribute in all cases ---------------------------+---------------------------- Reporter: bschneidewind | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Comment (by bschneidewind): @siliconforks - my thoughts on things: 1 - The UX already supports this in the admin area, I don't think it's the most logical approach overall but how could you force users to add a 'homepage' that may have already set it up this way? The render_block_core_home_link function already has support for this edge case as well. 2 - Agreed, it would be better if is_front_page always rang true when it's the root page but there are edge cases that need to be accounted for and there is some debate on whether is_front_page should remain true. Ex: if it's a paginated page... from an accessibility point it shouldn't, but the argument may differ in other aspects. 3 - This PR fixes get_custom_logo(). The TwentyTwenty update is to address the specific template function where the text version is missing the aria- current attribute. Yes, I am proposing this in multiple places to fix older themes and in core to address block based themes. 4 - I am proposing a similar approach be added in some of the older themes here where site logo support does not currently exist: #61766 Additional theme updates will be needed for bundled themes prior to TwentyTwentyTwo because of how things were built on each theme. Even if the is_front_page() was updated to account for the edge case, a theme update would be needed on those bundled themes that do not have support for aria-current on the site title links. With TwentyTwentyTwo and up using block based approach, the aria-current attribute is applied correctly there on the text links for the site-title. It does create some repeated code between TwentyTwentyOne and earlier bundled themes and the update to get_custom_logo, however I think it makes sense in these cases as the theme updates are only needed because of a different approach to building in TwentyTwentyOne and prior. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 20:20:57 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 20:20:57 -0000 Subject: [wp-trac] [WordPress Trac] #62895: Bundled Themes: Accessibility additions to the site title link (was: Twenty Twenty: site title link missing aria-current and rel=home attributes) In-Reply-To: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> References: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> Message-ID: <072.dc632a30ef5f013d0623f5c518ac99e9@wordpress.org> #62895: Bundled Themes: Accessibility additions to the site title link ---------------------------+------------------------------ Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+------------------------------ Comment (by bschneidewind): Updated the scope to include all bundled themes: TwentyTen TwentyEleven TwentyTwelve TwentyThirteen TwentyFourteen TwentyFifteen TwentySixteen TwentySeventeen TwentyNineteen TwentyTwenty TwentyTwentyOne -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 20:23:19 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 20:23:19 -0000 Subject: [wp-trac] [WordPress Trac] #62879: get_custom_logo does not apply the aria-current attribute in all cases In-Reply-To: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> References: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> Message-ID: <072.ea3edbf7f3286fb649352ac79bec5754@wordpress.org> #62879: get_custom_logo does not apply the aria-current attribute in all cases ---------------------------+---------------------------- Reporter: bschneidewind | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Comment (by bschneidewind): Related, https://github.com/WordPress/wordpress-develop/pull/8237 - has been updated to account for all bundled themes (#62895) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 20:55:02 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 20:55:02 -0000 Subject: [wp-trac] [WordPress Trac] #62879: get_custom_logo does not apply the aria-current attribute in all cases In-Reply-To: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> References: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> Message-ID: <072.8aa12c3ece86e5a17b4227b774a20226@wordpress.org> #62879: get_custom_logo does not apply the aria-current attribute in all cases ---------------------------+---------------------------- Reporter: bschneidewind | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Comment (by siliconforks): Replying to [comment:5 bschneidewind]: > Ex: if it's a paginated page... from an accessibility point it shouldn't, but the argument may differ in other aspects. Yes, the pagination is another edge case, but the behavior of `is_front_page()` has always been to ignore pagination, so I'm not suggesting changing that here. I'm just proposing that `is_front_page()` handle the case where WordPress is configured without a page set for the homepage (assuming it is decided that this is actually a supported configuration). > Additional theme updates will be needed for bundled themes prior to TwentyTwentyTwo because of how things were built on each theme. Even if the is_front_page() was updated to account for the edge case, a theme update would be needed on those bundled themes that do not have support for aria-current on the site title links. My point is that if `is_front_page()` is fixed, the theme update will be much simpler and require less duplicated code. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 21:24:00 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 21:24:00 -0000 Subject: [wp-trac] [WordPress Trac] #62894: Media Library functionality in the block editor causes CSP 'unsafe-eval' error In-Reply-To: <062.1ef47bb08f532244d1d62dd7e3772397@wordpress.org> References: <062.1ef47bb08f532244d1d62dd7e3772397@wordpress.org> Message-ID: <077.29e7b01d3cd90401368554a2b7814864@wordpress.org> #62894: Media Library functionality in the block editor causes CSP 'unsafe-eval' error --------------------------------+----------------------------------------- Reporter: michelleblanchette | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.7.1 Severity: normal | Resolution: Keywords: | Focuses: javascript, administration --------------------------------+----------------------------------------- Comment (by jornfranke): Thanks a lot! I support that this ticket should be solved. We should not have in a content management system a CSP that needs to allow unsafe-*. A CMS is used by many people that may accidentality or maliciously do XSS or put hidden trackers. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Sun Feb 2 22:11:42 2025 From: noreply at wordpress.org (WordPress Trac) Date: Sun, 02 Feb 2025 22:11:42 -0000 Subject: [wp-trac] [WordPress Trac] #62879: get_custom_logo does not apply the aria-current attribute in all cases In-Reply-To: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> References: <057.593657b53efa6f0dde94d0f687abdb1d@wordpress.org> Message-ID: <072.4be9aae81c66afc83a5e4d8125094ec2@wordpress.org> #62879: get_custom_logo does not apply the aria-current attribute in all cases ---------------------------+---------------------------- Reporter: bschneidewind | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Comment (by bschneidewind): @siliconforks - Good points - it's been discussed before it looks like #59252 I did throw a patch up to see if it gets anywhere and will adjust any other PR's if it makes progress. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 04:47:32 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 04:47:32 -0000 Subject: [wp-trac] [WordPress Trac] #62896: Twenty Nineteen: Limit scope of aria-haspopup and aria-expanded to the primary menu Message-ID: <057.1aa21529924d17f9178cd10856c0fb2a@wordpress.org> #62896: Twenty Nineteen: Limit scope of aria-haspopup and aria-expanded to the primary menu ---------------------------+----------------------------- Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: minor | Keywords: Focuses: accessibility | ---------------------------+----------------------------- The aria-haspopup and aria-expanded attributes are currently applied to the footer and social menus in the TwentyNineteen theme when children items are present in the menu. The depth is set to 1 and the child items aren't actually there on the front end, but the attributes still end up displaying. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 04:53:51 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 04:53:51 -0000 Subject: [wp-trac] [WordPress Trac] #62893: The "pin" header feature in the site editor is not working In-Reply-To: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> References: <054.1e8b18a469ce59753da8f3292ac398de@wordpress.org> Message-ID: <069.a1606b274695978e4e5d24ad2476ec84@wordpress.org> #62893: The "pin" header feature in the site editor is not working --------------------------+---------------------- Reporter: phanduynam | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Editor | Version: 6.7.1 Severity: normal | Resolution: invalid Keywords: | Focuses: --------------------------+---------------------- Changes (by poena): * status: new => closed * resolution: => invalid * severity: major => normal * milestone: Awaiting Review => Comment: Hi @phanduynam @hiabhaykulkarni The sticky feature uses CSS to position the block. The {{{position:sticky}}} only makes an HTML element sticky inside its closest ancestor. See https://developer.mozilla.org/en-US/docs/Web/CSS/position In this case, because you are setting the sticky on the group that is **inside the header**, it is only sticky **inside the header.** Please see https://learn.wordpress.org/lesson/adding-a-sticky-header-or- banner/ Because this is not a bug, but how the CSS is intended to work, I am closing this ticket. ---- Kindly remember that there are contributors who may not be able to see or hear video content, a text description is always needed on the tickets. By linking to external files, there is also a risk that that file is lost over time. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 06:27:10 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 06:27:10 -0000 Subject: [wp-trac] [WordPress Trac] #61411: Reading Settings Section not load properly In-Reply-To: <056.5f8aecac9f205135992e65c5930605d6@wordpress.org> References: <056.5f8aecac9f205135992e65c5930605d6@wordpress.org> Message-ID: <071.5e2f718052b07f3684e018c3cae0b2bd@wordpress.org> #61411: Reading Settings Section not load properly -------------------------------------+------------------------------ Reporter: yasirkhalifa | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Awaiting Review Component: Administration | Version: Severity: normal | Resolution: worksforme Keywords: reporter-feedback close | Focuses: -------------------------------------+------------------------------ Changes (by yasirkhalifa): * status: reopened => closed * resolution: => worksforme Comment: I think it is resolved in latest version. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 07:39:39 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 07:39:39 -0000 Subject: [wp-trac] [WordPress Trac] #61620: Edited Images don't include un-edited versions in WXR file, even if used in a Post In-Reply-To: <055.57fc6fb9b1d5dd92db851c47eb97cc53@wordpress.org> References: <055.57fc6fb9b1d5dd92db851c47eb97cc53@wordpress.org> Message-ID: <070.2d66d764501889b748350776513262c6@wordpress.org> #61620: Edited Images don't include un-edited versions in WXR file, even if used in a Post --------------------------+------------------------------ Reporter: MadtownLems | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by zeeshankhan000): I think this issue is fixed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 07:40:17 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 07:40:17 -0000 Subject: [wp-trac] [WordPress Trac] #61600: Import of scheduled posts In-Reply-To: <049.2a7b4a9ceaa8ffebc177dc5dd77f3932@wordpress.org> References: <049.2a7b4a9ceaa8ffebc177dc5dd77f3932@wordpress.org> Message-ID: <064.d49f20ada65df3f569e15d34968a9a62@wordpress.org> #61600: Import of scheduled posts --------------------------+------------------------------ Reporter: lejon | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: Severity: minor | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by zeeshankhan000): any link? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 07:46:00 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 07:46:00 -0000 Subject: [wp-trac] [WordPress Trac] #61620: Edited Images don't include un-edited versions in WXR file, even if used in a Post In-Reply-To: <055.57fc6fb9b1d5dd92db851c47eb97cc53@wordpress.org> References: <055.57fc6fb9b1d5dd92db851c47eb97cc53@wordpress.org> Message-ID: <070.9f1f7b9e36e75d3c45f539b951d0a465@wordpress.org> #61620: Edited Images don't include un-edited versions in WXR file, even if used in a Post --------------------------+------------------------------ Reporter: MadtownLems | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Export | Version: Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by zeeshankhan000): It is added to my to-do list to just have some additional tests and I’ll share here as soon as I publish it. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:08:20 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:08:20 -0000 Subject: [wp-trac] [WordPress Trac] #62897: Title attribute of menu item is not correctly displayed in the frontend Message-ID: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> #62897: Title attribute of menu item is not correctly displayed in the frontend ---------------------------+----------------------------- Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: 6.7.1 Severity: normal | Keywords: Focuses: accessibility | ---------------------------+----------------------------- Hello, I’ve noticed that when a title attribute is assigned to a menu item, it is no longer correctly displayed in the frontend. Instead of showing the assigned title, either nothing is displayed, or the title appears empty with just the attribute present. This issue occurs in the current version of WordPress and affects all menu items with a title attribute. **Steps to reproduce:** 1. Go to "Appearance" > "Menus" and add a title attribute to a menu item. 2. Save the menu and load the page in the frontend. 3. Inspect the HTML code of the menu, where the title attribute should be present. **Expected behavior:** The title attribute should be correctly output in the HTML code of the menu item and displayed in the frontend. **Actual behavior:** The title attribute is either not displayed, or it is not rendered correctly in the HTML code. I would appreciate it if this issue could be resolved in a future version. Thank you! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:16:08 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:16:08 -0000 Subject: [wp-trac] [WordPress Trac] #55401: Subpages of a web page can be called twice In-Reply-To: <055.3f14c28994df00d9eeb59ba7b17bab48@wordpress.org> References: <055.3f14c28994df00d9eeb59ba7b17bab48@wordpress.org> Message-ID: <070.cd989d01ae9e31f234049fec3832de70@wordpress.org> #55401: Subpages of a web page can be called twice --------------------------+------------------------------ Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Permalinks | Version: 5.9.3 Severity: major | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by manuel10503): * keywords: needs-patch dev-feedback needs-refresh needs-dev-note => -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:38:07 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:38:07 -0000 Subject: [wp-trac] [WordPress Trac] #62811: Update bundled root certificates for 6.8 In-Reply-To: <051.6a2cb7a96eb29eeda8e0afbcc643c4a9@wordpress.org> References: <051.6a2cb7a96eb29eeda8e0afbcc643c4a9@wordpress.org> Message-ID: <066.1b0428bc7b632663a2560f91767a677a@wordpress.org> #62811: Update bundled root certificates for 6.8 --------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.8 Component: Security | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by johnbillion): * status: new => closed * resolution: => fixed -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:39:53 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:39:53 -0000 Subject: [wp-trac] [WordPress Trac] #62815: Explicitly require the `hash` extension In-Reply-To: <055.e766547a3f2be81ab3d6b877cbe64cdf@wordpress.org> References: <055.e766547a3f2be81ab3d6b877cbe64cdf@wordpress.org> Message-ID: <070.a879baaf0a66c1d1d50947f485cbc05e@wordpress.org> #62815: Explicitly require the `hash` extension --------------------------------------+-------------------------- Reporter: johnbillion | Owner: johnbillion Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.8 Component: Security | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+-------------------------- Comment (by SergeyBiryukov): Related: #55603, #56017. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:55:19 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:55:19 -0000 Subject: [wp-trac] [WordPress Trac] #49708: Add a new function get_page_by_guid In-Reply-To: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> References: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> Message-ID: <067.eb157bbc6aa5bb317c0fca39e5ca3b0d@wordpress.org> #49708: Add a new function get_page_by_guid -------------------------------+------------------------------ Reporter: killua99 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Comment (by zeeshankhan000): The new function get_post_by_guid introduces a way to retrieve a post using its GUID, making it easier to query posts without relying on ID or other metadata. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:55:28 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:55:28 -0000 Subject: [wp-trac] [WordPress Trac] #49708: Add a new function get_page_by_guid In-Reply-To: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> References: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> Message-ID: <067.324823491fc5414b718133f908fad585@wordpress.org> #49708: Add a new function get_page_by_guid -------------------------------+------------------------------ Reporter: killua99 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Comment (by zeeshankhan000): Replying to [comment:2 zeeshankhan000]: > The new function get_post_by_guid introduces a way to retrieve a post using its GUID, making it easier to query posts without relying on ID or other metadata. This function enhances flexibility in fetching posts, particularly useful in cases where GUIDs are unique identifiers across different systems or databases. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:55:37 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:55:37 -0000 Subject: [wp-trac] [WordPress Trac] #49708: Add a new function get_page_by_guid In-Reply-To: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> References: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> Message-ID: <067.105ab1bdd60cb5c9c4175f9334dfa21c@wordpress.org> #49708: Add a new function get_page_by_guid -------------------------------+------------------------------ Reporter: killua99 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Comment (by zeeshankhan000): Linked to Trac ticket #49708, this update aims to improve core functionality while maintaining backward compatibility with existing WordPress queries. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 10:55:41 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 10:55:41 -0000 Subject: [wp-trac] [WordPress Trac] #49708: Add a new function get_page_by_guid In-Reply-To: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> References: <052.18ddaea75522b2f818445a769557cc37@wordpress.org> Message-ID: <067.986df37dc142901bbfa817fa329aaeb9@wordpress.org> #49708: Add a new function get_page_by_guid -------------------------------+------------------------------ Reporter: killua99 | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------------+------------------------------ Comment (by zeeshankhan000): Developers can leverage this function to streamline queries, improve efficiency, and maintain clean code when working with external data sources or migrating content between WordPress installations. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:10:13 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:10:13 -0000 Subject: [wp-trac] [WordPress Trac] #56017: Check the required PHP extensions during WordPress installation and updates In-Reply-To: <058.100762214de5ddaf18efeeb971677c22@wordpress.org> References: <058.100762214de5ddaf18efeeb971677c22@wordpress.org> Message-ID: <073.b3da854ee42dd6ad7f351a9e9f0e320d@wordpress.org> #56017: Check the required PHP extensions during WordPress installation and updates -----------------------------+-------------------------- Reporter: SergeyBiryukov | Owner: johnbillion Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.8 Component: Upgrade/Install | Version: Severity: normal | Resolution: Keywords: dev-feedback | Focuses: -----------------------------+-------------------------- Changes (by johnbillion): * owner: (none) => johnbillion * status: new => assigned * milestone: Future Release => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:15:38 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:15:38 -0000 Subject: [wp-trac] [WordPress Trac] #23013: Gallery images don't display when original post associated with image is trashed In-Reply-To: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> References: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> Message-ID: <067.80a1c80ec60ae4029151f0462301bd5f@wordpress.org> #23013: Gallery images don't display when original post associated with image is trashed --------------------------+------------------------ Reporter: nmoinvaz | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Gallery | Version: 3.5 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by zeeshankhan000): That’s a good workaround, but have you checked if it affects other parts of the site? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:15:44 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:15:44 -0000 Subject: [wp-trac] [WordPress Trac] #23013: Gallery images don't display when original post associated with image is trashed In-Reply-To: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> References: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> Message-ID: <067.93f8ab6d3d77e61317f364e9ba7cf1ce@wordpress.org> #23013: Gallery images don't display when original post associated with image is trashed --------------------------+------------------------ Reporter: nmoinvaz | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Gallery | Version: 3.5 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by zeeshankhan000): Adding !$this->is_attachment ensures attachments don’t trigger the condition. Nice fix! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:15:50 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:15:50 -0000 Subject: [wp-trac] [WordPress Trac] #23013: Gallery images don't display when original post associated with image is trashed In-Reply-To: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> References: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> Message-ID: <067.5ae45fb5bd1c80affc8d1f5c11e4a925@wordpress.org> #23013: Gallery images don't display when original post associated with image is trashed --------------------------+------------------------ Reporter: nmoinvaz | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Gallery | Version: 3.5 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by zeeshankhan000): This change should work, but consider testing it on different post types. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:15:55 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:15:55 -0000 Subject: [wp-trac] [WordPress Trac] #23013: Gallery images don't display when original post associated with image is trashed In-Reply-To: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> References: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> Message-ID: <067.3ddee2b741039f4cc4288f4cf3c9d5a9@wordpress.org> #23013: Gallery images don't display when original post associated with image is trashed --------------------------+------------------------ Reporter: nmoinvaz | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Gallery | Version: 3.5 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by zeeshankhan000): If attachments should be treated separately, this is a valid approach. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:16:05 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:16:05 -0000 Subject: [wp-trac] [WordPress Trac] #23013: Gallery images don't display when original post associated with image is trashed In-Reply-To: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> References: <052.250e1d2c576bfc94f25d5c691fd44474@wordpress.org> Message-ID: <067.35e989003aaecc5cc5c5aabafc7edea8@wordpress.org> #23013: Gallery images don't display when original post associated with image is trashed --------------------------+------------------------ Reporter: nmoinvaz | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Gallery | Version: 3.5 Severity: normal | Resolution: duplicate Keywords: | Focuses: --------------------------+------------------------ Comment (by zeeshankhan000): Replying to [comment:7 zeeshankhan000]: > If attachments should be treated separately, this is a valid approach. Looks like a logical tweak, but watch for unintended side effects in queries. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 11:22:28 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 11:22:28 -0000 Subject: [wp-trac] [WordPress Trac] #62815: Explicitly require the `hash` extension In-Reply-To: <055.e766547a3f2be81ab3d6b877cbe64cdf@wordpress.org> References: <055.e766547a3f2be81ab3d6b877cbe64cdf@wordpress.org> Message-ID: <070.0d1b1f3868f7ac08baa369cb2c7a755e@wordpress.org> #62815: Explicitly require the `hash` extension --------------------------------------+-------------------------- Reporter: johnbillion | Owner: johnbillion Type: task (blessed) | Status: assigned Priority: normal | Milestone: 6.8 Component: Security | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+-------------------------- Comment (by johnbillion): Meta ticket: https://meta.trac.wordpress.org/ticket/7900 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 12:12:36 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 12:12:36 -0000 Subject: [wp-trac] [WordPress Trac] #62326: Add title and description to post format archive block templates In-Reply-To: <049.2e7a837abaf72a9747abc11417e321e1@wordpress.org> References: <049.2e7a837abaf72a9747abc11417e321e1@wordpress.org> Message-ID: <064.e6c3166535908c122b6bd6d6a21262ed@wordpress.org> #62326: Add title and description to post format archive block templates -------------------------------------------------+------------------------- Reporter: poena | Owner: poena Type: enhancement | Status: assigned Priority: normal | Milestone: 6.8 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch has-screenshots has- | Focuses: template testing-info commit | -------------------------------------------------+------------------------- Changes (by poena): * keywords: has-patch needs-testing has-screenshots has-testing-info => has-patch has-screenshots has-testing-info commit -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 12:53:12 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 12:53:12 -0000 Subject: [wp-trac] [WordPress Trac] #62897: Title attribute of menu item is not correctly displayed in the frontend In-Reply-To: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> References: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> Message-ID: <070.0fe821ada506753f05417f3d82e1b0f2@wordpress.org> #62897: Title attribute of menu item is not correctly displayed in the frontend -------------------------------+------------------------------ Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: accessibility -------------------------------+------------------------------ Changes (by audrasjb): * keywords: => reporter-feedback * version: 6.7.1 => Comment: Hello @manuel10503 and thanks for the ticket. Which theme can be used to reproduce the issue? Removing `accessibility` focus as `title` attributed are considered as a bad practice for accessibility (see #24766). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:08:09 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:08:09 -0000 Subject: [wp-trac] [WordPress Trac] #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', Message-ID: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', -----------------------------+----------------------------- Reporter: wuxu | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.7.1 Severity: normal | Keywords: Focuses: | -----------------------------+----------------------------- I'm using version 6.7.1 right now, and since I'm not a real developer, I'm not sure if the following is a bug. In line 1494 of wp-include/functions.php: function wp_get_nocache_headers(), a header instruction is explicitly issued in the function: 'expires' => 'wed, 11 jan 1984 05:00:00 GMT', which causes the response header -expires=1984 for all pages on my frontend, but now it's 2025 years. However, my page expired in 1984. I see that the function cache_javascript_headers() function on line 1552 does the right thing, it takes the time variable + a fixed value to ensure that the expiration time is always a date in the future. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:15:40 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:15:40 -0000 Subject: [wp-trac] [WordPress Trac] #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', In-Reply-To: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> References: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> Message-ID: <063.f05f0c0876eab18964d1fe171909d1b7@wordpress.org> #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', -----------------------------+------------------------------ Reporter: wuxu | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.7.1 Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by wuxu): I also found a different place: Header date prompted by login user: date:Mon, 03 Feb 2025 13:14:28 GMT expires:Wed, 11 Jan 1984 05:00:00 GMT Header date prompted by non-logged-in users: date:Mon, 03 Feb 2025 13:12:33 GMT expires:Thu, 19 Nov 1981 08:52:00 GMT -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:19:23 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:19:23 -0000 Subject: [wp-trac] [WordPress Trac] #62897: Title attribute of menu item is not correctly displayed in the frontend In-Reply-To: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> References: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> Message-ID: <070.a3d71dd93b4d56d0ca9701da3e55995b@wordpress.org> #62897: Title attribute of menu item is not correctly displayed in the frontend -------------------------------+------------------------------ Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: accessibility -------------------------------+------------------------------ Comment (by manuel10503): To reproduce the issue, you can use an older theme where the menu is still controlled in the classic way (not through Gutenberg). A good example of this would be the "Twenty Twenty" theme. Additionally, I found that the HTML title is correctly rendered in the source code when the title differs from the navigation label. However, if the title is identical to the navigation label, the title attribute is not rendered. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:29:03 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:29:03 -0000 Subject: [wp-trac] [WordPress Trac] #62897: Title attribute of menu item is not correctly displayed in the frontend In-Reply-To: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> References: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> Message-ID: <070.46f17f5a6ea15bdff8cada40bf1e1758@wordpress.org> #62897: Title attribute of menu item is not correctly displayed in the frontend -------------------------------+------------------------------ Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: accessibility -------------------------------+------------------------------ Changes (by manuel10503): * Attachment "Screenshot 2025-02-03 142528.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:29:41 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:29:41 -0000 Subject: [wp-trac] [WordPress Trac] #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', In-Reply-To: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> References: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> Message-ID: <063.180ba1ccefa2277b1aa3b5f0bb4c83f7@wordpress.org> #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', -----------------------------+---------------------- Reporter: wuxu | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: 6.7.1 Severity: normal | Resolution: invalid Keywords: | Focuses: -----------------------------+---------------------- Changes (by johnbillion): * status: new => closed * resolution: => invalid * milestone: Awaiting Review => Comment: Thanks for the report @wuxu . These headers are used to prevent your browser from caching the response, presumably in this case because you are logged in to WordPress and therefore caching isn't desirable. If you log out, or if you view your site in an incognito browser window or from another device, those headers won't be present and caching will work as expected. Hope this helps! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:32:14 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:32:14 -0000 Subject: [wp-trac] [WordPress Trac] #62897: Title attribute of menu item is not correctly displayed in the frontend In-Reply-To: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> References: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> Message-ID: <070.539951b767f80e67d8366a2c896369c6@wordpress.org> #62897: Title attribute of menu item is not correctly displayed in the frontend -------------------------------+------------------------------ Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Menus | Version: Severity: normal | Resolution: Keywords: reporter-feedback | Focuses: accessibility -------------------------------+------------------------------ Changes (by manuel10503): * Attachment "Screenshot 2025-02-03 143123.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:35:41 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:35:41 -0000 Subject: [wp-trac] [WordPress Trac] #62221: GitHub Actions updates and improvements for 6.8 In-Reply-To: <051.7247463816243831cea8f34daf191853@wordpress.org> References: <051.7247463816243831cea8f34daf191853@wordpress.org> Message-ID: <066.f0b89d2c86ba9fc461e13c7807ecdfb8@wordpress.org> #62221: GitHub Actions updates and improvements for 6.8 --------------------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by johnbillion): In [changeset:"59752" 59752]: {{{ #!CommitTicketReference repository="" revision="59752" Build/Test Tools: Fix the source code path handling when installing the local development environment. This ensures the correct code is used to run the installation depending on whether it should be running from the `src` or `build` directory. Props swissspidy, johnbillion See #62221 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 13:48:45 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 13:48:45 -0000 Subject: [wp-trac] [WordPress Trac] #62899: Correct the mounted volume directory for the devcontainer Message-ID: <055.322eac5b23e329d84bc728545d446289@wordpress.org> #62899: Correct the mounted volume directory for the devcontainer ------------------------------+------------------------- Reporter: johnbillion | Owner: johnbillion Type: defect (bug) | Status: assigned Priority: normal | Milestone: 6.8 Component: Build/Test Tools | Version: Severity: normal | Keywords: needs-patch Focuses: | ------------------------------+------------------------- When using the devcontainer, the directory ''above'' the working directory is mounted as a volume. On my machine that means dozens of huge directories containing all sorts of client projects and personal projects are all unnecessarily mounted in this container. Patch coming up. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 14:10:42 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 14:10:42 -0000 Subject: [wp-trac] [WordPress Trac] #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', In-Reply-To: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> References: <048.496c7f167481b6672b4ca4e00d40c41d@wordpress.org> Message-ID: <063.2ca5bed9db5783367a645b85b51e05de@wordpress.org> #62898: header - 'Expires' => 'Wed, 11 Jan 1984 05:00:00 GMT', -----------------------------+---------------------- Reporter: wuxu | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: Component: General | Version: 6.7.1 Severity: normal | Resolution: invalid Keywords: | Focuses: -----------------------------+---------------------- Comment (by siliconforks): Replying to [comment:2 johnbillion]: > If you log out, or if you view your site in an incognito browser window or from another device, those headers won't be present and caching will work as expected. Well, @wuxu did mention in [comment:1 the first comment] that caching is not working even for non-logged-in users. However, the date is different: "Thu, 19 Nov 1981 08:52:00 GMT". That date is not used by WordPress, but it is used by PHP when calling `session_start()`. Since core WordPress does not call `session_start()`, I would guess that there is a plugin (or theme) installed which is calling `session_start()`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 14:31:36 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 14:31:36 -0000 Subject: [wp-trac] [WordPress Trac] #62622: Bump minimum PHP version to 7.3 or 7.4 In-Reply-To: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> References: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> Message-ID: <069.644d88348c01dfd7f93266c0243ea62a@wordpress.org> #62622: Bump minimum PHP version to 7.3 or 7.4 -------------------------+------------------------------ Reporter: justlevine | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by samiamnot): Updated for early Feb 2025 based on [https://wordpress.org/about/stats/ WordPress stats]. For the first time in a while, the combined percentage of site on unsupported PHP versions has dropped below 5%. As we stand now, 4.96% of sites are on unsupported PHP versions, something that dropped 0.10% in the past month, vs 0.14% in the previous month. 7.2 + 7.3 that are slated to be dropped next, are still decreasing, but at a much slower pace. This month it was down 0.15%, vs 0.20 last month and 0.21% the previous month, and stands at 5.67%. Based on this slowdown, @johnbillion's [https://core.trac.wordpress.org/ticket/62622#comment:2 projection] that we could make the move in in v6.9 will likely be too early. I assume that by v7.0 we will have numbers low enough to consider making the move. ||='''Month/Year'''=||='''PHP 7.2'''=||='''PHP 7.3'''=||='''PHP 7.2 + 7.3'''=|| ||Jul 2023|| 6.48|| 8.16|| '''14.64%'''|| ||Aug 2023|| 5.64|| 7.62|| '''13.26%'''|| ||Sep 2023|| 5.55|| 7.18|| '''12.73%'''|| ||Oct 2023|| 5.31|| 6.87|| '''12.18%'''|| ||Nov 2023|| 5.20|| 6.51|| '''11.71%'''|| ||Dec 2023|| 5.08|| 6.17|| '''11.25%'''|| ||Jan 2024|| 4.79|| 5.90|| '''10.69%'''|| ||Feb 2024|| 4.67|| 5.54|| '''10.21%'''|| ||Mar 2024|| 4.30|| 5.11|| '''9.41%'''|| ||Apr 2024|| 3.80|| 4.79|| '''8.59%'''|| ||May 2024|| 3.63|| 4.52|| '''8.15%'''|| ||Jun 2024|| 3.46|| 4.30|| '''7.76%'''|| ||Jul 2024|| 3.33|| 4.10|| '''7.43%'''|| ||Aug 2024|| 3.18|| 3.90|| '''7.08%'''|| ||Sep 2024|| 3.05|| 3.73|| '''6.78%'''|| ||Oct 2024|| 2.93|| 3.56|| '''6.49%'''|| ||Nov 2024|| 2.83|| 3.40|| '''6.23%'''|| ||Dec 2024|| 2.76|| 3.26|| '''6.02%'''|| ||Jan 2025|| 2.68|| 3.14|| '''5.82%'''|| ||Feb 2025|| 2.63|| 3.04|| '''5.67%'''|| For historical reasons, here are the stats for no longer supported versions (as of WP 6.6) going back to PHP 5.2. This is not changing much (going down about 0.20% a month) and many are likely "abandoned" sites that are on old versions of WP. ||='''Month/Year'''=||='''PHP 5.2'''=||='''PHP 5.3'''=||='''PHP 5.4'''=||='''PHP 5.5'''=||='''PHP 5.6'''=||='''PHP 7.0'''=||='''PHP 7.1'''=||='''Total'''=|| ||Jan 2024|| 0.21|| 0.50|| 0.44|| 0.35|| 3.21|| 1.67|| 1.08|| '''7.46%'''|| ||Feb 2024|| 0.21|| 0.49|| 0.42|| 0.35|| 3.12|| 1.62|| 1.04|| '''7.25%'''|| ||Mar 2024|| 0.21|| 0.48|| 0.39|| 0.34|| 3.02|| 1.55|| 0.99|| '''6.98%'''|| ||Apr 2024|| 0.20|| 0.47|| 0.38|| 0.33|| 2.93|| 1.50|| 0.95|| '''6.76%'''|| ||May 2024|| 0.20|| 0.46|| 0.37|| 0.32|| 2.84|| 1.45|| 0.92|| '''6.56%'''|| ||Jun 2024|| 0.20|| 0.45|| 0.36|| 0.31|| 2.76|| 1.41|| 0.89|| '''6.38%'''|| ||Jul 2024|| 0.19|| 0.44|| 0.35|| 0.30|| 2.63|| 1.36|| 0.86|| '''6.13%'''|| ||Aug 2024|| 0.19|| 0.43|| 0.34|| 0.29|| 2.53|| 1.31|| 0.82|| '''5.91%'''|| ||Sep 2024|| 0.19|| 0.41|| 0.33|| 0.28|| 2.45|| 1.25|| 0.79|| '''5.70%'''|| ||Oct 2024|| 0.18|| 0.40|| 0.32|| 0.27|| 2.38|| 1.20|| 0.76|| '''5.51%'''|| ||Nov 2024|| 0.18|| 0.39|| 0.31|| 0.26|| 2.32|| 1.15|| 0.72|| '''5.33%'''|| ||Dec 2024|| 0.17|| 0.39|| 0.31|| 0.26|| 2.27|| 1.11|| 0.69|| '''5.20%'''|| ||Jan 2025|| 0.17|| 0.38|| 0.31|| 0.25|| 2.21|| 1.07|| 0.67|| '''5.06%'''|| ||Feb 2025|| 0.17|| 0.38|| 0.30|| 0.25|| 2.16|| 1.04|| 0.66|| '''4.96%'''|| -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 14:39:24 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 14:39:24 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter Message-ID: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> #62900: PNG original image not affected by conversion filter --------------------------+----------------------------- Reporter: pixlpirate | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Keywords: needs-patch Focuses: | --------------------------+----------------------------- **Filter used**: {{{#!php WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 14:55:00 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 14:55:00 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.a3685f5a615f6f3644f8055f9895af52@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: needs-patch dev-feedback needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by adamsilverstein): * keywords: needs-patch => needs-patch dev-feedback needs-testing * owner: (none) => adamsilverstein * status: new => reviewing Comment: Hi @pixlpirate - Thanks for the bug report. Can you verify that your server supports AVIF? You can check under Tools->Site Health->Info->Media. Additionally, can you try changing the filter to output WebP images instead of AVIF to see if that works? (98%+ of servers support WebP, while on ~30% support AVIF). -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 14:56:39 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 14:56:39 -0000 Subject: [wp-trac] [WordPress Trac] #62901: Editor: Fix 'parents' argument validation for Query block Message-ID: <052.6a182315e8a08e4a6aa05a3e708e6e25@wordpress.org> #62901: Editor: Fix 'parents' argument validation for Query block --------------------------+-------------------- Reporter: Mamaduka | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.8 Component: Editor | Version: Severity: normal | Keywords: Focuses: | --------------------------+-------------------- The `build_query_vars_from_query_block` doesn't allow specifying zero (`0`) in the parent's array argument, which can be used to display on top- level pages. Gutenberg PR: https://github.com/WordPress/gutenberg/pull/68983. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:09:45 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:09:45 -0000 Subject: [wp-trac] [WordPress Trac] #10275: Filter logic has been put into the template loader while it not belongs there. In-Reply-To: <049.dc3a7c711fbb3bb10c9e720a8469a3b1@wordpress.org> References: <049.dc3a7c711fbb3bb10c9e720a8469a3b1@wordpress.org> Message-ID: <064.d10e334a51cfbeccfa192167ba7fca8d@wordpress.org> #10275: Filter logic has been put into the template loader while it not belongs there. -------------------------------------------------+------------------------- Reporter: hakre | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Themes | Version: 2.8 Severity: normal | Resolution: wontfix Keywords: has-patch needs-testing has- | Focuses: template testing-info close | -------------------------------------------------+------------------------- Changes (by audrasjb): * status: reviewing => closed * resolution: => wontfix * milestone: 6.8 => Comment: As per today's bug scrub. Given the above discussion, decision was made to close this ticket as `wontfix` for now. Please feel free to reopen it if a new approach is discussed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:25:24 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:25:24 -0000 Subject: [wp-trac] [WordPress Trac] #18400: Suggested label change for "Stick this post to the front page" In-Reply-To: <056.6cab77f5c8de30c5406e51f9dcd5906f@wordpress.org> References: <056.6cab77f5c8de30c5406e51f9dcd5906f@wordpress.org> Message-ID: <071.431a4c4d4b55a99c8129cddefee81648@wordpress.org> #18400: Suggested label change for "Stick this post to the front page" -------------------------------------+------------------------------------- Reporter: designsimply | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: Posts, Post Types | Version: Severity: normal | Resolution: Keywords: has-patch needs-copy- | Focuses: administration, ui- review | copy -------------------------------------+------------------------------------- Comment (by audrasjb): As per today's bug scrub: it would be better to see a more universal wording here: maybe something as simple as "Stick this post" or "Make this post sticky". The current Gutenberg label is "Pin this post to the top of the blog" Which is, I think, incorrect (the "top of the blog part"). Also, we should stay with stick/sticky because that's used everywhere in our User Docs. This should be addressed on both Core and Gutenberg side. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:33:58 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:33:58 -0000 Subject: [wp-trac] [WordPress Trac] #40057: Double hashed value for background-color of body.background-color In-Reply-To: <063.9fc4694edbc7bf50364fab6ca1ea443e@wordpress.org> References: <063.9fc4694edbc7bf50364fab6ca1ea443e@wordpress.org> Message-ID: <078.6b24786a3edaebf9b8764ec1d24d082f@wordpress.org> #40057: Double hashed value for background-color of body.background-color -------------------------------------+------------------------ Reporter: hovhanneshovakimyan | Owner: audrasjb Type: defect (bug) | Status: reviewing Priority: normal | Milestone: 6.8 Component: Themes | Version: 4.7.3 Severity: normal | Resolution: Keywords: has-patch needs-testing | Focuses: -------------------------------------+------------------------ Changes (by audrasjb): * owner: (none) => audrasjb * status: new => reviewing Comment: Thanks for the ticket and patch. Self assigning for final review. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:38:45 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:38:45 -0000 Subject: [wp-trac] [WordPress Trac] #43622: Improve error messages In-Reply-To: <057.1c8d2266c06174a4457ea58df1fe9cdc@wordpress.org> References: <057.1c8d2266c06174a4457ea58df1fe9cdc@wordpress.org> Message-ID: <072.239e792f64056a17602ba6a20940b50d@wordpress.org> #43622: Improve error messages ---------------------------+------------------------ Reporter: peterwilsoncc | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui-copy ---------------------------+------------------------ Changes (by audrasjb): * keywords: => has-patch * owner: (none) => audrasjb * status: new => reviewing Comment: Thanks for addressing the requested changes. The PR looks good to me now. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:43:05 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:43:05 -0000 Subject: [wp-trac] [WordPress Trac] #42668: Remove WordPress Importer tests from default test suite In-Reply-To: <055.d0a89408e1b69456ac35159e05f425c8@wordpress.org> References: <055.d0a89408e1b69456ac35159e05f425c8@wordpress.org> Message-ID: <070.95603a7c6cea826123525d58f4919098@wordpress.org> #42668: Remove WordPress Importer tests from default test suite ------------------------------+----------------------- Reporter: Frank Klein | Owner: desrosj Type: enhancement | Status: assigned Priority: normal | Milestone: 6.8 Component: Build/Test Tools | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ------------------------------+----------------------- Changes (by desrosj): * owner: (none) => desrosj * status: new => assigned -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:49:59 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:49:59 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted Message-ID: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> #62902: Description of featured image is being deleted --------------------------+----------------------------- Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- The description of featured image is being deleted while going to replace from post editor page. **How to reproduce: ** 1. Upload a image with setting values only for "Alternative Text" & "Description" fields. https://i.imgur.com/DGjZBzi.png 2. Create a post & set featured image which uploaded. 3. Save as draft or publish the post. 4. Reload the post editor page & try to replace feature image, then you will notice that the description field is empty. https://i.imgur.com/gHUBWYY.png https://i.imgur.com/bEWi1JU.png My Environment: PHP: 8.2.4 Wordpress version :6.7.1 Theme: Twenty Twenty-Five And no plugins were installed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 15:59:05 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 15:59:05 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.73b955783a6e4cbd772ccd84c5414237@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: needs-patch dev-feedback needs- | Focuses: testing | -------------------------------------------------+------------------------- Comment (by pixlpirate): Hi @adamsilverstein Thanks for your reply. I’ve tested different output formats, including AVIF, WebP, and JPEG, and the issue seems to be related to the **input format** rather than the output format. //(Note that all the following tests were performed with images of the same dimensions)// ---- Dropping a JPEG file in the media library. **Input**: - image.jpg **Output**: - image.jpg - image.webp - image-150x150.webp - image-300x300.webp - etc. **Results**: - ✔️ The original image is preserved - ✔️ The original size is generated in the target format - ✔️ The thumbnails are generated in the target format I had similar results for the following **input** formats: JPEG, GIF, AVIF, WebP ---- Dropping a PNG image in the media library **Input** - image.png **Output** - image.png - image-150x150.webp - image-300x300.webp - etc. **Results**: - ✔️ The original image is preserved - ❌ The original size is not generated in the target format - ✔️ The thumbnails are generated in the target format -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:11:38 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:11:38 -0000 Subject: [wp-trac] [WordPress Trac] #62622: Bump minimum PHP version to 7.3 or 7.4 In-Reply-To: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> References: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> Message-ID: <069.fbf83ccb9e2b521767479a388eb8e57e@wordpress.org> #62622: Bump minimum PHP version to 7.3 or 7.4 -------------------------+------------------------------ Reporter: justlevine | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by johnbillion): I've tweaked [https://johnbillion.github.io/wp-stats/php.html my stats projection page] to better account for the slowing decline in 7.2+7.3 sites. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:23:13 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:23:13 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.25b035ea2aa2b91cc4c74bbf24644e42@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: needs-patch dev-feedback needs- | Focuses: testing | -------------------------------------------------+------------------------- Comment (by adamsilverstein): @pixlpirate excellent, thanks for clarifying! > Note that the sub-sizes of image.png are converted to AVIF (if any), but original image remains in PNG I missed this in reading your original report, we get many reports of AVIF not working so I jumped to that as a possible cause. This may be related to an issue reported with the Performance Lab plugin: https://github.com/WordPress/performance/issues/1798 I will try to reproduce this and review the fix you suggested. Some follow up questions: * Does this happen with ALL PNG uploads? * Can you share you site health->media data - I'm curious which media library/version is handling the PNGs in case that is related. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:37:31 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:37:31 -0000 Subject: [wp-trac] [WordPress Trac] #62896: Twenty Nineteen: Limit scope of aria-haspopup and aria-expanded to the primary menu In-Reply-To: <057.1aa21529924d17f9178cd10856c0fb2a@wordpress.org> References: <057.1aa21529924d17f9178cd10856c0fb2a@wordpress.org> Message-ID: <072.04efa2e24c820683b286d9c6c395e3da@wordpress.org> #62896: Twenty Nineteen: Limit scope of aria-haspopup and aria-expanded to the primary menu ---------------------------+------------------------------ Reporter: bschneidewind | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Bundled Theme | Version: Severity: minor | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+------------------------------ Comment (by sabernhardt): Related: https://core.trac.wordpress.org/ticket/47051#comment:11 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:44:22 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:44:22 -0000 Subject: [wp-trac] [WordPress Trac] #62897: Title attribute of menu item is not correctly displayed in the frontend In-Reply-To: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> References: <055.31f01598d4d0c88ba7f4de30751a89bc@wordpress.org> Message-ID: <070.617f6d23933a3a6292106e7ec3c95fc4@wordpress.org> #62897: Title attribute of menu item is not correctly displayed in the frontend -------------------------------+---------------------------- Reporter: manuel10503 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Menus | Version: Severity: normal | Resolution: wontfix Keywords: reporter-feedback | Focuses: accessibility -------------------------------+---------------------------- Changes (by joedolson): * status: new => closed * resolution: => wontfix * milestone: Awaiting Review => Comment: This was an intentional change, omitting title attributes if they are the same as the existing link text. Duplicate title attributes serve no functional purpose, and can introduce accessibility problems. This was handled in #51299. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:51:11 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:51:11 -0000 Subject: [wp-trac] [WordPress Trac] #62622: Bump minimum PHP version to 7.3 or 7.4 In-Reply-To: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> References: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> Message-ID: <069.dbec3ef4f98aadf942ae9817333e61ef@wordpress.org> #62622: Bump minimum PHP version to 7.3 or 7.4 -------------------------+------------------------------ Reporter: justlevine | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by masteradhoc): @johnbillion nice overview! Would it be possible to include PHP 8.4 as well? Would be interesting to see the progress there. But another topic :) As we're currently at 5.67% for PHP 7.2 and PHP 7.3 i think it would be great to tell everyone and especially also hosts that it will be considered to deprecate it in v6.9. Then everyone gets enough time to prepare and the Release Leads could check with Matt to see his opinion on a drop for the versions that are already unsupported since many years. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:53:31 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:53:31 -0000 Subject: [wp-trac] [WordPress Trac] #62881: Strict referrer policy is breaking post/page passwords In-Reply-To: <054.8a9bf530b66f2bc49eac867ab795f94e@wordpress.org> References: <054.8a9bf530b66f2bc49eac867ab795f94e@wordpress.org> Message-ID: <069.82fae4c7d17a548715fdb1d041a37a8a@wordpress.org> #62881: Strict referrer policy is breaking post/page passwords --------------------------------------+-------------------------- Reporter: zodiac1978 | Owner: johnbillion Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.8 Component: Posts, Post Types | Version: Severity: normal | Resolution: fixed Keywords: good-first-bug has-patch | Focuses: --------------------------------------+-------------------------- Changes (by johnbillion): * status: reviewing => closed * resolution: => fixed Comment: In [changeset:"59753" 59753]: {{{ #!CommitTicketReference repository="" revision="59753" Posts, Post Types: Explicitly pass a redirect URL for the post permalink when submitting the post password form. This allows the subsequent redirect to behave as expected if a site is using a strict referrer policy on the front end which prevents the full referrer from being sent. Props zodiac1978, yogeshbhutkar, hbhalodia, mukesh27. Fixes #62881 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 16:59:12 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 16:59:12 -0000 Subject: [wp-trac] [WordPress Trac] #62622: Bump minimum PHP version to 7.3 or 7.4 In-Reply-To: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> References: <054.0e8fc3c3ef21a16174aab98b36d22a1d@wordpress.org> Message-ID: <069.173bf541f3c8450c33cb41d583062d05@wordpress.org> #62622: Bump minimum PHP version to 7.3 or 7.4 -------------------------+------------------------------ Reporter: justlevine | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by johnbillion): I haven't bothered trying to project changes to usage of other versions because it's not a particularly accurate projection, it's intended really to give us an idea of when support for older versions can be dropped. I'm going to wait until 6.8 is nearer release before speaking with Matt and Mary about this, but I will. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 17:37:19 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 17:37:19 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.17dfd0823bbcbabdbcd3093ba1f2c523@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: needs-patch dev-feedback needs- | Focuses: testing | -------------------------------------------------+------------------------- Comment (by pixlpirate): > I missed this in reading your original report No problem! 🙂 I tested the following combinations, the problem occurs in all of them: - Size range between 270px to 4320px, square, landscape, portrait - 8-bit / 24-bit - With / Without alpha layer - With / Without interlacing I’m using PHP GD //(cf. site health attached)//, I can try to switch to ImageMagick if you need more tests. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 17:37:38 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 17:37:38 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.acd4b192eded6261a95f40d6d4c554c5@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: needs-patch dev-feedback needs- | Focuses: testing | -------------------------------------------------+------------------------- Changes (by pixlpirate): * Attachment "62900.site-health-report.png" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 17:57:02 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 17:57:02 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.ec8c0b70487d8dd812cd74245d98f050@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: needs-patch dev-feedback needs- | Focuses: testing | -------------------------------------------------+------------------------- Comment (by adamsilverstein): Thanks for all of the details, let me try reproducing first and we can go from there. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 18:19:28 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 18:19:28 -0000 Subject: [wp-trac] [WordPress Trac] #49258: Improper Session Termination In-Reply-To: <052.977ae97084eb27cba59fc950ae64c4b2@wordpress.org> References: <052.977ae97084eb27cba59fc950ae64c4b2@wordpress.org> Message-ID: <067.048abdd94498517f8ab16b3ebd349580@wordpress.org> #49258: Improper Session Termination -------------------------------------------------+------------------------- Reporter: vishal05 | Owner: (none) Type: enhancement | Status: closed Priority: normal | Milestone: Component: Users | Version: 5.1.1 Severity: normal | Resolution: duplicate Keywords: has-patch needs-testing 2nd-opinion | Focuses: | administration -------------------------------------------------+------------------------- Changes (by johnbillion): * status: new => closed * resolution: => duplicate * milestone: Awaiting Review => Comment: Duplicate of #21938. This got fixed in [55968]. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 19:51:07 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 19:51:07 -0000 Subject: [wp-trac] [WordPress Trac] #57304: Add SensitiveParameter attribute to DB connection and login variables In-Reply-To: <052.dc0011fea8d430c74beff76e84354613@wordpress.org> References: <052.dc0011fea8d430c74beff76e84354613@wordpress.org> Message-ID: <067.b4193d360b2d99c555bde35a3725d08e@wordpress.org> #57304: Add SensitiveParameter attribute to DB connection and login variables -----------------------------+-------------------------- Reporter: TobiasBg | Owner: johnbillion Type: enhancement | Status: closed Priority: normal | Milestone: 6.8 Component: Security | Version: Severity: normal | Resolution: fixed Keywords: php82 has-patch | Focuses: -----------------------------+-------------------------- Changes (by johnbillion): * owner: (none) => johnbillion * status: new => closed * resolution: => fixed Comment: In [changeset:"59754" 59754]: {{{ #!CommitTicketReference repository="" revision="59754" Security: Add the `SensitiveParameter` attribute to sensitive parameters. Values passed to parameters with this attribute will be redacted if present in a stack trace when using PHP 8.2 or later. This reduces the chance that passwords and security keys get accidentally exposed in debug logs and bug reports. Props petitphp, TobiasBg, jrf, johnbillion. Fixes #57304 }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 21:02:10 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 21:02:10 -0000 Subject: [wp-trac] [WordPress Trac] #62903: permission_callback should be called before validate_callback in REST API Message-ID: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> #62903: permission_callback should be called before validate_callback in REST API --------------------------+----------------------------- Reporter: donjajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Keywords: has-patch Focuses: rest-api | --------------------------+----------------------------- I am building a REST endpoint that goes like this `users/articles/{article_id}` while `{article_id}` can be validated with validate_callback on the $args parameter level. In my validation, I check for author of the article to match the current logged in user. If not, it should return WP_Error of 404 status, assuming the user is logged in. I expect 403 permission error to come up for guest, from `permission_callback`, but it does not. Rather, it throws 404 from `validate_callback` since the user is not logged in, and the ID does not match the author. Hence, `permission_callback` is not run. Most of the `validate_callback` on the endpoint does some user authentication validations which expects `permission_callback` to already have handled. I believe a better design will be permission_callback called first on each route before even running validations. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 21:03:41 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 21:03:41 -0000 Subject: [wp-trac] [WordPress Trac] #62903: permission_callback should be called before validate_callback in REST API In-Reply-To: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> References: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> Message-ID: <066.da5084c38b6571367bb9834de1b03483@wordpress.org> #62903: permission_callback should be called before validate_callback in REST API --------------------------+------------------------------ Reporter: donjajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api --------------------------+------------------------------ Changes (by donjajo): * Attachment "62903.diff" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 22:24:59 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 22:24:59 -0000 Subject: [wp-trac] =?utf-8?q?=5BWordPress_Trac=5D_=2354738=3A_Unable_to_u?= =?utf-8?q?pload_images_with_URL_over_API_when_the_image_doesn=E2=80=99t_h?= =?utf-8?q?ave_a_filetype_in_the_filename?= In-Reply-To: <055.8ae0facfad7850a74ed41d138d3a048e@wordpress.org> References: <055.8ae0facfad7850a74ed41d138d3a048e@wordpress.org> Message-ID: <070.6b9c554ebb2e414df1e8714a3f2aca19@wordpress.org> #54738: Unable to upload images with URL over API when the image doesn’t have a filetype in the filename -------------------------------------------------+------------------------- Reporter: masteradhoc | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.8 Component: Media | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests needs- | Focuses: rest-api testing 2nd-opinion | -------------------------------------------------+------------------------- Comment (by joedolson): @masteradhoc If you can confirm whether the current PR meets your use case, that would be useful. I've just refreshed the PR, so it's up to date. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Mon Feb 3 23:41:59 2025 From: noreply at wordpress.org (WordPress Trac) Date: Mon, 03 Feb 2025 23:41:59 -0000 Subject: [wp-trac] [WordPress Trac] #62279: Coding Standards fixes for WP 6.8 In-Reply-To: <051.b0c0f5c89d6ca345286ca5fb9960d462@wordpress.org> References: <051.b0c0f5c89d6ca345286ca5fb9960d462@wordpress.org> Message-ID: <066.3d2ebaa47d3a7b912ad385cab2a2b873@wordpress.org> #62279: Coding Standards fixes for WP 6.8 ----------------------------+--------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ----------------------------+--------------------- Comment (by SergeyBiryukov): In [changeset:"59755" 59755]: {{{ #!CommitTicketReference repository="" revision="59755" Coding Standards: Use a more meaningful variable name in `WP_List_Table::months_dropdown()`. As per the [https://developer.wordpress.org/coding-standards/wordpress- coding-standards/php/#naming-conventions Naming Conventions]: > Don't abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting. Follow-up to [8646], [15491]. See #62279. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 00:09:45 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 00:09:45 -0000 Subject: [wp-trac] [WordPress Trac] #39242: Add caching to count_user_posts() In-Reply-To: <059.10c47223454844612714cc185b03cfdd@wordpress.org> References: <059.10c47223454844612714cc185b03cfdd@wordpress.org> Message-ID: <074.f91f25ae945a228d9886b1ce1d7e3820@wordpress.org> #39242: Add caching to count_user_posts() -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: whyisjake Type: enhancement | Status: accepted Priority: normal | Milestone: 6.8 Component: Users | Version: 3.0 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: rest-api, testing has-unit-tests | performance -------------------------------------------------+------------------------- Changes (by peterwilsoncc): * milestone: Future Release => 6.8 Comment: I've approved the [https://github.com/WordPress/wordpress- develop/pull/8233 linked pull request #8233] for commit. I'm happy it addresses the issues highlighted earlier as it uses a hash of the SQL query to generate the cache key and includes the posts' `last- changed` value to break the cache as authors are potentially reassigned or posts marked private. I've confirmed that the users' `last-changed` value isn't needed as the function doesn't take in to account whether or not the user ID exists. Strange but true. When a user is deleted and their posts reassigned the post `last-change` value is bumped. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 00:19:20 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 00:19:20 -0000 Subject: [wp-trac] [WordPress Trac] #43421: The $capabilities argument in the `add_role()` function requires an explicit grant In-Reply-To: <051.b970bbeceed7d03e2292548fe07a3f8d@wordpress.org> References: <051.b970bbeceed7d03e2292548fe07a3f8d@wordpress.org> Message-ID: <066.231b22844f4f43e714ffd919bbb746a4@wordpress.org> #43421: The $capabilities argument in the `add_role()` function requires an explicit grant --------------------------------------+-------------------------- Reporter: eclev91 | Owner: johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.8 Component: Role/Capability | Version: 4.9.4 Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+-------------------------- Changes (by johnbillion): * owner: (none) => johnbillion * status: reopened => reviewing * milestone: Awaiting Review => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 00:29:13 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 00:29:13 -0000 Subject: [wp-trac] [WordPress Trac] #50442: Add prefixes to all admin notices (Warning, Error, Success, Info) In-Reply-To: <050.338e97da01da8efd48f976a73c782250@wordpress.org> References: <050.338e97da01da8efd48f976a73c782250@wordpress.org> Message-ID: <065.12c7a22a409a486fb3290d51c4bf7908@wordpress.org> #50442: Add prefixes to all admin notices (Warning, Error, Success, Info) -------------------------------+----------------------------------------- Reporter: kebbet | Owner: joedolson Type: enhancement | Status: accepted Priority: normal | Milestone: 6.8 Component: Administration | Version: Severity: normal | Resolution: Keywords: needs-patch early | Focuses: ui, accessibility, ui-copy -------------------------------+----------------------------------------- Changes (by joedolson): * keywords: early has-patch => needs-patch early Comment: Started a draft PR to start moving this forward; but I think we may need to resolve #62619, first. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 00:30:23 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 00:30:23 -0000 Subject: [wp-trac] [WordPress Trac] #62281: Docblock improvements for WP 6.8 In-Reply-To: <051.5116f081aaa89d2b5291b848459d31a5@wordpress.org> References: <051.5116f081aaa89d2b5291b848459d31a5@wordpress.org> Message-ID: <066.8c69b82809ac69c77b93b94e1d7ef928@wordpress.org> #62281: Docblock improvements for WP 6.8 ----------------------------+------------------------------- Reporter: desrosj | Owner: (none) Type: task (blessed) | Status: new Priority: normal | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: coding-standards ----------------------------+------------------------------- Comment (by SergeyBiryukov): In [changeset:"59756" 59756]: {{{ #!CommitTicketReference repository="" revision="59756" Docs: Correct DocBlock formatting for `the_password_form` filter. Follow-up to [59736], [59737]. See #62281. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 02:42:23 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 02:42:23 -0000 Subject: [wp-trac] [WordPress Trac] #62471: Fix malformed variation selector in theme.json when block uses non-trival CSS selector In-Reply-To: <059.6f93a2fa3941d5b6c28a1db42fdc7e14@wordpress.org> References: <059.6f93a2fa3941d5b6c28a1db42fdc7e14@wordpress.org> Message-ID: <074.1bb9d2d748665ece0cb6ecddb57eb92d@wordpress.org> #62471: Fix malformed variation selector in theme.json when block uses non-trival CSS selector -------------------------------------------------+------------------------- Reporter: aaronrobertshaw | Owner: joemcgill Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: gutenberg-merge has-patch has-unit- | Focuses: tests has-testing-info commit | -------------------------------------------------+------------------------- Changes (by joemcgill): * keywords: gutenberg-merge has-patch has-unit-tests has-testing-info => gutenberg-merge has-patch has-unit-tests has-testing-info commit * owner: (none) => joemcgill * status: new => accepted * milestone: Awaiting Review => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 02:50:22 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 02:50:22 -0000 Subject: [wp-trac] [WordPress Trac] #62269: WP_HTML_Processor::next_token() cannot be extended in subclasses to keep track of state In-Reply-To: <055.a3492628d57e8684a057dc6ef5aa64fa@wordpress.org> References: <055.a3492628d57e8684a057dc6ef5aa64fa@wordpress.org> Message-ID: <070.e11c172f77f774c829543c57ab9c8480@wordpress.org> #62269: WP_HTML_Processor::next_token() cannot be extended in subclasses to keep track of state -------------------------------------------------+------------------------- Reporter: westonruter | Owner: | westonruter Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.7.2 Component: HTML API | Version: 6.5 Severity: normal | Resolution: fixed Keywords: has-unit-tests has-patch fixed- | Focuses: major | -------------------------------------------------+------------------------- Changes (by jorbin): * status: reopened => closed * resolution: => fixed Comment: Fixed in [59757] HTML API: Fix extensibility of WP_HTML_Processor::next_token(). Break out logic from the next_token() method into a private method which may call itself recursively. This allows for subclasses to override the next_token() method and be assured that each call to next_token() corresponds with the consumption of one single token. This also parallels how WP_HTML_Tag_Processor::next_token() wraps a private base_class_next_token() method. Reviewed by jonsurrell. Merges [59285], [59364], and [59747] to 6.7 branch. Props westonruter, jonsurrell, dmsnell, jorbin. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 03:01:34 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 03:01:34 -0000 Subject: [wp-trac] [WordPress Trac] #62494: Some links on the left controls of theme customise non responsive In-Reply-To: <050.edb60b51ab935079fe76bed9c25e64bc@wordpress.org> References: <050.edb60b51ab935079fe76bed9c25e64bc@wordpress.org> Message-ID: <065.417342890d993164e70afabae088a836@wordpress.org> #62494: Some links on the left controls of theme customise non responsive -------------------------------------------------+------------------------- Reporter: paullb | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.7.2 Component: Customize | Version: 6.7 Severity: normal | Resolution: fixed Keywords: has-patch commit fixed-major dev- | Focuses: javascript reviewed | -------------------------------------------------+------------------------- Changes (by jorbin): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"59758" 59758]: {{{ #!CommitTicketReference repository="" revision="59758" Customizer: Allow custom accordion items with obsolete structure. In [59224], customizer accordion item HTML structure was changed to include a button element as the interactive control. However, some themes inject custom markup for panel headings. Fix controls.js to handle both the new markup and the old markup, which is relatively common in themes. Reviewed by jorbin. Merges [59555] to the 6.7 branch. Props paullb, desrosj, sabernhardt, joedolson, jorbin. Fixes #62494. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 03:24:34 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 03:24:34 -0000 Subject: [wp-trac] [WordPress Trac] #62534: Pagination broken in admin for categories / tags / plugins In-Reply-To: <052.a14149d4e21f9bef4343d4c447c1a211@wordpress.org> References: <052.a14149d4e21f9bef4343d4c447c1a211@wordpress.org> Message-ID: <067.c0607250da6dbc63a666de256f5cf44b@wordpress.org> #62534: Pagination broken in admin for categories / tags / plugins -------------------------------------+------------------------------------- Reporter: ffffelix | Owner: joedolson Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.7.2 Component: Administration | Version: 6.7 Severity: normal | Resolution: fixed Keywords: has-patch has-testing- | Focuses: ui, javascript, info dev-feedback commit | administration -------------------------------------+------------------------------------- Changes (by jorbin): * status: reopened => closed * resolution: => fixed Comment: In [changeset:"59759" 59759]: {{{ #!CommitTicketReference repository="" revision="59759" Administration: Fix pagination in categories, tags, and plugins tables. Fix an issue introduced in [59134] that prevented manual entry of a page number in the pagination input field from navigating pages. Requiring validation of the bulk actions input also impacted other inputs nested in the same form. Also fixes a pre-existing bug where it was not possible to navigate to page 1 using the input field. Reviewed by jorbin. Merges [59727] and [59746] to the 6.7 branch. Props ffffelix, im3dabasia1, apermo, rishavdutta, joedolson, swissspidy, jorbin, joedolson, tobiasbg, mamaduka. Fixes #62534. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 05:54:57 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 05:54:57 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted In-Reply-To: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> References: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> Message-ID: <067.fbef7148c5b087d74f2514cb20a4badd@wordpress.org> #62902: Description of featured image is being deleted --------------------------+------------------------------ Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by vishalmori): * Attachment "Screencast from 04-02-25 11:17:01 AM IST.webm" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 05:57:37 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 05:57:37 -0000 Subject: [wp-trac] [WordPress Trac] #51249: Fix alignment and usable width for Customizer's Schedule date/time fields In-Reply-To: <054.027a6a87d10229f24e25e02b4c77b67c@wordpress.org> References: <054.027a6a87d10229f24e25e02b4c77b67c@wordpress.org> Message-ID: <069.5a7f8d40b7f5cdfb2a7f794af6fa54e6@wordpress.org> #51249: Fix alignment and usable width for Customizer's Schedule date/time fields --------------------------+---------------------- Reporter: rkradadiya | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.8 Component: Customize | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: ui, css --------------------------+---------------------- Changes (by sabernhardt): * milestone: Future Release => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 06:05:11 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 06:05:11 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted In-Reply-To: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> References: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> Message-ID: <067.6b9cd6ee794c0c4bed8540528ccb2a03@wordpress.org> #62902: Description of featured image is being deleted --------------------------+------------------------------ Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Comment (by vishalmori): Hello @jogashst, I tried to reproduce your issue with saving the post as a draft and publishing, but it seems to work perfectly. In latest clean setup with Twenty Twenty-Five and no plugins were installed. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 06:07:39 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 06:07:39 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted In-Reply-To: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> References: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> Message-ID: <067.742c2213b343f027357260b88f8744a1@wordpress.org> #62902: Description of featured image is being deleted --------------------------+------------------------------ Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: | Focuses: --------------------------+------------------------------ Changes (by vishalmori): * Attachment "Screencast from 04-02-25 11:36:22 AM IST.webm" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 06:17:48 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 06:17:48 -0000 Subject: [wp-trac] [WordPress Trac] #44610: Allow Youtube-Player to use youtube-nocookie.com URLS to avoid setting cookies. In-Reply-To: <053.a4bc4e0b7193bee7e68ef8aed576a707@wordpress.org> References: <053.a4bc4e0b7193bee7e68ef8aed576a707@wordpress.org> Message-ID: <068.fa57f8dc7b5cb8befee88f2e6eccb8d5@wordpress.org> #44610: Allow Youtube-Player to use youtube-nocookie.com URLS to avoid setting cookies. -------------------------+------------------------ Reporter: jepperask | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.8 Component: Embeds | Version: 4.9.7 Severity: normal | Resolution: Keywords: needs-patch | Focuses: privacy -------------------------+------------------------ Changes (by audrasjb): * keywords: needs-testing needs-patch => needs-patch Comment: Removing needs-testing as we still need a new patch to add the Youtube No Cookie embed domain. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 06:38:17 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 06:38:17 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted In-Reply-To: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> References: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> Message-ID: <067.03c58d1c1897ea0d75908dab86f2d2b9@wordpress.org> #62902: Description of featured image is being deleted -----------------------------+------------------------------ Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: -----------------------------+------------------------------ Changes (by sukhendu2002): * keywords: => has-screenshots Comment: == Reproduction Report === Description This report validates whether the issue can be reproduced. === Environment - WordPress: 6.7.1 - PHP: 8.2.27 - Server: nginx/1.27.3 - Database: mysqli (Server: 8.0.41 / Client: mysqlnd 8.2.27) - Browser: Chrome 132.0.0.0 - OS: macOS - Theme: Twenty Twenty-Five 1.0 - MU Plugins: None activated - Plugins: - Test Reports 1.2.0 === Actual Results 1. ❌ Not able to reproduce the bug. === Additional Notes The description of the featured image works as expected. I also tried to reproduce this in the current trunk, but everything seems fine. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 07:29:20 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 07:29:20 -0000 Subject: [wp-trac] [WordPress Trac] #62901: Editor: Fix 'parents' argument validation for Query block In-Reply-To: <052.6a182315e8a08e4a6aa05a3e708e6e25@wordpress.org> References: <052.6a182315e8a08e4a6aa05a3e708e6e25@wordpress.org> Message-ID: <067.82a19a002d022c085162dfe2a8da9aa7@wordpress.org> #62901: Editor: Fix 'parents' argument validation for Query block ------------------------------+--------------------- Reporter: Mamaduka | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.8 Component: Editor | Version: Severity: normal | Resolution: Keywords: has-patch commit | Focuses: ------------------------------+--------------------- Changes (by audrasjb): * keywords: has-patch => has-patch commit Comment: @Mamaduka I'm fine with the changeset + the related unit test case 👍 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 07:43:04 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 07:43:04 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted In-Reply-To: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> References: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> Message-ID: <067.fd622ffccda236dc8f0c04b52aa55b52@wordpress.org> #62902: Description of featured image is being deleted -----------------------------+------------------------------ Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: has-screenshots | Focuses: -----------------------------+------------------------------ Comment (by jogashst): Hi @sukhendu2002, Please, also keep empty the title of image. https://www.awesomescreenshot.com/video/36213615?key=3c6963c4836fb8c88ad9267c4f251250 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 07:51:15 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 07:51:15 -0000 Subject: [wp-trac] [WordPress Trac] #62903: permission_callback should be called before validate_callback in REST API In-Reply-To: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> References: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> Message-ID: <066.d95fa6a0b6055ee4ea7e8676f63504d1@wordpress.org> #62903: permission_callback should be called before validate_callback in REST API --------------------------+------------------------------ Reporter: donjajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api --------------------------+------------------------------ Comment (by dd32): I believe what you're seeing is correct. `validate_callback` shouldn't be used to validate whether it's correct for a user, rather, it should validate that the value presented is correct for the field. For example: {{{ validate_callback: Validate that the ID input is numeric. This should only fail for always invalid inputs. permission_callback: Verify that the user is logged in, and has access to the referenced item callback: Fetch data, output }}} It would be best practice to also include capability checks in the callback itself, rather than purely relying upon the permission_callback, as capability checks should be relatively cheap computation wise. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 08:12:39 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 08:12:39 -0000 Subject: [wp-trac] [WordPress Trac] #62903: permission_callback should be called before validate_callback in REST API In-Reply-To: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> References: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> Message-ID: <066.ddc9c3cc27d9eaf0cbf890bc712de6dd@wordpress.org> #62903: permission_callback should be called before validate_callback in REST API --------------------------+------------------------------ Reporter: donjajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: rest-api --------------------------+------------------------------ Comment (by donjajo): Replying to [comment:3 dd32]: > I believe what you're seeing is correct. > > `validate_callback` shouldn't be used to validate whether it's correct for a user, rather, it should validate that the value presented is correct for the field. > > For example: > {{{ > validate_callback: Validate that the ID input is numeric. This should only fail for always invalid inputs. > ie. is_numeric( $input ) > > permission_callback: Verify that the user is logged in, and has access to the referenced item > ie. current_user_can( 'edit_post', $post_id ) > > callback: Fetch data, output > ie. return get_post( $post_id )->post_name; > }}} > > It would be best practice to also include capability checks in the callback itself, rather than purely relying upon the permission_callback, as capability checks should be relatively cheap computation wise. Your explanation is valid. What I am concerned about is the order of execution. I think permission check should come first before the validation check. For example: - permission_callback: Checks if user is logged in and is in "writers role" - validation_callback: Checks if the current logged-in user has access to their URL resource which specifies the ID. This is also a valid use-case of validation_callback, because, if the user does not, it is an invalid value. (e.g. trying to access a post that you did not create `users/articles/{article_id}`) We require permissions to pass before validation. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 08:14:27 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 08:14:27 -0000 Subject: [wp-trac] [WordPress Trac] #62902: Description of featured image is being deleted In-Reply-To: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> References: <052.57961a7d49880e56197e4917eedd3bd3@wordpress.org> Message-ID: <067.ea50b8db12354757423a9a104e213983@wordpress.org> #62902: Description of featured image is being deleted ----------------------------------------------+---------------------------- Reporter: jogashst | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: has-screenshots has-testing-info | Focuses: ----------------------------------------------+---------------------------- Changes (by sukhendu2002): * keywords: has-screenshots => has-screenshots has-testing-info -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 08:24:31 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 08:24:31 -0000 Subject: [wp-trac] [WordPress Trac] #3329: Need to strip % from the auto-permalink in the editor. In-Reply-To: <052.7bfeb25fe1afa743689b3c6fe2008300@wordpress.org> References: <052.7bfeb25fe1afa743689b3c6fe2008300@wordpress.org> Message-ID: <067.dfcc5015826239affe38a8e6e4b91709@wordpress.org> #3329: Need to strip % from the auto-permalink in the editor. -------------------------------------------------+------------------------- Reporter: Heyneken | Owner: pishmishy Type: defect (bug) | Status: accepted Priority: normal | Milestone: Future | Release Component: Permalinks | Version: 2.0 Severity: normal | Resolution: Keywords: has-patch 2nd-opinion has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by abcd95): Thanks, @Mte90, for the suggestion. I agree that a simple unit test might add that extra layer of safety. I have added the unit test. Any improvements or suggestions are welcomed! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 08:40:55 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 08:40:55 -0000 Subject: [wp-trac] [WordPress Trac] #52592: PHP warning when the label property is missing from register_block_style In-Reply-To: <049.647580af2615a04d1cf6974c6229f95e@wordpress.org> References: <049.647580af2615a04d1cf6974c6229f95e@wordpress.org> Message-ID: <064.b792494bc32ea892176d0c55a9fc2b65@wordpress.org> #52592: PHP warning when the label property is missing from register_block_style -------------------------------------------------+------------------------- Reporter: poena | Owner: audrasjb Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.8 Component: Editor | Version: 5.3 Severity: normal | Resolution: fixed Keywords: has-patch needs-testing has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Changes (by audrasjb): * owner: (none) => audrasjb * status: new => closed * resolution: => fixed Comment: In [changeset:"59760" 59760]: {{{ #!CommitTicketReference repository="" revision="59760" Editor: Add a fallback to `WP_Block_Styles_Registry` if the label is missing. Both `name` and `label` properties are required when registering a block style. If the label is missing, assign `name` as the value for the `label`, to ensure the property is defined. This avoids a PHP warning in such case. Props poena, Rahmohn, aaronrobertshaw, audrasjb, rinkalpagdar. Fixes #52592. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 08:59:22 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 08:59:22 -0000 Subject: [wp-trac] [WordPress Trac] #62901: Editor: Fix 'parents' argument validation for Query block In-Reply-To: <052.6a182315e8a08e4a6aa05a3e708e6e25@wordpress.org> References: <052.6a182315e8a08e4a6aa05a3e708e6e25@wordpress.org> Message-ID: <067.e3de4d774ef4f3ee1b8680f8964db1bf@wordpress.org> #62901: Editor: Fix 'parents' argument validation for Query block ------------------------------+----------------------- Reporter: Mamaduka | Owner: Mamaduka Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.8 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch commit | Focuses: ------------------------------+----------------------- Changes (by Mamaduka): * owner: (none) => Mamaduka * status: new => closed * resolution: => fixed Comment: In [changeset:"59761" 59761]: {{{ #!CommitTicketReference repository="" revision="59761" Editor: Fix `parents` argument validation for Query block. Allow passing zero (`0`) via the `parents` argument. It is a valid value for hierarchical post types, often used to display top-level items. Props mamaduka, audrasjb, peterwilsoncc. Fixes #62901. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 11:40:23 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 11:40:23 -0000 Subject: [wp-trac] [WordPress Trac] #34093: New filter: `get_calendar_post_type` in get_calendar() In-Reply-To: <060.5f223942a0239a78c38c1f03ebcab378@wordpress.org> References: <060.5f223942a0239a78c38c1f03ebcab378@wordpress.org> Message-ID: <075.72d05c8d67bf580abdca6069d50a152f@wordpress.org> #34093: New filter: `get_calendar_post_type` in get_calendar() --------------------------------------+--------------------- Reporter: sebastian.pisula | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Component: Widgets | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Comment (by sukhendu2002): Hi @swissspidy, This improvement looks quite valuable! I've refreshed the patch, would you be able to take a look? Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 12:15:53 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 12:15:53 -0000 Subject: [wp-trac] [WordPress Trac] #34093: New filter: `get_calendar_post_type` in get_calendar() In-Reply-To: <060.5f223942a0239a78c38c1f03ebcab378@wordpress.org> References: <060.5f223942a0239a78c38c1f03ebcab378@wordpress.org> Message-ID: <075.0f13810ff90c6bbe9544cf218de649a3@wordpress.org> #34093: New filter: `get_calendar_post_type` in get_calendar() --------------------------------------+--------------------- Reporter: sebastian.pisula | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: 6.8 Component: Widgets | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+--------------------- Changes (by swissspidy): * milestone: => 6.8 Comment: Oh wow, my last comment here is from 8+ years ago! I don't remember any of that :-) PR looks like a good start at first glance, but I don't have time for a proper review right now. Maybe @SergeyBiryukov or @audrasjb do. Otherwise I suggest to bring it up in dev chat or so. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 13:03:46 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 13:03:46 -0000 Subject: [wp-trac] [WordPress Trac] #62810: Pattern with Query Loop and Cover block renders wrongly in preview In-Reply-To: <052.e4905dfc95e52b02a6d7e28890263f1c@wordpress.org> References: <052.e4905dfc95e52b02a6d7e28890263f1c@wordpress.org> Message-ID: <067.83dffc709cc578b02eb5fcc8b398aefd@wordpress.org> #62810: Pattern with Query Loop and Cover block renders wrongly in preview ---------------------------+------------------------------ Reporter: radeeven | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Editor | Version: 6.7.1 Severity: minor | Resolution: Keywords: needs-testing | Focuses: ---------------------------+------------------------------ Changes (by poena): * keywords: => needs-testing Comment: Hi, I have not forgotten about this, but I have not had time test more. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 13:34:59 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 13:34:59 -0000 Subject: [wp-trac] [WordPress Trac] #62888: Plugin dependencies and "pro" version In-Reply-To: <050.c708bbd376dcdcfe7275420fe050afbc@wordpress.org> References: <050.c708bbd376dcdcfe7275420fe050afbc@wordpress.org> Message-ID: <065.1162241319bbfad6e68b3d068052a89a@wordpress.org> #62888: Plugin dependencies and "pro" version --------------------------+------------------------------------------ Reporter: hupe13 | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: HTTP API | Version: 6.7.1 Severity: normal | Resolution: duplicate Keywords: | Focuses: administration, performance --------------------------+------------------------------------------ Comment (by afragen): This should work. {{{ add_filter( 'wp_plugin_dependencies_slug', function ($slug) { $slug = 'my-plugin' === $slug ? 'muy-plugin-pro' : $slug; return $slug; }, 10, 1 ); }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 13:38:06 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 13:38:06 -0000 Subject: [wp-trac] [WordPress Trac] #34093: New filter: `get_calendar_post_type` in get_calendar() In-Reply-To: <060.5f223942a0239a78c38c1f03ebcab378@wordpress.org> References: <060.5f223942a0239a78c38c1f03ebcab378@wordpress.org> Message-ID: <075.19bb93edffb562f6c24d32d5c3a26d17@wordpress.org> #34093: New filter: `get_calendar_post_type` in get_calendar() --------------------------------------+------------------------ Reporter: sebastian.pisula | Owner: audrasjb Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.8 Component: Widgets | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: --------------------------------------+------------------------ Changes (by audrasjb): * owner: (none) => audrasjb * status: new => reviewing Comment: Thanks for the ping, @swissspidy! Self assigning for review/test. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 14:15:23 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 14:15:23 -0000 Subject: [wp-trac] [WordPress Trac] #51662: Pagination adds extra trailing slash at the end of some URLs In-Reply-To: <054.34edef4238aa8e963dea38a4ad20b88b@wordpress.org> References: <054.34edef4238aa8e963dea38a4ad20b88b@wordpress.org> Message-ID: <069.f5cc187898d06b6e18cd66d0e9c4bcc1@wordpress.org> #51662: Pagination adds extra trailing slash at the end of some URLs ---------------------------+------------------------------ Reporter: thornsteps | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Rewrite Rules | Version: 5.5.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Changes (by jignesh.nakrani): * Attachment "51662.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 14:20:08 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 14:20:08 -0000 Subject: [wp-trac] [WordPress Trac] #51662: Pagination adds extra trailing slash at the end of some URLs In-Reply-To: <054.34edef4238aa8e963dea38a4ad20b88b@wordpress.org> References: <054.34edef4238aa8e963dea38a4ad20b88b@wordpress.org> Message-ID: <069.e53f56420cbd75e783f80a46a09f33de@wordpress.org> #51662: Pagination adds extra trailing slash at the end of some URLs ---------------------------+------------------------------ Reporter: thornsteps | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Rewrite Rules | Version: 5.5.1 Severity: normal | Resolution: Keywords: has-patch | Focuses: ---------------------------+------------------------------ Comment (by jignesh.nakrani): I tried to reproduce the issue In the latest clean setup with Twenty Twenty-Five, and no plugins were installed. It still exists. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 15:07:41 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 15:07:41 -0000 Subject: [wp-trac] [WordPress Trac] #43318: New filter suggestion for manage_users-network_custom_column In-Reply-To: <053.36e3863a0b36e14b3b8cf9f2cfed062b@wordpress.org> References: <053.36e3863a0b36e14b3b8cf9f2cfed062b@wordpress.org> Message-ID: <068.aadf77ba756a525ebe4b80c7ae57c2e6@wordpress.org> #43318: New filter suggestion for manage_users-network_custom_column -------------------------+------------------------------ Reporter: lenasterg | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Users | Version: Severity: normal | Resolution: Keywords: | Focuses: multisite -------------------------+------------------------------ Comment (by lenasterg): Replying to [comment:5 realloc]: > I would set the current version. This information can be set later on, if needed. Perhaps the committer could handle this? I am unsure of the correct approach. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 15:08:33 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 15:08:33 -0000 Subject: [wp-trac] [WordPress Trac] #62895: Bundled Themes: Accessibility additions to the site title link In-Reply-To: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> References: <057.e29ab668155982e5c1fbdef6886e7dad@wordpress.org> Message-ID: <072.9abaebe7c1eeb9d222ca8d4739c2df0c@wordpress.org> #62895: Bundled Themes: Accessibility additions to the site title link ---------------------------+---------------------------- Reporter: bschneidewind | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Bundled Theme | Version: Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * milestone: Awaiting Review => 6.8 Old description: > In Twenty Twenty, the aria-current and rel="home" attributes are missing > on the site logo. > > Can be seen at: https://wp-themes.com/twentytwenty/ New description: In most bundled themes, the aria-current and rel="home" attributes are missing on the site logo. Can be seen at: https://wp-themes.com/twentytwenty/ -- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 15:13:18 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 15:13:18 -0000 Subject: [wp-trac] [WordPress Trac] #62806: Customizer: Respect settings that minimize non-essential motion In-Reply-To: <053.22411920fd2cb92b1f274232c8ce0407@wordpress.org> References: <053.22411920fd2cb92b1f274232c8ce0407@wordpress.org> Message-ID: <068.3c9b5c52f8f9378efad0d3390b59b543@wordpress.org> #62806: Customizer: Respect settings that minimize non-essential motion --------------------------+---------------------------- Reporter: wildworks | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Customize | Version: 3.4 Severity: normal | Resolution: Keywords: has-patch | Focuses: accessibility --------------------------+---------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * version: => 3.4 * milestone: Awaiting Review => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 15:14:14 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 15:14:14 -0000 Subject: [wp-trac] [WordPress Trac] #62835: Remove title attributes from author link functions In-Reply-To: <055.11f6fedc8818f923405c82cd932147f5@wordpress.org> References: <055.11f6fedc8818f923405c82cd932147f5@wordpress.org> Message-ID: <070.5f26f86a0913d243811b5e453d698e33@wordpress.org> #62835: Remove title attributes from author link functions -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Users | Version: Severity: normal | Resolution: Keywords: title-attribute has-patch has-unit- | Focuses: tests | accessibility -------------------------------------------------+------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * milestone: Awaiting Review => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 15:17:25 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 15:17:25 -0000 Subject: [wp-trac] [WordPress Trac] #62896: Twenty Nineteen: Limit scope of aria-haspopup and aria-expanded to the primary menu In-Reply-To: <057.1aa21529924d17f9178cd10856c0fb2a@wordpress.org> References: <057.1aa21529924d17f9178cd10856c0fb2a@wordpress.org> Message-ID: <072.c9c505264f910798f1f7dc44da63a06e@wordpress.org> #62896: Twenty Nineteen: Limit scope of aria-haspopup and aria-expanded to the primary menu ---------------------------+---------------------------- Reporter: bschneidewind | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Bundled Theme | Version: 5.0 Severity: minor | Resolution: Keywords: has-patch | Focuses: accessibility ---------------------------+---------------------------- Changes (by joedolson): * owner: (none) => joedolson * status: new => accepted * version: => 5.0 * milestone: Awaiting Review => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 15:28:03 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 15:28:03 -0000 Subject: [wp-trac] [WordPress Trac] #59252: is_front_page returns false when a static blog page has been set. In-Reply-To: <051.ef179dee9a06e4e8782b96b1eca2b9bd@wordpress.org> References: <051.ef179dee9a06e4e8782b96b1eca2b9bd@wordpress.org> Message-ID: <066.f9e5394cb2995534d58265aa093d5341@wordpress.org> #59252: is_front_page returns false when a static blog page has been set. --------------------------+------------------------ Reporter: neo2k23 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: Component: General | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------ Changes (by joedolson): * owner: (none) => joedolson * status: reopened => accepted Comment: Accepting this so that I can assess the impact at the same time as I'm looking at #62895. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 16:08:18 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 16:08:18 -0000 Subject: [wp-trac] [WordPress Trac] #39242: Add caching to count_user_posts() In-Reply-To: <059.10c47223454844612714cc185b03cfdd@wordpress.org> References: <059.10c47223454844612714cc185b03cfdd@wordpress.org> Message-ID: <074.14d96579191b70dffca890c5f3afff10@wordpress.org> #39242: Add caching to count_user_posts() -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: whyisjake Type: enhancement | Status: accepted Priority: normal | Milestone: 6.8 Component: Users | Version: 3.0 Severity: normal | Resolution: Keywords: has-patch dev-feedback needs- | Focuses: rest-api, testing has-unit-tests | performance -------------------------------------------------+------------------------- Comment (by spacedmonkey): @johnjamesjacoby I believe [https://github.com/WordPress/wordpress- develop/pull/8233 #8233] is getting close. As the original reporter, do you want to take a look at this PR? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 16:28:45 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 16:28:45 -0000 Subject: [wp-trac] [WordPress Trac] #62861: Consider removing title attributes from Classic Editor scripts In-Reply-To: <055.283b2c3cb0e427958b53a2a9a1620a6c@wordpress.org> References: <055.283b2c3cb0e427958b53a2a9a1620a6c@wordpress.org> Message-ID: <070.a5203246bf1406e641a007f73b1ab30d@wordpress.org> #62861: Consider removing title attributes from Classic Editor scripts -----------------------------------------+---------------------------- Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: accepted Priority: low | Milestone: 6.8 Component: TinyMCE | Version: Severity: normal | Resolution: Keywords: title-attribute 2nd-opinion | Focuses: accessibility -----------------------------------------+---------------------------- Changes (by sabernhardt): * type: enhancement => defect (bug) Old description: > Related: #24766 > > The WordPress script adds `title` attributes to the placeholder images > for `style`, `script`, More and Next Page tags. > > - The [https://github.com/WordPress/wordpress- > develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L119 > More tag] and [https://github.com/WordPress/wordpress- > develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L128 > Next Page tag] have an empty `alt` but use a `title` attribute (like > `alt="" title="Read more..."`). The title text theoretically could be > assigned as the `alt`, though the tooltip could help in cases of low > color contrast. > - The [https://github.com/WordPress/wordpress- > develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L217 > WP_More command] has a similar pattern for More and Next Page tags, but I > did not find how—or if—that is used. > - [https://github.com/WordPress/wordpress- > develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L142-L151 > Style and script tags] have redundant `title` attributes, matching their > `alt` text (like `alt="<style>" title="<style>"`). However, > the tooltip is the only way to distinguish these two placeholders > visually (unless it's worth replacing the transparent GIF with something > like a > [https://gist.github.com/sabernhardt/8804da31aed02f0c535306bdb2749446 > text-based SVG]). > > Additional `title` attributes are in other (external) TinyMCE-related > scripts: > > - The [https://github.com/WordPress/wordpress- > develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1141 > character map plugin], which is designed for mouse users, has two title > attributes for each character. The script [https://github.com/WordPress > /wordpress- > develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1186 > uses the `td` title later] for the larger preview on the side. Switching > each 'button' div's title to an ARIA label might be a //small// > improvement. (Note that the > [https://github.com/tinymce/tinymce/blob/6d4d3b8fc862253bc756fdaca60254251fa45277/modules/tinymce/src/themes/silver/main/ts/ui/dialog/Collection.ts#L68 > latest charmap plugin] does not have titles anymore.) > - `form_utils.js` has tooltips in [https://github.com/WordPress > /wordpress- > develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/utils/form_utils.js#L20-L21 > getColorPickerHTML()] and [https://github.com/WordPress/wordpress- > develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/utils/form_utils.js#L58-L60 > getBrowserHTML()], but I did not find these two functions in use. > - The [https://github.com/WordPress/wordpress- > develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/textcolor/plugin.js#L194 > text color picker] uses tooltips for each color name, without actual text > (except for the `×` times symbol for 'No color'). New description: Related: #24766 The WordPress script adds `title` attributes to the placeholder images for `style`, `script`, More and Next Page tags. - The [https://github.com/WordPress/wordpress- develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L119 More tag] and [https://github.com/WordPress/wordpress- develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L128 Next Page tag] have an empty `alt` but use a `title` attribute (like `alt="" title="Read more..."`). The title text theoretically could be assigned as the `alt`, though the tooltip could help in cases of low color contrast. - The [https://github.com/WordPress/wordpress- develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L217 WP_More command] has a similar pattern for More and Next Page tags, but I did not find how—or if—that is used. - [https://github.com/WordPress/wordpress- develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L142-L151 Style and script tags] have redundant `title` attributes, matching their `alt` text (like `alt="<style>" title="<style>"`). However, the tooltip is the only way to distinguish these two placeholders visually (unless it's worth replacing the transparent GIF with something like a [https://gist.github.com/sabernhardt/8804da31aed02f0c535306bdb2749446 text-based SVG]). Additional `title` attributes are in other (external) TinyMCE-related scripts. If someone would like to edit and/or replace any of these scripts, please open a separate ticket (for each). - The [https://github.com/WordPress/wordpress- develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1141 character map plugin], which is designed for mouse users, has two title attributes for each character. The script [https://github.com/WordPress /wordpress- develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1186 uses the `td` title later] for the larger preview on the side. Switching each 'button' div's title to an ARIA label might be a //small// improvement. (Note that the [https://github.com/tinymce/tinymce/blob/6d4d3b8fc862253bc756fdaca60254251fa45277/modules/tinymce/src/themes/silver/main/ts/ui/dialog/Collection.ts#L68 latest charmap plugin] does not have titles anymore.) - `form_utils.js` has tooltips in [https://github.com/WordPress/wordpress- develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/utils/form_utils.js#L20-L21 getColorPickerHTML()] and [https://github.com/WordPress/wordpress- develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/utils/form_utils.js#L58-L60 getBrowserHTML()], but I did not find these two functions in use. - The [https://github.com/WordPress/wordpress- develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/textcolor/plugin.js#L194 text color picker] uses tooltips for each color name, without actual text (except for the `×` times symbol for 'No color'). -- Comment: As discussed in today's bug scrub, this ticket should focus on only the `wordpress/plugin.js` placeholder images. Any revision or replacement for the external plugins could have its own ticket. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 17:27:03 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 17:27:03 -0000 Subject: [wp-trac] [WordPress Trac] #62889: Block editor package updates for 6.7.2 In-Reply-To: <050.823cb6d67fd6dce946d37875581a962c@wordpress.org> References: <050.823cb6d67fd6dce946d37875581a962c@wordpress.org> Message-ID: <065.9a009f6d97d939b4690e9148d7c78384@wordpress.org> #62889: Block editor package updates for 6.7.2 --------------------------+--------------------- Reporter: jorbin | Owner: jorbin Type: defect (bug) | Status: closed Priority: normal | Milestone: 6.7.2 Component: Editor | Version: Severity: normal | Resolution: fixed Keywords: has-patch | Focuses: --------------------------+--------------------- Changes (by jorbin): * owner: (none) => jorbin * status: new => closed * resolution: => fixed Comment: In [changeset:"59762" 59762]: {{{ #!CommitTicketReference repository="" revision="59762" Editor: update npm packages for 6.7.1. Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Reviewed-by audrasjb. Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad. Fixes #62889. }}} -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 18:00:33 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 18:00:33 -0000 Subject: [wp-trac] [WordPress Trac] #39242: Add caching to count_user_posts() In-Reply-To: <059.10c47223454844612714cc185b03cfdd@wordpress.org> References: <059.10c47223454844612714cc185b03cfdd@wordpress.org> Message-ID: <074.bb2fddb947abdb9519d5675c018e948e@wordpress.org> #39242: Add caching to count_user_posts() -------------------------------------------------+------------------------- Reporter: johnjamesjacoby | Owner: | spacedmonkey Type: enhancement | Status: assigned Priority: normal | Milestone: 6.8 Component: Users | Version: 3.0 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: rest-api, tests commit | performance -------------------------------------------------+------------------------- Changes (by spacedmonkey): * keywords: has-patch dev-feedback needs-testing has-unit-tests => has- patch needs-testing has-unit-tests commit * owner: whyisjake => spacedmonkey * status: accepted => assigned Comment: This has been approved by multiple core committers. Marking this as ready to commit. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 18:33:39 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 18:33:39 -0000 Subject: [wp-trac] [WordPress Trac] #62904: Formatting Issue in Block Editor After Update Message-ID: <058.c76329735fdade2ca090fc4da7d4bffb@wordpress.org> #62904: Formatting Issue in Block Editor After Update ----------------------------+--------------------------------------- Reporter: hannelevanska6 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Formatting | Version: Severity: minor | Keywords: needs-patch needs-testing Focuses: | ----------------------------+--------------------------------------- After updating to the latest version of WordPress, I noticed a formatting issue in the block editor. Paragraph spacing and alignment seem inconsistent, especially when pasting text. Could this be related to a conflict with themes or plugins? Has anyone else working with Top FMGC Marketing Agencies USA https://pearllemon.com/top-fmcg-marketing-agencies- usa/ faced similar issues when managing content? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 19:08:46 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 19:08:46 -0000 Subject: [wp-trac] [WordPress Trac] #48736: Exclude PNG images from scaling after upload In-Reply-To: <050.ef19373086b764d8b5dc7db100e253ac@wordpress.org> References: <050.ef19373086b764d8b5dc7db100e253ac@wordpress.org> Message-ID: <065.9c6d850f2cacfb5aecde5f8be12865c2@wordpress.org> #48736: Exclude PNG images from scaling after upload -----------------------------------+--------------------- Reporter: azaozz | Owner: azaozz Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.3.1 Component: Upload | Version: Severity: normal | Resolution: fixed Keywords: has-patch fixed-major | Focuses: -----------------------------------+--------------------- Comment (by adamsilverstein): Note: this may have been resolved as a part of #36477 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 19:13:07 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 19:13:07 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.df77ca6f4e106686ba3ebe4d15ccb334@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: dev-feedback needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Comment (by adamsilverstein): @pixlpirate the issue was indeed in the block of code you identified. In https://github.com/WordPress/wordpress-develop/pull/8253 I added a conditional to take the output format into consideration when skipping full sized PNGs. The original logic applies for normal PNG uploads, but is skipped when the output format is not PNG. Can you give the PR a test to verify it fixes the issue on your end? It worked in my testing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 19:13:30 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 19:13:30 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.2e1df9c620089f6a19e2d54a65a12384@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: dev-feedback needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "out-before.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 19:13:37 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 19:13:37 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.1c6fc5561807673cd2dc4e037ac21f93@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: dev-feedback needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Changes (by adamsilverstein): * Attachment "out-after.jpg" added. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 19:38:05 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 19:38:05 -0000 Subject: [wp-trac] [WordPress Trac] #62880: Improve HTML semantics in Site Health Info tables In-Reply-To: <052.d13a189f7ed42708be18a06a5fcf91dd@wordpress.org> References: <052.d13a189f7ed42708be18a06a5fcf91dd@wordpress.org> Message-ID: <067.73650bfc43e016f77b6a1a89fd82fc0b@wordpress.org> #62880: Improve HTML semantics in Site Health Info tables -----------------------------------+---------------------------- Reporter: audrasjb | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.8 Component: Site Health | Version: Severity: normal | Resolution: Keywords: has-patch 2nd-opinion | Focuses: accessibility -----------------------------------+---------------------------- Changes (by sabernhardt): * keywords: has-patch => has-patch 2nd-opinion Comment: I finally looked into the history: #46725 and its [https://wordpress.slack.com/archives/C02RP4X03/p1553876365088000 preceding Slack discussion] indicated a preference for adding `role="presentation"` to treat these simple tables as layout. This needs more discussion before committing a change in another direction. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 19:38:13 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 19:38:13 -0000 Subject: [wp-trac] [WordPress Trac] #46725: Site Health: make sure layout tables have no semantics In-Reply-To: <051.a21b49306a91886cad066132b6fbd58b@wordpress.org> References: <051.a21b49306a91886cad066132b6fbd58b@wordpress.org> Message-ID: <066.f2493c0189e8b59950d63ed964032414@wordpress.org> #46725: Site Health: make sure layout tables have no semantics -------------------------------------------------+------------------------- Reporter: afercia | Owner: afercia Type: defect (bug) | Status: closed Priority: normal | Milestone: 5.2 Component: Site Health | Version: 5.2 Severity: normal | Resolution: fixed Keywords: has-screenshots site-health has- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Comment (by sabernhardt): Follow-up: #62880 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 20:09:49 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 20:09:49 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.629e99c9f26a01d54c2d04573d9679e9@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: dev-feedback needs-testing has- | Focuses: patch | -------------------------------------------------+------------------------- Comment (by pixlpirate): Hi @adamsilverstein I tested the PR and it works like a charm. Thanks again for your help! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 21:29:42 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 21:29:42 -0000 Subject: [wp-trac] [WordPress Trac] #59252: is_front_page returns false when a static blog page has been set. In-Reply-To: <051.ef179dee9a06e4e8782b96b1eca2b9bd@wordpress.org> References: <051.ef179dee9a06e4e8782b96b1eca2b9bd@wordpress.org> Message-ID: <066.6f2d2c86b3254c07da2bd51d89324a75@wordpress.org> #59252: is_front_page returns false when a static blog page has been set. --------------------------+------------------------------ Reporter: neo2k23 | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: Awaiting Review Component: Query | Version: 2.5 Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+------------------------------ Changes (by sabernhardt): * component: General => Query * milestone: => Awaiting Review Old description: > Hi > > I have a question. I do not know if this is a bug or not, but the > behaviour of the is_front_page() function is bit ackward. > > If no static homepage has been set and you call on the home page the > function is_front_page() it returns true. If you call is_home() it also > retruns true. > > However the moment you set a static blog page (not home page) that same > call for is_front_page on the home page returns false, but is_home() > still returns true. > > Is this a bug? It does not seem consistent to me as there is no static > home page set why does is_front_page() return true when no static blog > page has been set and return false the moment a static blog page is set. > > What has the static blog page set in the reading settings to do with the > is_front_page() function? > > Can somebody please explain this to me as it does not make sense given > the description of is_front_page() function? > > Thank you > > see image > > [[Image(https://share.getcloudapp.com/4guXkxZy)]] > > **STEPS TO CREATE THE SAME RESULTS!** > > Tested with wp 6.4 latest trunk build clean wordpress. 20-21 theme and > php 8.0.x > > just add this code to the index.php > > {{{#!php > if ( is_home() ) echo '---------------> this is home.'; > if ( is_front_page() ) echo '---------------> this is frontpage.'; > ?> > }}} > > see image below where i added the php code > > [[Image(https://share.getcloudapp.com/lluXB459)]] > > The complete altered index.php of the 20-21 theme below > > {{{#!php > /** > * The main template file > * > * This is the most generic template file in a WordPress theme > * and one of the two required files for a theme (the other being > style.css). > * It is used to display a page when nothing more specific matches a > query. > * E.g., it puts together the home page when no home.php file exists. > * > * @link https://developer.wordpress.org/themes/basics/template- > hierarchy/ > * > * @package WordPress > * @subpackage Twenty_Twenty_One > * @since Twenty Twenty-One 1.0 > */ > > get_header(); ?> > > '', false ) ) ) : ?> > > > if ( is_home() ) echo '---------------> this is home.'; > if ( is_front_page() ) echo '---------------> this is frontpage.'; > ?> > > if ( have_posts() ) { > > // Load posts loop. > while ( have_posts() ) { > the_post(); > > get_template_part( 'template-parts/content/content', > get_theme_mod( 'display_excerpt_or_full_post', 'excerpt' ) ); > } > > // Previous/next page navigation. > twenty_twenty_one_the_posts_navigation(); > > } else { > > // If no content, include the "No posts found" template. > get_template_part( 'template-parts/content/content-none' ); > > } > > get_footer(); > > }}} New description: Hi I have a question. I do not know if this is a bug or not, but the behaviour of the `is_front_page()` function is bit ackward. If no static homepage has been set and you call on the home page the function `is_front_page()` it returns true. If you call `is_home()` it also returns true. However the moment you set a static blog page (not home page) that same call for `is_front_page` on the home page returns false, but `is_home()` still returns true. Is this a bug? It does not seem consistent to me as there is no static home page set why does `is_front_page()` return true when no static blog page has been set and return false the moment a static blog page is set. What has the static blog page set in the reading settings to do with the `is_front_page()` function? Can somebody please explain this to me as it does not make sense given the description of `is_front_page()` function? Thank you see image [[Image(https://share.getcloudapp.com/4guXkxZy)]] **STEPS TO CREATE THE SAME RESULTS!** Tested with wp 6.4 latest trunk build clean wordpress. 20-21 theme and php 8.0.x just add this code to the `index.php` {{{#!php this is home.'; if ( is_front_page() ) echo '---------------> this is frontpage.'; ?> }}} see image below where i added the php code [[Image(https://share.getcloudapp.com/lluXB459)]] The complete altered index.php of the 20-21 theme below {{{#!php this is home.'; if ( is_front_page() ) echo '---------------> this is frontpage.'; ?> WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 22:41:49 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 22:41:49 -0000 Subject: [wp-trac] [WordPress Trac] #48879: Changing Site Admin Email Assumes Username and Who Took the Action (which may be incorrect) In-Reply-To: <055.1b81494cae6182d64bd06e6e7dbaa0fa@wordpress.org> References: <055.1b81494cae6182d64bd06e6e7dbaa0fa@wordpress.org> Message-ID: <070.b492b7c86ae3fff963a8b13426a46649@wordpress.org> #48879: Changing Site Admin Email Assumes Username and Who Took the Action (which may be incorrect) -------------------------------------------------+------------------------- Reporter: MadtownLems | Owner: | johnbillion Type: enhancement | Status: reviewing Priority: normal | Milestone: 6.8 Component: Users | Version: 5.3 Severity: minor | Resolution: Keywords: good-first-bug has-patch dev- | Focuses: multisite feedback | -------------------------------------------------+------------------------- Changes (by johnbillion): * owner: (none) => johnbillion * status: new => reviewing * milestone: Future Release => 6.8 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 22:41:55 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 22:41:55 -0000 Subject: [wp-trac] [WordPress Trac] #62835: Remove title attributes from author link functions In-Reply-To: <055.11f6fedc8818f923405c82cd932147f5@wordpress.org> References: <055.11f6fedc8818f923405c82cd932147f5@wordpress.org> Message-ID: <070.5f67a314ea79681c9af7f337c6fb1d7d@wordpress.org> #62835: Remove title attributes from author link functions -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: accepted Priority: normal | Milestone: 6.8 Component: Users | Version: Severity: normal | Resolution: Keywords: title-attribute has-patch has-unit- | Focuses: tests | accessibility -------------------------------------------------+------------------------- Comment (by audrasjb): Personally, I'd go with Option 2 (PR 8182). Option 3 (PR 8183) looks way overkill to me :) -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Tue Feb 4 22:46:29 2025 From: noreply at wordpress.org (WordPress Trac) Date: Tue, 04 Feb 2025 22:46:29 -0000 Subject: [wp-trac] [WordPress Trac] #62861: Consider removing title attributes from Classic Editor scripts In-Reply-To: <055.283b2c3cb0e427958b53a2a9a1620a6c@wordpress.org> References: <055.283b2c3cb0e427958b53a2a9a1620a6c@wordpress.org> Message-ID: <070.fa51ea094faede17b38b684502ba73d3@wordpress.org> #62861: Consider removing title attributes from Classic Editor scripts -------------------------------------------------+------------------------- Reporter: sabernhardt | Owner: joedolson Type: defect (bug) | Status: accepted Priority: low | Milestone: 6.8 Component: TinyMCE | Version: Severity: normal | Resolution: Keywords: title-attribute 2nd-opinion needs- | Focuses: patch | accessibility -------------------------------------------------+------------------------- Changes (by audrasjb): * keywords: title-attribute 2nd-opinion => title-attribute 2nd-opinion needs-patch -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 01:20:08 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 01:20:08 -0000 Subject: [wp-trac] [WordPress Trac] #62903: permission_callback should be called before validate_callback in REST API In-Reply-To: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> References: <051.af70cf4d22ebdf033e2d22af3c7ce958@wordpress.org> Message-ID: <066.a3d87cb8eacffd04c63cf67761e66c27@wordpress.org> #62903: permission_callback should be called before validate_callback in REST API -----------------------------+------------------------------ Reporter: donjajo | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: REST API | Version: trunk Severity: normal | Resolution: Keywords: has-patch close | Focuses: rest-api -----------------------------+------------------------------ Changes (by dd32): * keywords: has-patch => has-patch close Comment: I disagree personally, as in your example the `validation` callback is doing a permission check rather than validation. The intention is that only valid inputs then proceed to check if the user has access (ie. Can't determine if the user can edit the post, if no valid post ID is provided), and only if the validation and permission checks pass does it pass to the callback. While I understand your opinion of the order of operations, as you've noted, that's not something that can be changed due to back-compat and existing plugins. So even if the current behaviour was wrong (which I don't believe it is) it couldn't be changed. If you don't agree with the behaviour of the callbacks, you can skip using `validation_callback` and/or `permission_callback` and instead perform all validation and permission checking within the `callback`. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 05:47:44 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 05:47:44 -0000 Subject: [wp-trac] [WordPress Trac] #62769: Saving Post without Title and Content In-Reply-To: <051.6397b1d7e3aec571374f6739f135acd1@wordpress.org> References: <051.6397b1d7e3aec571374f6739f135acd1@wordpress.org> Message-ID: <066.8a250c13a8e97dd342137f25e80e13e2@wordpress.org> #62769: Saving Post without Title and Content -------------------------------+------------------------------ Reporter: tristup | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Posts, Post Types | Version: 6.7.1 Severity: normal | Resolution: Keywords: | Focuses: administration -------------------------------+------------------------------ Comment (by niravsherasiya7707): Hello @abcd95, I looked into this on my end and found that the Gutenberg editor allows publishing a post/page without a title. Could you confirm if this is the expected behavior? [https://vimeo.com/1053634062/18e8ba7800] -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 06:34:03 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 06:34:03 -0000 Subject: [wp-trac] [WordPress Trac] #36270: Allow filtering of the final HTML output of media related shortcodes In-Reply-To: <052.d64003848f387f52e8b663ae116e46aa@wordpress.org> References: <052.d64003848f387f52e8b663ae116e46aa@wordpress.org> Message-ID: <067.f90cc931b687a67805a6a94d62bf353c@wordpress.org> #36270: Allow filtering of the final HTML output of media related shortcodes -------------------------+------------------------------ Reporter: gnotaras | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: Media | Version: 4.7.2 Severity: normal | Resolution: Keywords: needs-patch | Focuses: -------------------------+------------------------------ Comment (by sahilgidwani): Hi @gnotaras , You can use existing WordPress filters to modify the output without overriding the entire function. The two key filters you need to use are: 1. `img_caption_shortcode` – Filters the output of the `caption` shortcode. 2. `post_gallery` – Filters the output of the `gallery` shortcode. === Example: Modifying the Caption Shortcode Output === To wrap `

` with an extra `

`: {{{#!php '; $html .= sprintf( '

%s%s', $class, do_shortcode($content), $caption_id, $caption ); $html .= '

'; return $html; }, 10, 3); }}} === Example: Modifying the Gallery Shortcode Output === To wrap the `gallery` with `

`: {{{#!php ' . gallery_shortcode($attr) . '

'; return $output; }, 10, 3); }}} This way, you avoid overriding core functions and can customize media- related shortcodes dynamically. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 06:59:45 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 06:59:45 -0000 Subject: [wp-trac] [WordPress Trac] #62683: Keyword Density Checker In-Reply-To: <053.adfa953b69370a30ca0843c70e35ee04@wordpress.org> References: <053.adfa953b69370a30ca0843c70e35ee04@wordpress.org> Message-ID: <068.2ac33ea504e3d862d0cd77de7e3c73e5@wordpress.org> #62683: Keyword Density Checker -----------------------------+------------------------------ Reporter: baskorodj | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -----------------------------+------------------------------ Comment (by sahilgidwani): Hi @baskorodj ! Thank you for sharing your thoughts on keyword optimization in WordPress. You're absolutely right—proper keyword usage is crucial for SEO, and having a built-in keyword counter would make the process much more convenient. While WordPress doesn’t currently offer a native keyword counter, there are several great plugins that can help: 1. **[https://wordpress.org/plugins/wordpress-seo/ Yoast SEO]** – This plugin provides real-time keyword analysis and readability checks. 2. **[https://wordpress.org/plugins/seo-by-rank-math/ Rank Math]** – Offers advanced keyword tracking, optimization suggestions, and readability scores. 3. **[https://wordpress.org/plugins/wp-seopress/ SEOPress]** – A powerful alternative with keyword analysis and content optimization features. These tools can help ensure your articles meet SEO best practices while avoiding keyword stuffing 😊 -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 08:34:06 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 08:34:06 -0000 Subject: [wp-trac] [WordPress Trac] #61219: Simplify add_new_item labels for core post types In-Reply-To: <055.0032b883e4397fca04e505aa0e22beab@wordpress.org> References: <055.0032b883e4397fca04e505aa0e22beab@wordpress.org> Message-ID: <070.023fef2d744ca6f20df5f771f005f26b@wordpress.org> #61219: Simplify add_new_item labels for core post types -------------------------------------+------------------------------------- Reporter: jameskoster | Owner: audrasjb Type: enhancement | Status: assigned Priority: normal | Milestone: 6.8 Component: Administration | Version: Severity: normal | Resolution: Keywords: 2nd-opinion has-patch | Focuses: ui, accessibility, early has-unit-tests | administration -------------------------------------+------------------------------------- Comment (by jdy68): It's a great way to simplify the interface. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 09:27:42 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 09:27:42 -0000 Subject: [wp-trac] [WordPress Trac] #61219: Simplify add_new_item labels for core post types In-Reply-To: <055.0032b883e4397fca04e505aa0e22beab@wordpress.org> References: <055.0032b883e4397fca04e505aa0e22beab@wordpress.org> Message-ID: <070.a4eb9d2aaa5f69aa75850f84e7c6efbf@wordpress.org> #61219: Simplify add_new_item labels for core post types -------------------------------------+------------------------------------- Reporter: jameskoster | Owner: audrasjb Type: enhancement | Status: assigned Priority: normal | Milestone: 6.8 Component: Administration | Version: Severity: normal | Resolution: Keywords: 2nd-opinion has-patch | Focuses: ui, accessibility, early has-unit-tests | administration -------------------------------------+------------------------------------- Comment (by beryldlg): I totally agree to get rid of this unnecessarily verbose. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 09:41:06 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 09:41:06 -0000 Subject: [wp-trac] [WordPress Trac] #62904: Mix Rows and Columns Without Grouping Message-ID: <053.4c0bbaa9419813fc6db298544fb43fbb@wordpress.org> #62904: Mix Rows and Columns Without Grouping -------------------------+----------------------------- Reporter: prosanjit | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: | -------------------------+----------------------------- Hi there, I’d like to request an enhancement for the Gutenberg block editor regarding column customization. Currently, in order to mix rows and columns within the same layout, users are required to create separate columns and row blocks and then group them. However, this approach can be restrictive and often results in unnecessary complexity when designing flexible layouts. Requested Feature: Introduce a built-in row + column mixed block that allows users to seamlessly place rows inside columns and vice versa. Enable free positioning of individual blocks inside a column without rigid structure limitations. Improve drag-and-drop flexibility for positioning content elements within both rows and columns. Reduce the need for grouping blocks manually to maintain structured designs. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 10:41:10 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 10:41:10 -0000 Subject: [wp-trac] [WordPress Trac] #13459: Conflict between post and page slugs/permalinks when permalink setting is set to /%postname%/ In-Reply-To: <056.ab0c26cb7cfc7d43db5ebede27ea6cdb@wordpress.org> References: <056.ab0c26cb7cfc7d43db5ebede27ea6cdb@wordpress.org> Message-ID: <071.0c5a66adb70f058d3c9317efef921f1a@wordpress.org> #13459: Conflict between post and page slugs/permalinks when permalink setting is set to /%postname%/ -------------------------------------------------+------------------------- Reporter: jamescollins | Owner: petitphp Type: defect (bug) | Status: assigned Priority: normal | Milestone: Future | Release Component: Permalinks | Version: 2.9.2 Severity: normal | Resolution: Keywords: has-patch needs-testing has-unit- | Focuses: tests | -------------------------------------------------+------------------------- Comment (by sukhendu2002): Hi @audrasjb, I've opened a PR to add some tests. Could you please take a look? Let me know if any improvements are needed. Thanks! -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 10:42:46 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 10:42:46 -0000 Subject: [wp-trac] [WordPress Trac] #62904: Mix Rows and Columns Without Grouping In-Reply-To: <053.4c0bbaa9419813fc6db298544fb43fbb@wordpress.org> References: <053.4c0bbaa9419813fc6db298544fb43fbb@wordpress.org> Message-ID: <068.7c91890303da4f702cb234a61f3572ff@wordpress.org> #62904: Mix Rows and Columns Without Grouping -------------------------+------------------------------ Reporter: prosanjit | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Resolution: Keywords: | Focuses: -------------------------+------------------------------ Comment (by shahabdev): Great, This would make structured designs more intuitive while minimizing unnecessary complexity. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 10:50:15 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 10:50:15 -0000 Subject: [wp-trac] [WordPress Trac] #62905: Prevent registration bypass when user registration is disabled Message-ID: <059.6b90c69a36acb80470cb53175ee50530@wordpress.org> #62905: Prevent registration bypass when user registration is disabled ------------------------------------+----------------------------- Reporter: jonathancaron02 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Keywords: Focuses: | ------------------------------------+----------------------------- == Fix: Prevent registration bypass when user registration is disabled == === Problem Description: === After extensive testing, I discovered a potential vulnerability in the default WordPress registration form. This issue occurs even when user registration is disabled (`users_can_register` set to `0`). It allows spammers to bypass the restriction and create accounts, resulting in spam registrations and automated email notifications. === Steps to Reproduce: === 1. **Send a POST request** to `/wp-login.php?action=register`. 2. **Headers:** * Content-Type: `application/x-www-form-urlencoded` 3. **Body** (as `x-www-form-urlencoded`): {{{ user_login=testuser user_email=testuser at example.com user_pass=TestPassword123 wp-submit=Register redirect_to= }}} 4. **Response:** If the same request is repeated, an error is displayed indicating that the username and email are already in use. 5. **Redirect Behavior:** The bypass works only when redirect following is disabled. === Root Cause: === The `wp-login.php` file does not validate whether the `users_can_register` option is disabled when processing registration requests. === Solution: === This patch introduces a check to block access to the registration process if the `users_can_register` option is set to `0`. This ensures that no new accounts can be created through this endpoint unless registration is explicitly enabled. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 11:22:00 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 11:22:00 -0000 Subject: [wp-trac] [WordPress Trac] #62905: Prevent registration bypass when user registration is disabled In-Reply-To: <059.6b90c69a36acb80470cb53175ee50530@wordpress.org> References: <059.6b90c69a36acb80470cb53175ee50530@wordpress.org> Message-ID: <074.57beeb979ed9958cd066f55b327e18a9@wordpress.org> #62905: Prevent registration bypass when user registration is disabled ------------------------------------+------------------------------ Reporter: jonathancaron02 | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: Login and Registration | Version: Severity: normal | Resolution: Keywords: has-patch close | Focuses: ------------------------------------+------------------------------ Changes (by swissspidy): * keywords: has-patch => has-patch close Comment: Hi there and welcome to WordPress Trac! Since you've started your message with " I discovered a potential vulnerability", think twice about sharing such things publicly. Imagine the damage you could cause with that! Next time, please learn more about [https://make.wordpress.org/core/handbook/testing/reporting-security- vulnerabilities/ reporting potential security vulnerabilities] **responsibly and privately**. With that said, I cannot confirm your report. There is already a redirect in place if registration is disabled: https://github.com/WordPress/wordpress- develop/blob/7d10dd7b0fde2a782395887c2d66439481440f9b/src/wp- login.php#L1102-L1118 You might be using a plugin or theme that alters the standard flow on the login page that causes this behavior. In that case you should report it to that plugin or theme — again, responsibly and privately. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 12:33:39 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 12:33:39 -0000 Subject: [wp-trac] [WordPress Trac] #61219: Simplify add_new_item labels for core post types In-Reply-To: <055.0032b883e4397fca04e505aa0e22beab@wordpress.org> References: <055.0032b883e4397fca04e505aa0e22beab@wordpress.org> Message-ID: <070.1d186cc0b7c4604b2deaa13d77cef43a@wordpress.org> #61219: Simplify add_new_item labels for core post types -------------------------------------+------------------------------------- Reporter: jameskoster | Owner: audrasjb Type: enhancement | Status: assigned Priority: normal | Milestone: 6.8 Component: Administration | Version: Severity: normal | Resolution: Keywords: 2nd-opinion has-patch | Focuses: ui, accessibility, early has-unit-tests | administration -------------------------------------+------------------------------------- Comment (by fxbenard): Good idea to remove this unnecessary "new" word -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 13:59:30 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 13:59:30 -0000 Subject: [wp-trac] [WordPress Trac] #62641: Navigation block doesn't work on mobile In-Reply-To: <055.43642991e7fe46d1a495a4f53fe25b15@wordpress.org> References: <055.43642991e7fe46d1a495a4f53fe25b15@wordpress.org> Message-ID: <070.96df3e6dadcab6b4a27b44ae578b51cb@wordpress.org> #62641: Navigation block doesn't work on mobile -------------------------------------------+------------------------- Reporter: ramizmanked | Owner: (none) Type: defect (bug) | Status: closed Priority: normal | Milestone: Component: Interactivity API | Version: 6.7.1 Severity: normal | Resolution: duplicate Keywords: needs-patch reporter-feedback | Focuses: javascript -------------------------------------------+------------------------- Comment (by harrow): I can't believe this choice from WP to ignore user that can't afford a recent device or just choose to maintain older iPhone alive. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 15:02:02 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 15:02:02 -0000 Subject: [wp-trac] [WordPress Trac] #62900: PNG original image not affected by conversion filter In-Reply-To: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> References: <054.f52b4acc4114f4c6a8bdcf0d662e3caa@wordpress.org> Message-ID: <069.a362d71ca0a796a08306eeb23a3e0413@wordpress.org> #62900: PNG original image not affected by conversion filter -------------------------------------------------+------------------------- Reporter: pixlpirate | Owner: | adamsilverstein Type: defect (bug) | Status: reviewing Priority: normal | Milestone: Awaiting | Review Component: Media | Version: 6.7.1 Severity: normal | Resolution: Keywords: dev-feedback has-patch needs-unit- | Focuses: tests | -------------------------------------------------+------------------------- Changes (by adamsilverstein): * keywords: dev-feedback needs-testing has-patch => dev-feedback has-patch needs-unit-tests Comment: @pixlpirate Thanks for confirming. It would be nice to add a unit test here to validate/enforce the fix before committing. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 15:30:09 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 15:30:09 -0000 Subject: [wp-trac] [WordPress Trac] #62906: Allow :focus-visible pseudo-selector to be set in theme.json Message-ID: <049.9a7ea690450ec1fe13e1092cb53ce324@wordpress.org> #62906: Allow :focus-visible pseudo-selector to be set in theme.json ---------------------------+----------------------------- Reporter: huubl | Owner: (none) Type: enhancement | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: Severity: normal | Keywords: Focuses: accessibility | ---------------------------+----------------------------- -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 16:30:58 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 16:30:58 -0000 Subject: [wp-trac] [WordPress Trac] #62550: Missing "submit" button - bad accessibility In-Reply-To: <052.301e67ac49489a5e2979ea0fc1bd0274@wordpress.org> References: <052.301e67ac49489a5e2979ea0fc1bd0274@wordpress.org> Message-ID: <067.b52181c7b4075aab8baf59ccb819365a@wordpress.org> #62550: Missing "submit" button - bad accessibility -------------------------------------+---------------------------- Reporter: kkmuffme | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.8 Component: Administration | Version: Severity: minor | Resolution: Keywords: has-patch needs-testing | Focuses: accessibility -------------------------------------+---------------------------- Changes (by krupajnanda): * keywords: has-patch => has-patch needs-testing Comment: This ticket was discussed during the Test team bug scrub, and we found that it needs more testing to perform. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 17:17:32 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 17:17:32 -0000 Subject: [wp-trac] [WordPress Trac] #56992: The Loop displays incorrect data for queries started with `fields => 'id=>parent'`. In-Reply-To: <057.36fc1a3d701c06419f5be1ce40940d8f@wordpress.org> References: <057.36fc1a3d701c06419f5be1ce40940d8f@wordpress.org> Message-ID: <072.3cc0b1cb138cf2e04bf539ab78a70630@wordpress.org> #56992: The Loop displays incorrect data for queries started with `fields => 'id=>parent'`. -------------------------------------------------+------------------------- Reporter: peterwilsoncc | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: 6.8 Component: Query | Version: 3.1 Severity: normal | Resolution: Keywords: has-patch has-unit-tests dev- | Focuses: feedback 2nd-opinion | -------------------------------------------------+------------------------- Changes (by SirLouen): * keywords: has-patch has-unit-tests => has-patch has-unit-tests dev- feedback 2nd-opinion Comment: @juzar I've been reviewing the code and testing your approach But @oglekler raised an interesting concern I'm looking into right now: The test seems to be failing because it is expected to work with the minimal data structure, but your implementation seems to be trying to convert it to full post objects, creating unnecessary overhead and potentially changing the expected data structure. As you said, in the original test, you can see on one side, you populated the child post with full data, on the other side, just the bare minimal data was retrieved, and the rest was fed with default data as you pointed out in your first post in the test. This is why the test is failing, but it should fail that specific test as expected, as `next_post()` should not retrieve full data by default. I need a 2nd opinion on this, maybe @joemcgill? -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 17:30:31 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 17:30:31 -0000 Subject: [wp-trac] [WordPress Trac] #62755: Allow template duplication + concept of active templates In-Reply-To: <052.da7c7bcce634dd00a1adf0791b1c8086@wordpress.org> References: <052.da7c7bcce634dd00a1adf0791b1c8086@wordpress.org> Message-ID: <067.698eb32c441be32c7d7031d58b8dab5f@wordpress.org> #62755: Allow template duplication + concept of active templates --------------------------+----------------------------- Reporter: ellatrix | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Future Release Component: Editor | Version: trunk Severity: normal | Resolution: Keywords: has-patch | Focuses: --------------------------+----------------------------- Changes (by Mamaduka): * milestone: 6.8 => Future Release -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 18:12:19 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 18:12:19 -0000 Subject: [wp-trac] [WordPress Trac] #62907: 6.7 broke accordion styles for themes/plugins using `do_accordion_sections()` Message-ID: <051.817ec3f1f6c5308f97cf1479335979ba@wordpress.org> #62907: 6.7 broke accordion styles for themes/plugins using `do_accordion_sections()` --------------------------+----------------------------- Reporter: mboynes | Owner: (none) Type: defect (bug) | Status: new Priority: normal | Milestone: Awaiting Review Component: General | Version: 6.7 Severity: normal | Keywords: Focuses: | --------------------------+----------------------------- Core provides [https://core.trac.wordpress.org/browser/tags/6.7.1/src/wp- admin/includes/template.php#L1537 a meta box function, do_accordion_sections()], which will helpfully render meta boxes for a screen as collapsible accordions. WordPress 6.7 removed some CSS classes (stemming from #42002, I believe) from `common.css`, and now any plugin or theme using `do_accordion_sections()` is rendering partially-styled (but still functional) accordions. -- Ticket URL: WordPress Trac WordPress publishing platform From noreply at wordpress.org Wed Feb 5 18:18:56 2025 From: noreply at wordpress.org (WordPress Trac) Date: Wed, 05 Feb 2025 18:18:56 -0000 Subject: [wp-trac] [WordPress Trac] #62503: Add speculative loading support In-Reply-To: <052.50c58315cb3ee9a4448856673fa131ff@wordpress.org> References: <052.50c58315cb3ee9a4448856673fa131ff@wordpress.org> Message-ID: <067.fe8f44e66a1c663474796b46ca92cf29@wordpress.org> #62503: Add speculative loading support --------------------------------------+-------------------------- Reporter: flixos90 | Owner: flixos90 Type: feature request | Status: assigned Priority: high | Milestone: 6.8 Component: General | Version: Severity: normal | Resolution: Keywords: has-patch has-unit-tests | Focuses: performance --------------------------------------+-------------------------- Comment (by desrosj): I chatted with @flixos90 a bit today after going through and reviewing everything. here are a few thoughts! - Overall, I'm convinced that this will be beneficial the web as a whole despite the API still being only a draft, and despite only Chromium-based browsers supporting the feature. The market share for those browsers is over 80%, so the majority of users would benefit. The fact that other providers (Cloudflare,a few plugins, etc.) have implemented this also speaks to the overall confidence of the API in the wild. - I've been trying to think through how this could be abused either intentionally or unintentionally. If site owner has code that switches the `eagerness` to `immediate` or `eager`, it's possible that they inadvertently cause URLs from other plugins to be prefetched or prerendered. These links could be delete user links, subscribe links, etc. Another scenario could be where a plugin filters the list of exclusions and accidentally does not perform a merge and replaces exclude rules from other plugins. - The feature as proposed turns off the feature for all logged in users. I think that addresses these concerns even if the second scenario causes something to perform badly (every filter has the potential to be misused), but I'm wondering if it makes sense to prevent this from being turned on for logged-in users. - I'm also wondering if it makes sense to support `immediate` as an eagerness value at all. Perhaps for the initial implementation `immediate` can only be supported for URL lists? Last question I have that @flixos90 was going to look into. Can we confirm that if there are multiple instances of `