[wp-trac] [WordPress Trac] #64380: Widgets sidebar and position can't be changed with accessibility mode enabled

[WordPress Trac]

#64380: Widgets sidebar and position can't be changed with accessibility mode
enabled
--------------------------+----------------------------
 Reporter:  vybiral       |       Owner:  joedolson
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  6.9.1
Component:  Widgets       |     Version:  6.9
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  accessibility
--------------------------+----------------------------
Changes (by wildworks):

 * keywords:  has-patch =>


Comment:

 This issue is caused by a variable name (`$sidebar_id`) collision caused
 by [61187].

 [https://github.com/WordPress/wordpress-
 develop/blob/eda8d9d27b129ac48143af7d9c2df595dc172e44/src/wp-admin
 /widgets-form.php#L138 The sidebar selected by the user] is overwritten
 each time [https://github.com/WordPress/wordpress-
 develop/blob/eda8d9d27b129ac48143af7d9c2df595dc172e44/src/wp-admin
 /widgets-form.php#L190 this loop] runs, resulting in widgets being
 unintentionally added to the last sidebar.

 I've submitted [https://github.com/WordPress/wordpress-develop/pull/10633
 PR 10633], but if you have any ideas for better variable names, please let
 me know.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64380#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform