[wp-trac] [WordPress Trac] #28059: Inline image attachments with wp_mail()

[WordPress Trac]

#28059: Inline image attachments with wp_mail()
-------------------------------------------------+-------------------------
 Reporter:  jesin                                |       Owner:  SirLouen
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.9
Component:  Mail                                 |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-test-info needs-dev-   |     Focuses:
  note needs-unit-tests                          |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  has-patch has-test-info needs-dev-note has-unit-tests => has-
     patch has-test-info needs-dev-note needs-unit-tests
 * owner:  (none) => SirLouen
 * status:  new => assigned


Comment:

 @TimothyBlynJacobs I get your point, but I'm not confident where do you
 think it would be best to put the inline docs for this? I've added some
 docs to both the function and the filter, check if this is what you mean.

 > Should we allow providing a cid in the embeds parameter? Perhaps as the
 array key?

 This is why I introduced the filter hook, you can edit there the CID you
 want if you are willing to modify this without having to modify the
 signature.

 What I'm noticing now, is that `$embed_path` is being sent twice. I'm
 going to fix this.

 And definitely I think that this needs better unit tests.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/28059#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform