[wp-trac] [WordPress Trac] #38044: Make seems_utf8() RFC 3629 compliant.

[WordPress Trac]

#38044: Make seems_utf8() RFC 3629 compliant.
--------------------------+-----------------------------
 Reporter:  gitlost       |       Owner:  dmsnell
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  Future Release
Component:  Formatting    |     Version:  1.2.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:26 dmsnell]:
 > In other words, the tests are written in such a way that plenty of bugs
 can be added to the function without breaking the tests, and the actual
 intended behaviors remain unclear, so the tests aren’t clearly asserting
 anything in particular.

 From what I'm seeing, they run the function on several examples of both
 UTF-8 and non-UTF-8 strings, and assert that the expected result is
 correct. That might not be super comprehensive, but I think that's a good
 indicator the tests should ideally be improved and expanded rather than
 removed altogether. Curious to see what others think :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38044#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform