[wp-trac] [WordPress Trac] #54416: Some WordPress generated emails escape special chars in the email address while other emails do not.

[WordPress Trac]

#54416: Some WordPress generated emails escape special chars in the email address
while other emails do not.
-------------------------------------------------+-------------------------
 Reporter:  ltuspe                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Mail                                 |     Version:  5.8
 Severity:  major                                |  Resolution:
 Keywords:  good-first-bug has-test-info needs-  |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by SirLouen):

 * keywords:  good-first-bug has-test-info has-patch => good-first-bug has-
     test-info needs-patch


Comment:

 Hey @kush123
 Sorry for late reviewing this patch but I've been a little busy lately in
 GB
 This said, I hope [https://core.trac.wordpress.org/ticket/54416#comment:1
 you read my report]. Specially the last paragraph. Basically what you have
 done in this ticket is exactly what I was advising against.

 I don't really like this solution. We have to go a little deeper into the
 problem. As I said there are two main problems:
 1. Why `add_magic_quotes` is being added to the whole `$user` array?
 2. Why in `send_confirmation_on_profile_email` the form post result is
 coming slashed?

 Could we sort any of these two **before** happening instead of fixing them
 after happening?

 If you have some time, please review this patch again from scratch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54416#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform