[wp-trac] [WordPress Trac] #63351: Incorrect usage of esc_attr() for URL escaping

[WordPress Trac]

#63351: Incorrect usage of esc_attr() for URL escaping
-------------------------------------+-------------------------------------
 Reporter:  hardik2221               |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-testing-   |     Focuses:  administration,
  info                               |  coding-standards
-------------------------------------+-------------------------------------
Changes (by dilipbheda):

 * keywords:  has-patch => has-patch has-testing-info
 * focuses:  coding-standards => administration, coding-standards


Comment:

 == Test Report
 === Description
 I tested both patches, and they seem to be working well with the following
 test scenarios:

 1. A valid HTTP URL
 2. A `#` symbol and an empty string
 3. A `#target_element_id`

 Patch tested:
 1) https://core.trac.wordpress.org/attachment/ticket/63351/63351.2.patch
 2) https://core.trac.wordpress.org/attachment/ticket/63351/63351.patch

 === Environment
 - WordPress: 6.9-alpha-60093-src
 - PHP: 8.2.27
 - Server: nginx/1.27.3
 - Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.27)
 - Browser: Chrome 135.0.0.0
 - OS: Linux
 - Theme: Twenty Twenty-One 2.5
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0

 === Actual Results
 1.  ✅ Issue resolved with patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63351#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform