[wp-trac] [WordPress Trac] #63185: Function _load_textdomain_just_in_time was called incorrectly in WP v6.8-RC1

WordPress Trac noreply at wordpress.org
Wed Apr 23 17:11:26 UTC 2025


#63185: Function _load_textdomain_just_in_time was called incorrectly in WP
v6.8-RC1
---------------------------+----------------------
 Reporter:  jorgedelcampo  |       Owner:  (none)
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  I18N           |     Version:  trunk
 Severity:  normal         |  Resolution:  wontfix
 Keywords:                 |     Focuses:
---------------------------+----------------------

Comment (by kevinB):

 > That would just cause early user-facing messages to not be properly
 translated again, which is the whole issue this notice aims to address.

 @swissspidy In this case of function wp_schedule_event(), the string in
 question is not even used. It calls wp_get_schedules(), but only accesses
 the interval value. However, the 'cron_schedules' filter does not provide
 that context. So in reality, there was never a user-facing string going
 untranslated.

 You might think that is an edge case to disregard, but what is the harm in
 just allowing the functional effect of an actual untranslated string be
 the signal that triggers users to report an issue. Then if there is a real
 concern, it will naturally be reported to the correct support channel,
 followed by another plugin author being notified if needed.

 Your early auto-registration of plugin textdomains is instead forcing me
 to bear the burden of explaining and troubleshooting other plugins' issues
 even if it there is no real impact on my own users. At minimum, instead of
 shrugging off the potential for false blame about who is doing_it_wrong,
 please consider rephrasing the PHP Notice to communicate some uncertainty
 about what has caused this plugin's translation call to happen too early.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63185#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list