[wp-trac] [WordPress Trac] #63275: Twenty Fourteen: Sticky menu problem

[WordPress Trac]

#63275: Twenty Fourteen: Sticky menu problem
----------------------------+-----------------------------
 Reporter:  SergeyKovalets  |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Future Release
Component:  Bundled Theme   |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui
----------------------------+-----------------------------
Changes (by sabernhardt):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => Future Release


Comment:

 I also considered setting a `height` on the menu or decreasing the `line-
 height` on each `li`, but I do not think either of those CSS options are
 appropriate for all sites either.

 Maybe editing the script instead would be better:
 {{{
 if ( mastheadHeight >= 49 ) {
         body.removeClass( 'masthead-fixed' );
 }
 }}}

 The `else` condition of the header image part of the script removes the
 `masthead-fixed` when the header height is greater than or equal to 49
 pixels, and replacing 48 a few lines earlier would make them consistent.
 (We probably should also check the 781 width because it does not match 783
 in the CSS, but not necessarily on this ticket.)

 Setup steps:

 1. Activate Twenty Fourteen.
 2. Install one of these languages: Armenian, Azerbaijani, Belarusian,
 Bengali (Bangladesh), Bosnian, Bulgarian, Czech, Esperanto, Georgian,
 Greek, Hebrew, Khmer, Mongolian, Myanmar (Burmese), Russian, Serbian,
 Sinhala, Slovenian, Tamil (Sri Lanka), Telugu, Turkish, or Ukrainian.
 3. Go to the Updates page and update translations.
 4. Add items to the primary menu.
 5. Visit one of the pages included in the primary menu.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63275#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform