[wp-trac] [WordPress Trac] #63220: Documentation for embed_oembed_html misleading

[WordPress Trac]

#63220: Documentation for embed_oembed_html misleading
------------------------------------+-----------------------------
 Reporter:  apermo                  |       Owner:  SergeyBiryukov
     Type:  defect (bug)            |      Status:  reopened
 Priority:  normal                  |   Milestone:  6.8
Component:  Embeds                  |     Version:  2.9
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  docs
------------------------------------+-----------------------------

Comment (by apermo):

 That confusion is exactly what lead me and @xate to find this. We were
 discussing which type hints we needed and since PHPdoc was suggesting that
 `false` could be a valid value, we were about to make our code more
 complicated that it needed to be.
 So fixing this, will potentially have developers create less complex code
 on their side. I'd highly welcome it in 6.8.

 Since it is only a PHPdoc fix, it has no potential of breaking the update,
 I don't see any reason to hold it back till 6.9.
 If it is to short of a notice for 6.8, maybe it could be considered for
 6.8.1?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63220#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform