[wp-trac] [WordPress Trac] #61689: Admin menu: submenu link groups have less top padding than bottom padding (was: On responsive device the padding above and below the Dashboad sidebar are not the same)

[WordPress Trac]

#61689: Admin menu: submenu link groups have less top padding than bottom padding
---------------------------------------------+-----------------------
 Reporter:  trushaamin                       |       Owner:  (none)
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  normal                           |   Milestone:  6.8
Component:  Administration                   |     Version:  3.8
 Severity:  minor                            |  Resolution:
 Keywords:  needs-design-feedback has-patch  |     Focuses:  ui, css
---------------------------------------------+-----------------------
Changes (by sabernhardt):

 * component:  Menus => Administration
 * severity:  normal => minor


Comment:

 > it may be aesthetically equivalent

 FWIW, I like that the current submenu links are slightly closer to their
 own top-level link than to the next group. The descender on the letter `p`
 and the circle for the update count can make the Updates link look lower,
 too, even with the extra pixel on the bottom.

 Historically, though, the submenu's `7px` value seems to have been chosen
 for a mathematical equivalent.
 - [https://plugins.trac.wordpress.org/changeset/724106/mp6/trunk/css-no-
 wpadmin/wp-admin.css 724106] added the padding with a `1px` top margin.
 - Then [https://plugins.trac.wordpress.org/changeset/761665/mp6/trunk/css
 /wp-admin.css 761665] and
 [https://plugins.trac.wordpress.org/changeset/762292/mp6/trunk/css/wp-
 admin.css 762292] removed the top margin before the MP6 plugin's version
 2.0.

 If the top padding is worth changing to 8 pixels, `7px 0 8px;` would be
 replaced with the shorthand `8px 0;` (in both places:
 [https://github.com/WordPress/wordpress-
 develop/blob/7456ab64a00996b75701e4756f35d324ac554d84/src/wp-admin/css
 /admin-menu.css#L130 line 130] and [https://github.com/WordPress
 /wordpress-develop/blob/7456ab64a00996b75701e4756f35d324ac554d84/src/wp-
 admin/css/admin-menu.css#L582 line 582]).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61689#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform