[wp-trac] [WordPress Trac] #61114: PHP 8+ Fatal Error in WP_Upgrader due to TypeError in array_keys() Call

[WordPress Trac]

#61114: PHP 8+ Fatal Error in WP_Upgrader due to TypeError in array_keys() Call
----------------------------------------------------+---------------------
 Reporter:  verygoode                               |       Owner:  azaozz
     Type:  defect (bug)                            |      Status:  closed
 Priority:  normal                                  |   Milestone:  6.7
Component:  Upgrade/Install                         |     Version:  2.8
 Severity:  critical                                |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests needs-testing  |     Focuses:
----------------------------------------------------+---------------------
Changes (by azaozz):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"59257" 59257]:
 {{{
 #!CommitTicketReference repository="" revision="59257"
 Upgrade/Install: Return WP_Error when source files cannot be found.

 Fixes a fatal error in `array_keys()` (PHP 8.0+) as
 `$wp_filesystem->dirlist()` will return `false` when the source directory
 doesn't exist or becomes unreadable for some reason.

 Props: verygoode, lifelightweb, da5f656f, costdev, afragen, azaozz
 Fixes #61114
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61114#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform